[1.12.2] TileEntity doesn't sync to client.

[TheAwesomeGem]

The value cookTime on the client TileEntity is always 0. What am I doing wrong?

 

TileEntityOven

  Reveal hidden contents

public class TileEntityOven extends TileEntity implements ITickable
{
    public static final int TOTAL_COOK_TIME = 20 * 5;

    private ItemStackHandler inputSlot = new OvenInputSlotHandler();
    private ItemStackHandler fuelSlot = new OvenFuelSlotHandler();
    private ItemStackHandler outputSlot = new ItemStackHandler(1);
    private ItemStackHandler outputSlotWrapper = new OvenOutputSlotHandler(outputSlot);

    private short cookTime;

    public boolean isCooking()
    {
        return cookTime > 0;
    }

    public short getCookTime()
    {
        return cookTime;
    }

    private void processCooking()
    {
        if(world.isRemote)
            return;

        ItemStack inputItem = inputSlot.getStackInSlot(0);
        ItemStack fuelItem = fuelSlot.getStackInSlot(0);
        ItemStack outputItem = outputSlot.getStackInSlot(0);

        if((outputItem.isEmpty() || (!outputItem.isEmpty() && outputItem.getCount() <= 63))  && !inputItem.isEmpty()  && !fuelItem.isEmpty())
            startCooking();

        if(isCooking())
        {
            cookTime--;

            if(cookTime <= 0)
                stopCooking();

            markDirty();
        }

        //outputSlot.insertItem(0, new ItemStack(Items.COOKED_FISH, 1), false);
    }

    private void startCooking()
    {
        if(isCooking())
            return;

        inputSlot.extractItem(0, 1, false);
        fuelSlot.extractItem(0, 1, false);

        cookTime = TOTAL_COOK_TIME;
    }

    private void stopCooking()
    {
        outputSlot.insertItem(0, ItemManager.FISH_SLICE_COOKED.getItemStack(BetterFishType.TUNA.name(), 1, 8, 1.0f), false);
    }

    @Override
    public void update()
    {
        if(world.getBlockState(pos).getBlock() != this.getBlockType()) return;

        processCooking();
    }

    @Override
    public boolean hasCapability(Capability<?> capability, @Nullable EnumFacing facing)
    {
        return this.getCapability(capability, facing) != null;
    }

    @Nullable
    @Override
    public <T> T getCapability(Capability<T> capability, @Nullable EnumFacing facing)
    {
        if (capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
        {
            this.markDirty();

            if (world != null && world.getBlockState(pos).getBlock() != getBlockType())
            {
                return (T) new CombinedInvWrapper(inputSlot, fuelSlot, outputSlotWrapper);
            }
            if (facing == null)
            {
                return (T) new CombinedInvWrapper(inputSlot, fuelSlot, outputSlotWrapper);
            }
            if (facing == EnumFacing.DOWN || facing == EnumFacing.UP)
            {
                return (T) outputSlotWrapper;
            }
            if (facing == EnumFacing.NORTH || facing == EnumFacing.SOUTH)
            {
                return (T) inputSlot;
            }
            if(facing == EnumFacing.EAST || facing == EnumFacing.WEST)
            {
                return (T) fuelSlot;
            }
        }

        return super.getCapability(capability, facing);
    }

    @Override
    public boolean shouldRefresh(World world, BlockPos pos, IBlockState oldState, IBlockState newSate)
    {
        return oldState.getBlock() != newSate.getBlock();
    }

    @Override
    @Nullable
    public SPacketUpdateTileEntity getUpdatePacket()
    {
        NBTTagCompound updateTagDescribingTileEntityState = getUpdateTag();

        final int METADATA = 0;

        return new SPacketUpdateTileEntity(this.pos, METADATA, updateTagDescribingTileEntityState);
    }

    @Override
    public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt)
    {
        NBTTagCompound updateTagDescribingTileEntityState = pkt.getNbtCompound();

        handleUpdateTag(updateTagDescribingTileEntityState);
    }

    /* Creates a tag containing the TileEntity information, used by vanilla to transmit from server to client
       Warning - although our getUpdatePacket() uses this method, vanilla also calls it directly, so don't remove it.
     */
    @Override
    public NBTTagCompound getUpdateTag()
    {
        NBTTagCompound nbtTagCompound = new NBTTagCompound();

        this.writeToNBT(nbtTagCompound);

        return nbtTagCompound;
    }

    /* Populates this TileEntity with information from the tag, used by vanilla to transmit from server to client
     Warning - although our onDataPacket() uses this method, vanilla also calls it directly, so don't remove it.
   */
    @Override
    public void handleUpdateTag(NBTTagCompound tag)
    {
        this.readFromNBT(tag);
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound)
    {
        super.writeToNBT(compound);

        compound.setTag("input", inputSlot.serializeNBT());
        compound.setTag("output", outputSlot.serializeNBT());
        compound.setTag("fuel", fuelSlot.serializeNBT());
        compound.setShort("cookTime", cookTime);

        return compound;
    }

    @Override
    public void readFromNBT(NBTTagCompound compound)
    {
        super.readFromNBT(compound);

        if (compound.hasKey("input"))
            inputSlot.deserializeNBT(compound.getCompoundTag("input"));

        if (compound.hasKey("output"))
            outputSlot.deserializeNBT(compound.getCompoundTag("output"));

        if (compound.hasKey("fuel"))
            fuelSlot.deserializeNBT(compound.getCompoundTag("fuel"));

        if (compound.hasKey("cookTime"))
        {
            this.cookTime = compound.getShort("cookTime");
        }
    }
}

 

 

GuiOven

  Reveal hidden contents

public class GuiOven extends GuiContainer
{
    private Container container;
    private TileEntityOven tileEntity;

    private static ResourceLocation OVEN_GUI_TEXTURE = new ResourceLocation("textures/gui/container/furnace.png");

    public GuiOven(Container container, TileEntityOven tileEntity)
    {
        super(container);

        this.container = container;
        this.tileEntity = tileEntity;
    }

    /**
     * Draws the screen and all the components in it.
     */
    public void drawScreen(int mouseX, int mouseY, float partialTicks)
    {
        this.drawDefaultBackground();
        super.drawScreen(mouseX, mouseY, partialTicks);
        this.renderHoveredToolTip(mouseX, mouseY);
    }

    /**
     * Draw the foreground layer for the GuiContainer (everything in front of the items)
     */
    protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY)
    {
        String title = new TextComponentTranslation("container.betterfishing:oven").getUnformattedText();
        String playerTitle = new TextComponentTranslation("container.inventory").getUnformattedText();

        this.fontRenderer.drawString(title, this.xSize / 2 - this.fontRenderer.getStringWidth(title) / 2, 6, 4210752);
        this.fontRenderer.drawString(playerTitle, 8, this.ySize - 96 + 2, 4210752);
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY)
    {
        GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);

        this.mc.getTextureManager().bindTexture(OVEN_GUI_TEXTURE);

        int xCoord = (this.width - this.xSize) / 2;
        int yCoord = (this.height - this.ySize) / 2;

        this.drawTexturedModalRect(xCoord, yCoord, 0, 0, this.xSize, this.ySize);

        if (tileEntity.isCooking())
        {
            int burnLeftScaled = this.getBurnLeftScaled(13);

            this.drawTexturedModalRect(xCoord + 56, yCoord + 36 + 12 - burnLeftScaled, 176, 12 - burnLeftScaled, 14, burnLeftScaled + 1);
        }

        int cookProgressScaled = this.getCookProgressScaled(24);

        this.drawTexturedModalRect(xCoord + 79, yCoord + 34, 176, 14, cookProgressScaled + 1, 16);
    }

    private int getCookProgressScaled(int pixels)
    {
        int cookTime = tileEntity.getCookTime();
        int totalCookTime = tileEntity.TOTAL_COOK_TIME;

        System.out.println("Client Cook Time: " + cookTime + "/" + totalCookTime);

        if(cookTime <= 0)
            return 0;

        return cookTime * pixels / totalCookTime;
    }

    private int getBurnLeftScaled(int pixels)
    {
        int itemBurnTime = 1;
        int burnTime = 1;

        return burnTime * pixels / itemBurnTime;
    }
}

 

 

[TheAwesomeGem]

  On 1/2/2018 at 11:23 PM, diesieben07 said:

You never set cookTime on the client. Look at the furnace container.

Expand  

Yeah but Furnace Container uses IInventory and setField to update it.

[TheAwesomeGem]

  On 1/2/2018 at 11:25 PM, diesieben07 said:

... so?

Expand  

There is no such option for ItemHandler.

[TheAwesomeGem]

  On 1/2/2018 at 11:27 PM, diesieben07 said:

Why not? Also, IItemHandler has nothing to do with this.

Expand  

Can I implement IInventory whilst also using IItemHandler. The way the furnace updates GUI is using the IInventory fields.

[TheAwesomeGem]

  On 1/2/2018 at 11:29 PM, diesieben07 said:

You could, in theory, but it makes no sense.

 

Yes, but you are not using IInventory.

Expand  

Exactly. So I cannot use setFields. I though marking the block dirty after setting the cookTime would automatically update it due to the update packet function. But it does not.

[TheAwesomeGem]

  On 1/2/2018 at 11:32 PM, diesieben07 said:

You don't need to.

 

Please don't use that way. You should keep network traffic as low as possible. Syncing cookTime every tick to every player within render distance even if they are not looking at the GUI is completely overkill.

Expand  

 

What way do you suggest? How to sync TileEntity GUI with the TileEntity?

[TheAwesomeGem]

  On 1/2/2018 at 11:34 PM, diesieben07 said:

Already told you: Look at ContainerFurnace.

Expand  

 

Aaah you mean detectAndSendChanges method? And that works without IInventory and the fields? Nice.

[TheAwesomeGem]

  On 1/2/2018 at 11:39 PM, diesieben07 said:

Why would it not? Have you bothered to actually look at the code? ...

Expand  

 

I might have overlooked it. Will try it out and see if it works.