Jump to content

[1.12.2] Custom GuiButton Drawing Artifacts


KittenKoder

Recommended Posts

I have this button I extended from GuiButton because I couldn't get the regular texture button to work. Here's the class:

 

package com.kittenkoder.magitech.gui;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

@SideOnly(Side.CLIENT)
public class MagitechGUIButtonTexture extends GuiButton {
	protected ResourceLocation _texture;
	protected int _texx, _texy;
	
	public MagitechGUIButtonTexture(int buttonId, int x, int y, int widthIn,
			int heightIn, ResourceLocation texture, int tx, int ty) {
		super(buttonId, x, y, widthIn, heightIn, "");
		this._texture = texture;
		this._texx = tx;
		this._texy = ty;
	}
	
	public void setTexCoords(int x, int y) {
		this._texx = x;
		this._texy = y;
	}
	
	public void drawButton(Minecraft mc, int mouseX, int mouseY, float partialTicks) {
		if(!this.visible) return;
        mc.getTextureManager().bindTexture(this._texture);
        GlStateManager.color(1.0F, 1.0F, 1.0F, 1.0F);
        GlStateManager.enableBlend();
        GlStateManager.tryBlendFuncSeparate(GlStateManager.SourceFactor.SRC_ALPHA, GlStateManager.DestFactor.ONE_MINUS_SRC_ALPHA, GlStateManager.SourceFactor.ONE, GlStateManager.DestFactor.ZERO);
        GlStateManager.blendFunc(GlStateManager.SourceFactor.SRC_ALPHA, GlStateManager.DestFactor.ONE_MINUS_SRC_ALPHA);
        this.drawTexturedModalRect(this.x, this.y, this._texx, this._texy, this.width, this.height);

	}

}

 

The problem is that it's drawing something odd to the right of the GUI, here's an image:

 

2018-01-16_05_52_37.png.2fb44fc78f6da8ecf5d8e42a7327ce44.png

It looks like it's drawing one of the texture coordinates there as when I change the buttons' contents (which only changes where it gets the texture piece from) the artifacts change. Did I forget to override something? The Gui and GuiButton source hasn't offered much clues into this. In case it's the GUI that the buttons are being added to, here's that:

package com.kittenkoder.magitech.gui;

import java.io.IOException;

import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.client.resources.I18n;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.util.ResourceLocation;

import com.kittenkoder.magitech.Magitech;
import com.kittenkoder.magitech.tile.MagitechTileEntitySorter;
import com.kittenkoder.magitech.util.MagitechUtils;

public class MagitechGUISorter extends GuiContainer {
	private static final ResourceLocation BG_TEXTURE = new ResourceLocation(Magitech.MODID, "textures/gui/container/pipe_sorter.png");
//	private static final String TEXT_INPUT =  I18n.format("text.gui_sorter.input");
//	private static final String TEXT_OUTPUT =  I18n.format("text.gui_sorter.output");

	private InventoryPlayer _player;
	private MagitechTileEntitySorter _sorter;

	public MagitechGUISorter(Container inventorySlotsIn, InventoryPlayer player, MagitechTileEntitySorter sorter) {
		super(inventorySlotsIn);
		this._sorter = sorter;
		this._player = player;
		this._sorter.setGUI(this);
	}
	
	public void initGui() {
		super.initGui();
		int x = (width - xSize) / 2;
		int y = (height - ySize) / 2;
		
		this.buttonList.add(this.createButton(MagitechTileEntitySorter.Job.SORT_1, x, y));
		this.buttonList.add(this.createButton(MagitechTileEntitySorter.Job.SORT_2, x, y));
		this.buttonList.add(this.createButton(MagitechTileEntitySorter.Job.SORT_3, x, y));
		this.buttonList.add(this.createButton(MagitechTileEntitySorter.Job.SORT_4, x, y));
		this.buttonList.add(this.createButton(MagitechTileEntitySorter.Job.OUTPUT, x, y));
	}
	
	
	
	protected MagitechGUIButtonTexture createButton(MagitechTileEntitySorter.Job job, int x, int y) {
		int sx = 0;
		int sy = 0;
		int dx = 0; 
		int dy = 0; 
		
		MagitechUtils.Facing face = this._sorter.getFacing(job);
		
		if(MagitechUtils.Facing.DOWN == face) sx = 16;
		else if(MagitechUtils.Facing.NORTH == face) sy = 16;
		else if(MagitechUtils.Facing.SOUTH == face) sy = 32;
		else if(MagitechUtils.Facing.WEST == face) {
			sx = 16;
			sy = 16;
		} else if(MagitechUtils.Facing.EAST == face) {
			sx = 16;
			sy = 32;
		}
		
		if(MagitechTileEntitySorter.Job.SORT_2 == job) dy = 36;
		else if(MagitechTileEntitySorter.Job.SORT_3 == job) dx = 36;
		else if(MagitechTileEntitySorter.Job.SORT_4 == job) {
			dx = 36;
			dy = 36;
		} else if(MagitechTileEntitySorter.Job.OUTPUT == job) {
			dx = 18;
			dy = 18;
		}

		MagitechGUIButtonTexture butt = new MagitechGUIButtonTexture(job._index, 62 + x + dx, 17 + y + dy, 16, 16, BG_TEXTURE, sx + 176, sy);
		return butt;
	}
	
	public void updateButton(MagitechTileEntitySorter.Job job, MagitechUtils.Facing face) {
		int i = job._index;
		for(GuiButton button : this.buttonList) {
			if(button.id == i) {
				MagitechGUIButtonTexture butt = (MagitechGUIButtonTexture)button;
				int sx = 0;
				int sy = 0;
				
				if(MagitechUtils.Facing.DOWN == face) sx = 16;
				else if(MagitechUtils.Facing.NORTH == face) sy = 16;
				else if(MagitechUtils.Facing.SOUTH == face) sy = 32;
				else if(MagitechUtils.Facing.WEST == face) {
					sx = 16;
					sy = 16;
				} else if(MagitechUtils.Facing.EAST == face) {
					sx = 16;
					sy = 32;
				}
				
				butt.setTexCoords(sx + 176, sy);
				return;
			}
		}
		
	}
	
	protected void updateButton(GuiButton button) {
		if(button instanceof MagitechGUIButtonTexture) {
			MagitechGUIButtonTexture butt = (MagitechGUIButtonTexture)button;
			int sx = 0;
			int sy = 0;
			
			MagitechUtils.Facing face = this._sorter.getFacing(button.id);
			
			if(MagitechUtils.Facing.DOWN == face) sx = 16;
			else if(MagitechUtils.Facing.NORTH == face) sy = 16;
			else if(MagitechUtils.Facing.SOUTH == face) sy = 32;
			else if(MagitechUtils.Facing.WEST == face) {
				sx = 16;
				sy = 16;
			} else if(MagitechUtils.Facing.EAST == face) {
				sx = 16;
				sy = 32;
			}
			
			butt.setTexCoords(sx + 176, sy);
		}
	}
	
	protected void actionPerformed(GuiButton button) throws IOException {
		int i = button.id;
		if(i > -1 && i < 5) {
			this._sorter.setIntegerToUpdate(i, 0, true);
			return;
		}
		
		super.actionPerformed(button);
	}
	
	protected void drawFace(MagitechTileEntitySorter.Job job, int x, int y) {
		int sx = 0;
		int sy = 0;
		int dx = 0; 
		int dy = 0; 
		
		MagitechUtils.Facing face = this._sorter.getFacing(job);
		
		if(MagitechUtils.Facing.DOWN == face) sx = 16;
		else if(MagitechUtils.Facing.NORTH == face) sy = 16;
		else if(MagitechUtils.Facing.SOUTH == face) sy = 32;
		else if(MagitechUtils.Facing.WEST == face) {
			sx = 16;
			sy = 16;
		} else if(MagitechUtils.Facing.EAST == face) {
			sx = 16;
			sy = 32;
		}
		
		if(MagitechTileEntitySorter.Job.SORT_2 == job) dy = 36;
		else if(MagitechTileEntitySorter.Job.SORT_3 == job) dx = 36;
		else if(MagitechTileEntitySorter.Job.SORT_4 == job) {
			dx = 36;
			dy = 36;
		} else if(MagitechTileEntitySorter.Job.OUTPUT == job) {
			dx = 18;
			dy = 18;
		}

		drawTexturedModalRect(dx + 62 + x, dy + 17 + y, sx + 176, sy, 16, 16);
	}
	
	@Override
	protected void drawGuiContainerBackgroundLayer(float partialTicks,
			int mouseX, int mouseY) {
		GlStateManager.color(1, 1, 1, 1);
		mc.getTextureManager().bindTexture(BG_TEXTURE);
		int x = (width - xSize) / 2;
		int y = (height - ySize) / 2;
		drawTexturedModalRect(x, y, 0, 0, xSize, ySize);
	}

	public void drawScreen(int mouseX, int mouseY, float partialTicks)
    {
        this.drawDefaultBackground();
        super.drawScreen(mouseX, mouseY, partialTicks);
        this.renderHoveredToolTip(mouseX, mouseY);
    }
	
	@Override
	protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY) {
		String name = I18n.format(this._sorter.getBlockType().getUnlocalizedName() + ".name");
		this.fontRenderer.drawString(name, xSize / 2 - fontRenderer.getStringWidth(name) / 2, 6, 0x404040);
		this.fontRenderer.drawString(this._player.getDisplayName().getUnformattedText(), 8, ySize - 94, 0x404040);

		int x = (width - xSize) / 2;
		int y = (height - ySize) / 2;
		
		this.drawFace(MagitechTileEntitySorter.Job.SORT_1, x, y);
		this.drawFace(MagitechTileEntitySorter.Job.SORT_2, x, y);
		this.drawFace(MagitechTileEntitySorter.Job.SORT_3, x, y);
		this.drawFace(MagitechTileEntitySorter.Job.SORT_4, x, y);
		this.drawFace(MagitechTileEntitySorter.Job.OUTPUT, x, y);
	}
	
	protected void jobClicked(MagitechTileEntitySorter.Job job) {
		this._sorter.setJob(job, this._sorter.getFacing(job).getNext());
	}
		
	protected void renderHoveredToolTip(int x, int y) {
		super.renderHoveredToolTip(x, y);
	}
	
	public void onGuiClosed() {
		this._sorter.setGUI(null);
		super.onGuiClosed();
	}
}

On this, in insight would be helpful to get rid of it.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.