[1.12.2] Variant Items - Naming [SOLVED]

[HalestormXV]

So I decided to bump my modding into 1.12.2 to try and stay with the times. Wasn't too hard to migrate from 1.11.2 but I started fresh to and see a huge reliance now on JSON, which is fine. I understand it well enough. However I have run into a slight issue. I am sure I have to change something in my JSON to get this working but Im not sure what. 

 

I have an item, it has subtypes. The item registers just fine, gets added to the game just fine and has the correct name. The variatns register the different textures. No issues.

Only problem I seem to have is that the name for the item (And its variants/subtypes) is all item.item_runestone.name. It has the correct meta data values assigned to it from 0 - 5.

So I am guessing perhaps I have to indicate in my .JSON how it should be names?

 

Here is the JSON:

https://pastebin.com/5jS9ECNd

Each Respective Runestone JSON:

https://pastebin.com/mchBZipj (there are 5 more of these each named properly. The only thing that changes in each is the 

"layer0": "hsrs:items/runestones/rune_air"

To the proper runestone.

 

If you need anything else please let me know, but I'm imagining since nothing is erroring it isn't anything code related and purely the way i constructed the .json But then again I could be wrong.\

 

Is it supposed to be something like:

"variant=rune_basic": { "model": "hsrs:runestones/rune_basic", "displayName": "Basic Runestone" },

 

Maybe?

 

Edited January 23, 2018 by HalestormXV

[jabelar]

How are you registering your item models? I think the ModelLoader.setCustomModelResourceLocation() method can take metadata values. So one approach is to have separate JSON for each subtype and register them accordingly by metadata.

Edited January 23, 2018 by jabelar

[Choonster]

Unlocalised names are controlled by the Item class and translations of those are specified in the lang files, there's no JSON involved.

 

If your variants were displaying their names correctly in 1.11.2, they should still do so in 1.12.2 unless you've changed something.

 

Post your Item class, the class where you register your Items and your en_us.lang file.

[HalestormXV]

8 hours ago, Choonster said:

Unlocalised names are controlled by the Item class and translations of those are specified in the lang files, there's no JSON involved.

 

If your variants were displaying their names correctly in 1.11.2, they should still do so in 1.12.2 unless you've changed something.

 

Post your Item class, the class where you register your Items and your en_us.lang file.

 

Found it. I forgot to add my:

@Override
public String getUnlocalizedName(ItemStack stack)
{
    return super.getUnlocalizedName()+ "_" + this.getSpecialName(stack);
}

 

into the class. That was an oversight on my part.

 

But for anyone who is interested on how I did it. (Not sure if it is the "conventional" way for whatever new standards are set for 1.12.2)

Here it is:

 

ItemRunes:

https://pastebin.com/rnddRz7c

 

RunesHandler:

https://pastebin.com/sB0x4exm

 

All items and blocks are registered in a separate class but that doesn't show any functionality on how the actual runes are handled and registered so I just left them out.