[1.12.2] Fluid Creation and Changes?

[HalestormXV]

So I am trying to create some custom fluids and I found a thread here that was responded to by @Choonster and he gave an excellent link to his Repo on how he does Fluids and it is well documented but it is for 1.10.2. However, it all looks to still be applicable to 1.12.2 with the exception of this https://github.com/Choonster-Minecraft-Mods/TestMod3/blob/78140ee977ac6bdfe1b455a2de54c9cd777b693b/src/main/java/choonster/testmod3/client/model/ModModelManager.java#L52-L72. Apparently, ModelLoader.setCustomMeshDefinition(item, MeshDefinitionFix.create is no longer valid. I'm just curious to know what this has been changed to, or if there is another way to do this now in 1.12.2 that can be applied to the code.

[CoderAtParadise]

In the 1.12.2 branch MeshDefinitionFix is gone as it was a fix for lambda's not working that is only difference I can see

[HalestormXV]

21 minutes ago, CoderAtParadise said:

In the 1.12.2 branch MeshDefinitionFix is gone as it was a fix for lambda's not working that is only difference I can see

So the correct format would be: 

ModelLoader.setCustomMeshDefinition(item, (stack -> modelResourceLocation))

 

Or something else entirely?

[CoderAtParadise]

that without the extra brackets is the 1.12.2 branch

[HalestormXV]

1 hour ago, CoderAtParadise said:

that without the extra brackets is the 1.12.2 branch

 

Spoiler

 

Gotcha, and would you happen to know if the .json format changed for them also? I am getting this: https://pastebin.com/JvbTLmwP

 

And I am imaging that is happening becasue the only blockstate .json file is called fluid and perhaps a .json format has changed? ( I doubt it but it is just something I noticed). 

1.10.2 Version is this: https://tinyurl.com/yaw4ofw2

1.12.2 Version (from AbyssalCraft) looks like this: https://pastebin.com/p1AmWiMV

 

Or maybe it is more likely that it is look for fluid.normal or fluid.normal_gas etc. etc. in the blockstates? As opposed to just using the fluid.json? For some reason I can never get my .jsons right on the first go around.

 

And no i never once worked with fluids unfortunatly so this is quite literally ALL new to me, so I appologize for the lack of competence I have with this lol. But I can never learn if I don't try.

 

 

 

EDIT: Nevermind, stupid mistake on my part as is often the case. I fixed it. However I do have a question somewhat related to fluids since I am new to them and all. How do I make it act like water where it pushes the player and stuff like that? Or if they go into a "gas" liquid it will make them float up and stuff. Or apply potion effects and cool little things like that? Does that use the onEntityCollide function or something like that? Im guessing 

BlockFluidClassic

has all of those nifty little things in it? So I'd just be able to make something that extends that.

Edited February 13, 2018 by HalestormXV