Jump to content

Recommended Posts

Posted

Hello All,

 

I've been having trouble generating ore in the Nether. My ore generates fine in Overworld, but it never shows up below.

Here is my WorldGenOre class:

package org.gsa.basemod.World;


import net.minecraft.block.state.IBlockState;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraftforge.fml.common.IWorldGenerator;
import org.gsa.basemod.init.ModBlocks;

import java.util.Random;

public class WorldGenOre implements IWorldGenerator {


    @Override
    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

        /*
        if(world.provider.getDimension() == 0) {
            generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);
        }
        */
        if(world.provider.getDimension() == -1){
            generateNether(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);
        }

    }

    private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
        /*
        This method is what places the blocks in the world. Size aregument gives minimum number per chunk and adds a random number up to but not including 4. Chances is
        how many times the probability of the ore is checked per chunk.
         */
        generateOre(ModBlocks.dice.getDefaultState(), world, random, chunkX * 16, chunkZ * 16, 16, 100, 4 + random.nextInt(4), 16);
    }

    private void generateNether(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
        /*
        This method is what places the blocks in the world. Size aregument gives minimum number per chunk and adds a random number up to but not including 4. If it's too high the game crashes.
        Chances is how many times the probability of the ore is checked per chunk.
         */
        generateOre(ModBlocks.dice.getDefaultState(), world, random, chunkX * 16, chunkZ * 16, 0, 256, 10 + random.nextInt(4), 10);
    }

    private void generateOre(IBlockState ore, World world, Random random, int x, int z, int minY, int maxY, int size, int chances){

        int deltaY = maxY - minY;
        for(int i=0; i<chances; i++){
            BlockPos pos = new BlockPos(x + random.nextInt(16), minY + random.nextInt(deltaY), z + random.nextInt(16));
            WorldGenMinable generator = new WorldGenMinable(ore, size);
            generator.generate(world, random, pos);
        }
    }
}

I've also tried it with switch statements and got the same results. i can find the dice blocks in Overworld but not the Nether.

 

Thanks!

Posted

If you use the WorldGenMinable(IBlockState, int) constructor, your ore will only generate in the "natural" variants of Blocks.STONE (i.e. Stone, Granite, Diorite or Andesite; but not the Smooth variants). These don't normally generate in the Nether, so your ore won't generate either.

 

To generate your ore in other blocks, you need to use the WorldGenMinable(IBlockState, int, Predicate<IBlockState>) constructor and supply a Predicate that returns true for the block(s) your ore can generate in.

 

Vanilla provides several Predicate<IBlockState> implementations in the net.minecraft.block.state.pattern package, you can also specify your own using a lambda or method reference.

  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

This code worked. I'll probably bring back the switch statement next.

 

package org.gsa.basemod.World;
 
 
import net.minecraft.block.Block;
import net.minecraft.block.state.IBlockState;
import net.minecraft.block.state.pattern.BlockMatcher;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraftforge.fml.common.IWorldGenerator;
import org.gsa.basemod.init.ModBlocks;
 
import java.util.Random;
 
public class WorldGenOre implements IWorldGenerator {
 
 
 
    @Override
    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
 
 
        if(world.provider.getDimension() == 0) {
            generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);
        }
 
        if(world.provider.getDimension() == -1){
            generateNether(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);
        }
 
    }
 
    private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
        /*
        This method is what places the blocks in the world. Size aregument gives minimum number per chunk and adds a random number up to but not including 4. Chances is
        how many times the probability of the ore is checked per chunk.
         */
        generateOre(ModBlocks.dice.getDefaultState(), world, random, chunkX * 16, chunkZ * 16, 16, 100, 4 + random.nextInt(4), 16, Blocks.STONE);
    }
 
    private void generateNether(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
        /*
        This method is what places the blocks in the world. Size arguement gives minimum number per chunk and adds a random number up to but not including 4. If it's too high the game crashes.
        Chances is how many times the probability of the ore is checked per chunk.
         */
        generateOre(ModBlocks.dice.getDefaultState(), world, random, chunkX * 16, chunkZ * 16, 0, 256, 10 + random.nextInt(4), 10, Blocks.NETHERRACK);
/*At the end you call a block that your ore can generate on. This includes any natural state of Netherrack. The default is stone, so if you don't call this in WorldGenMinable your ore won't generate in the Nether because there is no stone in the nether.*/
    }
 
    private void generateOre(IBlockState ore, World world, Random random, int x, int z, int minY, int maxY, int size, int chances, Block block){
 
        int deltaY = maxY - minY;
        for(int i=0; i<chances; i++){
            BlockPos pos = new BlockPos(x + random.nextInt(16), minY + random.nextInt(deltaY), z + random.nextInt(16));
            WorldGenMinable generator = new WorldGenMinable(ore, size, BlockMatcher.forBlock(block));
            //The last parameter in the WorldGenMinable constructor is the block your ore can generate on.
            generator.generate(world, random, pos);
        }
    }
}

 

  • 1 year later...
  • Guest locked this topic
Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Please read the FAQ and post logs as described there.
    • Upon starting the server I get; [main/ERROR] [minecraft/Main]: Failed to start the minecraft server net.minecraftforge.fml.LoadingFailedException: Loading errors encountered: [     Framework (framework) has failed to load correctly §7java.lang.NoClassDefFoundError: net/minecraft/client/gui/components/toasts/Toast ] I suspect there is a (possibly a few) client-only mods installed on my server. Any help would be appreciated! (Yes I know there are a lot of mods...) Here is the crash log:   https://paste.ee/p/pRz5mhMl#s=0
    • That's basically what the failure does, my apologies for failing to specify.  It just tries again on the next tick until it detects the entities for that chunk are loaded, and then tries to load the entity.  From there it gets into different failure states depending on what goes wrong, but in short, if the entity fails to load once the entity list becomes available, the request is cleared and must be resubmitted by the end user.  There should be few cases where that actually happens. Yes, that is my understanding of forceloading.  That's why on a successful summon, it removes the forceload.  Otherwise it does just leave the chunks loaded long term. Thank you for your help, any knowledge is useful!  I don't often mess with forceloading and my prior experience is 1.16 so I'm also a bit out of my depth haha.
    • I will have to do more research about 1.18 chunk loading. You were unclear about how your code manages with the entity load failure. If you simply used a loop, I suggest submitting a tick task to the next tick which does the same thing, checking if the entities are loaded and if so teleporting the right one else submitting another tick task etc. Also I think forceloading permanently force loads the chunk, and it only starts to unload when you make a subsequent call to mark the chunk as not forceloaded. I may be completely wrong, I dont know much about 1.18, most of my experience is 1.20. Good luck I hope you figure it out after all this time 😅
    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.