Did MathHelper.clampAngle change?

[Felina-Lain]

Hello, me again, very sorry but I have an error that stop me from compiling (but apparently during test-play it doesn't seems to break anything *shrug*)

 

final int pitchMin = MathHelper.clampAngle(getInt(argumentMap, ARGUMENT_ROTX_MIN, 0));

"The method clampAngle(int) is undefined for the type MathHelper"

 

I'm using forge-1.12.2-14.23.2.2611 mdk. Did the clampAngle function change name between this version and a previous one? I tried looking into clamp, or angle, but nothing that take the parameters I had, so I'm a bit confused.

(I'm really just beginning at modding, though I have background on java, and so far I'm learning by updating/changing open source mods for myself, and I managed to do so by guessing new names from old names and parameters but this one has me stumped, so sorry if this is another noob question)

 

thanks!

[crackedEgg]

Perhaps you're looking for MathHelper.clamp(int num, int min, int max), there are float and double versions too.

[Felina-Lain]

14 minutes ago, crackedEgg said:

Perhaps you're looking for MathHelper.clamp(int num, int min, int max), there are float and double versions too.

Well I thought so too, but I only got one argument to feed in there, unless I got to somehow switch the order of the clamp and getInt function around but when I tried, I got errors anyway

[Choonster]

MathHelper.wrapDegrees looks like the method you want.

 

I discovered this by opening the MathHelper class and looking for a method that appeared to clamp an angle. I probably could have used MCPBot to find the new name of the method as well.

[crackedEgg]

MathHelper.wrapDegrees wraps from -180 to +180 degrees. That may be what he needs here, but the getInt() part threw me off since the angles are ARGUMENT_ROTX_MIN and 0 (zero).

 

Falina-Lain: if you look at the clamp methods you can see that you can specify the values to clamp to.

final int pitchMin = MathHelper.clamp(argumentMap, ARGUMENT_ROTX_MIN, 0); 

I think that would work for you, if you need to clamp between zero and ARGUMENT_ROTX_MIN.

Edited March 16, 2018 by crackedEgg

[Felina-Lain]

wrapDegrees worked just fine

 

thank you both for the answers!