Forge miss display missing dependencies

[Naheulf]

At the beginning I was trying to find another bug in a modpack. I am one of the two people who manages this modpack.

To find which < mod | couple of mods > cause this bug I tried to remove a lot of mods at once from this modpack. Because I does not remember which mod use which library, I break some dependencies. At next launch forge display which dependencies are missing so I add them or remove the mod.

Some times forge does not display theses dependencies ... and Minecraft crash during startup.

 

This bug can be reproduce.

 

All mods/lib needed to reproduce this bug :

• Forge 14.23.2.2627
• Baubles 1.12-1.5.2 (required library for Botania)
• Botania r1.10-353
• Chisel MC1.12.2-0.2.0.31
• CTM MC1.12-0.2.3.12 (required library for Chisel)

 

Case 1:  If all dependencies are met:

• Forge only
• Baubles only
• Bauble and Botania
• CTM only
• CTM and Chisel
• Bauble and CTM
• Bauble and CTM and Botania
• Bauble and CTM and Chisel
• Bauble and CTM and Botania and Chisel

Then Minecraft start normally.

 

Case 2: If Botania is installed but not Baubles

• Botania
• Botania and Chisel
• Botania and CTM
• Botanial and Chisel and CTM

Then forge display:

Quote

Botania is missing mods it depends on.

Include the following mods or remove Botania.

baubles 1.5.2 or above

See 'fml-client-latest.log' for technical information.

Note: Forge does NOT display missing CTM for Chisel if Bauble is missing for Botania. This is strange but why not ?

 

Case 3: If Chisel is installed but neither CTM nor Botania:

• Chisel
• Chisel and Baubles

Then forge display:

Quote

Chisel is missing mods it depends on.

Include the following mods or remove Chisel.

CTM MC1.12-0.2.3.8 or above

See 'fml-client-latest.log' for technical information.

 

case last: all mods are installed except CTM:

• Bauble and Botania and Chisel

Then minecraft crash... WHY forge does not display "Chisel is missing mods [...] CTM [...]" ?

 

Edited March 17, 2018 by Naheulf
Remove duplicate content due to copy/paste

[Choonster]

This is because Chisel doesn't actually declare CTM as a dependency, it runs some client-only code in preInit to detect whether CTM is present and display the Missing Mods screen if it isn't.

 

I believe it does this because CTM is only required on the client and not on the server.

 

Edited March 17, 2018 by Choonster

[Naheulf]

There no client only dependency in forge ?

[Choonster]

6 hours ago, Naheulf said:

There no client only dependency in forge ?

 

There are, added in this PR specifically for situations like Chisel and CTM. tterag1098 (the primary maintainer of Chisel) said here that they'd switch to this system for CTM as soon as possible, but it appears that this has been forgotten.

 

I've reported this to Chisel here.

Edited March 18, 2018 by Choonster