[SOLVED] Custom Item Drops for Blocks for 1.12.2

[34486]

Forge 1.12.2

Hopefully I am asking in the correct place! How can I make my blocks in my mod drop specific items, or a list of items. I have googled this already, and found that nothing is 'working' I get no errors once I fix the things Eclipse Oxygen.2 tells me to do, and the game runs and starts with no error, but does not drop what I want when I break the block.. again with no error!  I am sorry that I have not been able to successfully google something that is clear for my stupid mind to comprehend, so I post here for help, I hope. 

 

How and where can I implement a custom block drop?  I'll post some images of my work space so you can tell me where I need to put what and how. I'll open some classes too, which I feel might need to have something changed. 

Edited March 23, 2018 by 34486
Changed the title..

[larsgerrits]

Override Block#getDrops.

 

Also, the IHasModel method of registering models makes no sense. Every Block and Item needs a model.

[34486]

8 minutes ago, larsgerrits said:

Override Block#getDrops.

 

Also, the IHasModel method of registering models makes no sense. Every Block and Item needs a model.

Eclipse suggested I add this into BlockBase class

public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) {
        // TODO Auto-generated method stub
        return null;
    }

 

I put this in the OreBlock class

@Override
     public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) {
     ArrayList<ItemStack> stack = super.getDrops(world, x, y, z, metadata, fortune);
     stack.add(new ItemStack(Items.APPLE, 2));
     return stack;
     }

 

I get NO errors when loading, running or exiting the client. It does not drop an APPLE, Which I am using for simplicity, and to drop 2 of them. 

 

Is this what you mean by Override Block#getDrops? I'm really dumb, sorry, trying to learn this for the 4th time, tried in 1.6, failed, 1.7, failed, .1.10, failed, trying 1.12.2

[34486]

2 minutes ago, diesieben07 said:

What version are you coding in? In 1.12.x you should be using 

void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune)

1.12.2, Latest Forge Version. 

[34486]

4 minutes ago, diesieben07 said:

That is impossible there is no ArrayList-returning getDrops in latest Forge.

Ok, In my OreBlocks source I added this

public void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune) {
        
        
        
    }

 

But what do I put inside the brackets, getDrops(); just gets crossed out with an error and drops.* has nothing useful. 

[34486]

2 minutes ago, diesieben07 said:

You know how a List works in Java, yes? If not, you need to go learn basic Java.

Ok, I understand that the arraylist was used in 1.7 and not 1.12.2, I cannot find anything useful, and yes (I hope...) , for example you can take numbers, then print them out in the console, added or not. 

 

What exactly do I need to put where? Currently I am trying to find something similar to this in other peoples source, and right now am having no luck.

[34486]

Ok, I just used this... I was unsure of the itemstacks, Like return Moditems.x wasn't working. 

 

public Item getItemDropped(IBlockState state, Random rand, int fortune) {
          return YourItemClassName.ItemYouWantToDrop;
         }
    
    public int quantityDropped(IBlockState state, int fortune, Random random) {
          return random.nextInt(2) + 1;               // <--- This will drop 1 to 2 items, and the +1 is so its not from 0 to 2. 
         }

 

[hetsunami]

On 3/23/2018 at 7:25 PM, 34486 said:

Ok, I just used this... I was unsure of the itemstacks, Like return Moditems.x wasn't working. 

 

public Item getItemDropped(IBlockState state, Random rand, int fortune) {
          return YourItemClassName.ItemYouWantToDrop;
         }
    
    public int quantityDropped(IBlockState state, int fortune, Random random) {
          return random.nextInt(2) + 1;               // <--- This will drop 1 to 2 items, and the +1 is so its not from 0 to 2. 
         }

 

Man you're actually the best person ever. I'm super new to this yet your code is super understandable and made getting multiple drops form one piece of ore really easy. Thanks man.