Hi,

 

I'm working on updating my old mod from 1.7.10 to 1.12.2. I'm having trouble updating one of my entities (a projectile similar to a snowball). The entity itself works fine, but I haven't been able to get it to render; it's invisible. I've looked around tutorials and this forum for a while but haven't found anything that worked.

 

Here's my entity renderer class:

 

public class RenderMagicOrb extends Render<EntityMagicOrb> {

    private static ResourceLocation TEXTURE_RED = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_red.png");
    private static ResourceLocation TEXTURE_YELLOW = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_yellow.png");
    private static ResourceLocation TEXTURE_GREEN = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_green.png");
    private static ResourceLocation TEXTURE_BLUE = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_blue.png");
    private static ResourceLocation TEXTURE_BLACK = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_black.png");
    private static ResourceLocation TEXTURE_WHITE = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_white.png");

    public RenderMagicOrb(RenderManager renderManagerIn) {
        super(renderManagerIn);
    }

    public void doRender(@Nonnull EntityMagicOrb entity, double x, double y, double z,
                         float entityYaw, float partialTicks) {
        GlStateManager.pushMatrix();
        bindEntityTexture(entity);
        GlStateManager.translate((float)x, (float)y, (float)z);
        GlStateManager.enableRescaleNormal();
        GlStateManager.scale(2.0F, 2.0F, 2.0F);
        Tessellator tessellator = Tessellator.getInstance();
        BufferBuilder bufferbuilder = tessellator.getBuffer();

        GlStateManager.rotate(180.0F - this.renderManager.playerViewY, 0.0F, 1.0F, 0.0F);
        GlStateManager.rotate((float)(this.renderManager.options.thirdPersonView == 2 ? -1 : 1) * -this.renderManager.playerViewX, 1.0F, 0.0F, 0.0F);

        if (renderOutlines) {
            GlStateManager.enableColorMaterial();
            GlStateManager.enableOutlineMode(this.getTeamColor(entity));
        }

        bufferbuilder.begin(7, DefaultVertexFormats.POSITION_TEX_NORMAL);
        bufferbuilder.pos(-0.5D, -0.25D, 0.0D).tex(0.0D, 1.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        bufferbuilder.pos(0.5D, -0.25D, 0.0D).tex(1.0D, 1.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        bufferbuilder.pos(0.5D, 0.75D, 0.0D).tex(1.0D, 0.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        bufferbuilder.pos(-0.5D, 0.75D, 0.0D).tex(0.0D, 0.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        tessellator.draw();

        if (renderOutlines) {
            GlStateManager.disableOutlineMode();
            GlStateManager.disableColorMaterial();
        }

        GlStateManager.disableRescaleNormal();
        GlStateManager.popMatrix();
        super.doRender(entity, x, y, z, entityYaw, partialTicks);
    }

    @Override
    protected ResourceLocation getEntityTexture(@Nonnull EntityMagicOrb entity) {
        switch (entity.getElement()) {
            case RED:
                return TEXTURE_RED;
            case YELLOW:
                return TEXTURE_YELLOW;
            case GREEN:
                return TEXTURE_GREEN;
            case BLUE:
                return TEXTURE_BLUE;
            case BLACK:
                return TEXTURE_BLACK;
            case WHITE:
                return TEXTURE_WHITE;
        }
        //Default, should never happen
        return TEXTURE_RED;
    }
}

 

And here's my ClientProxy:

 

@Mod.EventBusSubscriber(Side.CLIENT)
public class ClientProxy extends CommonProxy {
    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);
        RenderingRegistry.registerEntityRenderingHandler(EntityMagicOrb.class, new IRenderFactory<EntityMagicOrb>() {
            @Override
            public Render<? super EntityMagicOrb> createRenderFor(RenderManager manager) {
                return new RenderMagicOrb(manager);
            }
        });
    }

    @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event) {

    }

    @Override
    public void registerItemRenderer(Item item, int meta, String id) {
        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(MagicMod.MODID + ":" + id, "inventory"));
    }
}

 

Here's the entity class itself, though I don't think it's the problem

 

public class EntityMagicOrb extends EntityThrowable implements IEntityAdditionalSpawnData {

    private SpellProjectile spell;
    private float gravity = 0.03F;

    public EntityMagicOrb(World world, EntityPlayer player, SpellProjectile spell) {
        super(world, player);
        this.shoot(player, player.rotationPitch, player.rotationYaw,
                0.0F, 1.5F, 1.0F);

        this.spell = spell;
    }

    @Override
    protected void onImpact(RayTraceResult result) {
        spell.projectileEffect(this, (EntityPlayer) this.getThrower(), this.getEntityWorld());

        if (!this.world.isRemote) {
            this.world.setEntityState(this, (byte)3);
            this.setDead();
        }
    }



    @Override
    public void onUpdate() {
        super.onUpdate();
        if (this.ticksExisted > 400)
            setDead();
    }

    public Element getElement() {
        return spell.getElement();
    }

    @Override
    protected float getGravityVelocity() {
        return gravity;
    }
    
    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound nbt) {
        super.writeToNBT(nbt);
        nbt.setByte("Spell", (byte) Spells.getPlaceInList(spell));
        return nbt;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        super.readFromNBT(nbt);
        spell = (SpellProjectile) Spells.getFromList(nbt.getByte("Spell"));
    }

    @Override
    public void writeSpawnData(ByteBuf buffer) {
        buffer.writeInt(Spells.getPlaceInList(spell));
    }
    @Override
    public void readSpawnData(ByteBuf additionalData) {
        spell = (SpellProjectile) Spells.getFromList(additionalData.readInt());
    }
}

 

What am I missing?

Edited April 1, 20187 yr by CactusCoffee
Problem Solved

It actually ended up being something even dumber that I overlooked. In the code I copied from 1.7.10 for spawning the projectile, I had an if (!world.isRemote) check before spawning the entity. So of course the entity didn't appear client-side. Getting rid of that check fixed the issue. Not sure why it worked in 1.7.10, but whatever.

 

Thank you.

Ah. I did have a feeling it wasn't quite right - i noticed after i marked this solved that the explosion caused by the projectile on impact was slightly off from where it appeared to hit. Thanks for calling that out. The World constructor in the entity class didn't do it, though.

 

Here are the constructors I added:

 

public EntityMagicOrb(World world) {
        super(world);
    }

    public EntityMagicOrb(World world, SpellProjectile spell) {
        super(world);
        this.spell = spell;
    }

 

Edited April 1, 20187 yr by CactusCoffee

It looks like my entity registration method isn't being called at all. The entity registration itself may be wrong too. Here's the registration method:

 

@SubscribeEvent
    public void registerEntities(RegistryEvent.Register<EntityEntry> event) {
        System.out.println("Registering Mod Entities");
        EntityEntry entry = EntityEntryBuilder.create()
                .entity(EntityMagicOrb.class)
                .id(new ResourceLocation(MagicMod.MODID, "magic_orb"), 0)
                .name("magic_orb")
                .tracker(64, 20, true)
                .build();
        event.getRegistry().register(entry);
    }

 

 

Found the problem.

 

It wasn't getting called because registerEntities wasn't static, since I'm using @Mod.EventBusSubscriber.

 

I knew this would be something stupid, but I didn't think it would be something that stupid.

 

Thank you.