Jump to content

Recommended Posts

Posted (edited)

Hi,

 

I'm working on updating my old mod from 1.7.10 to 1.12.2. I'm having trouble updating one of my entities (a projectile similar to a snowball). The entity itself works fine, but I haven't been able to get it to render; it's invisible. I've looked around tutorials and this forum for a while but haven't found anything that worked.

 

Here's my entity renderer class:

 

public class RenderMagicOrb extends Render<EntityMagicOrb> {

    private static ResourceLocation TEXTURE_RED = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_red.png");
    private static ResourceLocation TEXTURE_YELLOW = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_yellow.png");
    private static ResourceLocation TEXTURE_GREEN = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_green.png");
    private static ResourceLocation TEXTURE_BLUE = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_blue.png");
    private static ResourceLocation TEXTURE_BLACK = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_black.png");
    private static ResourceLocation TEXTURE_WHITE = new ResourceLocation(MagicMod.MODID,
            "textures/entity/magic_orb_white.png");

    public RenderMagicOrb(RenderManager renderManagerIn) {
        super(renderManagerIn);
    }

    public void doRender(@Nonnull EntityMagicOrb entity, double x, double y, double z,
                         float entityYaw, float partialTicks) {
        GlStateManager.pushMatrix();
        bindEntityTexture(entity);
        GlStateManager.translate((float)x, (float)y, (float)z);
        GlStateManager.enableRescaleNormal();
        GlStateManager.scale(2.0F, 2.0F, 2.0F);
        Tessellator tessellator = Tessellator.getInstance();
        BufferBuilder bufferbuilder = tessellator.getBuffer();

        GlStateManager.rotate(180.0F - this.renderManager.playerViewY, 0.0F, 1.0F, 0.0F);
        GlStateManager.rotate((float)(this.renderManager.options.thirdPersonView == 2 ? -1 : 1) * -this.renderManager.playerViewX, 1.0F, 0.0F, 0.0F);

        if (renderOutlines) {
            GlStateManager.enableColorMaterial();
            GlStateManager.enableOutlineMode(this.getTeamColor(entity));
        }

        bufferbuilder.begin(7, DefaultVertexFormats.POSITION_TEX_NORMAL);
        bufferbuilder.pos(-0.5D, -0.25D, 0.0D).tex(0.0D, 1.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        bufferbuilder.pos(0.5D, -0.25D, 0.0D).tex(1.0D, 1.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        bufferbuilder.pos(0.5D, 0.75D, 0.0D).tex(1.0D, 0.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        bufferbuilder.pos(-0.5D, 0.75D, 0.0D).tex(0.0D, 0.0D).normal(0.0F, 1.0F, 0.0F).endVertex();
        tessellator.draw();

        if (renderOutlines) {
            GlStateManager.disableOutlineMode();
            GlStateManager.disableColorMaterial();
        }

        GlStateManager.disableRescaleNormal();
        GlStateManager.popMatrix();
        super.doRender(entity, x, y, z, entityYaw, partialTicks);
    }

    @Override
    protected ResourceLocation getEntityTexture(@Nonnull EntityMagicOrb entity) {
        switch (entity.getElement()) {
            case RED:
                return TEXTURE_RED;
            case YELLOW:
                return TEXTURE_YELLOW;
            case GREEN:
                return TEXTURE_GREEN;
            case BLUE:
                return TEXTURE_BLUE;
            case BLACK:
                return TEXTURE_BLACK;
            case WHITE:
                return TEXTURE_WHITE;
        }
        //Default, should never happen
        return TEXTURE_RED;
    }
}

 

And here's my ClientProxy:

 

@Mod.EventBusSubscriber(Side.CLIENT)
public class ClientProxy extends CommonProxy {
    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);
        RenderingRegistry.registerEntityRenderingHandler(EntityMagicOrb.class, new IRenderFactory<EntityMagicOrb>() {
            @Override
            public Render<? super EntityMagicOrb> createRenderFor(RenderManager manager) {
                return new RenderMagicOrb(manager);
            }
        });
    }

    @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event) {

    }

    @Override
    public void registerItemRenderer(Item item, int meta, String id) {
        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(MagicMod.MODID + ":" + id, "inventory"));
    }
}

 

Here's the entity class itself, though I don't think it's the problem

 

public class EntityMagicOrb extends EntityThrowable implements IEntityAdditionalSpawnData {

    private SpellProjectile spell;
    private float gravity = 0.03F;

    public EntityMagicOrb(World world, EntityPlayer player, SpellProjectile spell) {
        super(world, player);
        this.shoot(player, player.rotationPitch, player.rotationYaw,
                0.0F, 1.5F, 1.0F);

        this.spell = spell;
    }

    @Override
    protected void onImpact(RayTraceResult result) {
        spell.projectileEffect(this, (EntityPlayer) this.getThrower(), this.getEntityWorld());

        if (!this.world.isRemote) {
            this.world.setEntityState(this, (byte)3);
            this.setDead();
        }
    }



    @Override
    public void onUpdate() {
        super.onUpdate();
        if (this.ticksExisted > 400)
            setDead();
    }

    public Element getElement() {
        return spell.getElement();
    }

    @Override
    protected float getGravityVelocity() {
        return gravity;
    }
    
    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound nbt) {
        super.writeToNBT(nbt);
        nbt.setByte("Spell", (byte) Spells.getPlaceInList(spell));
        return nbt;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        super.readFromNBT(nbt);
        spell = (SpellProjectile) Spells.getFromList(nbt.getByte("Spell"));
    }

    @Override
    public void writeSpawnData(ByteBuf buffer) {
        buffer.writeInt(Spells.getPlaceInList(spell));
    }
    @Override
    public void readSpawnData(ByteBuf additionalData) {
        spell = (SpellProjectile) Spells.getFromList(additionalData.readInt());
    }
}

 

What am I missing?

Edited by CactusCoffee
Problem Solved
Posted

It actually ended up being something even dumber that I overlooked. In the code I copied from 1.7.10 for spawning the projectile, I had an if (!world.isRemote) check before spawning the entity. So of course the entity didn't appear client-side. Getting rid of that check fixed the issue. Not sure why it worked in 1.7.10, but whatever.

 

Thank you.

Posted (edited)

Ah. I did have a feeling it wasn't quite right - i noticed after i marked this solved that the explosion caused by the projectile on impact was slightly off from where it appeared to hit. Thanks for calling that out. The World constructor in the entity class didn't do it, though.

 

Here are the constructors I added:

 

public EntityMagicOrb(World world) {
        super(world);
    }

    public EntityMagicOrb(World world, SpellProjectile spell) {
        super(world);
        this.spell = spell;
    }

 

Edited by CactusCoffee
Posted

It looks like my entity registration method isn't being called at all. The entity registration itself may be wrong too. Here's the registration method:

 

@SubscribeEvent
    public void registerEntities(RegistryEvent.Register<EntityEntry> event) {
        System.out.println("Registering Mod Entities");
        EntityEntry entry = EntityEntryBuilder.create()
                .entity(EntityMagicOrb.class)
                .id(new ResourceLocation(MagicMod.MODID, "magic_orb"), 0)
                .name("magic_orb")
                .tracker(64, 20, true)
                .build();
        event.getRegistry().register(entry);
    }

 

 

Posted

Found the problem.

 

It wasn't getting called because registerEntities wasn't static, since I'm using @Mod.EventBusSubscriber.

 

I knew this would be something stupid, but I didn't think it would be something that stupid.

 

Thank you.

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Add the crash-report or latest.log (logs-folder) with sites like https://mclo.gs/ and paste the link to it here  
    • I removed yetanotherchance booster and now it says Invalid player identity
    • Cracked Launchers are not supported
    • After some time minecraft crashes with an error. Here is the log https://drive.google.com/file/d/1o-2R6KZaC8sxjtLaw5qj0A-GkG_SuoB5/view?usp=sharing
    • The specific issue is that items in my inventory wont stack properly. For instance, if I punch a tree down to collect wood, the first block I collected goes to my hand. So when I punch the second block of wood to collect it, it drops, but instead of stacking with the piece of wood already in my hand, it goes to the second slot in my hotbar instead. Another example is that I'll get some dirt, and then when I'm placing it down later I'll accidentally place a block where I don't want it. When I harvest it again, it doesn't go back to the stack that it came from on my hotbar, where it should have gone, but rather into my inventory. That means that if my inventory is full, then the dirt wont be picked up even though there should be space available in the stack I'm holding. The forge version I'm using is 40.3.0, for java 1.18.2. I'll leave the mods I'm using here, and I'd appreciate it if anybody can point me in the right direction in regards to figuring out how to fix this. I forgot to mention that I think it only happens on my server but I&#39;m not entirely sure. PLEASE HELP ME! LIST OF THE MODS. aaa_particles Adorn AdvancementPlaques AI-Improvements AkashicTome alexsdelight alexsmobs AmbientSounds amwplushies Animalistic another_furniture AppleSkin Aquaculture aquamirae architectury artifacts Atlas-Lib AutoLeveling AutoRegLib auudio balm betterfpsdist biggerstacks biomancy BiomesOPlenty blockui blueprint Bookshelf born_in_chaos Botania braincell BrassAmberBattleTowers brutalbosses camera CasinoCraft cfm (MrCrayfish’s Furniture Mod) chat_heads citadel cloth-config Clumps CMDCam CNB cobweb collective comforts convenientcurioscontainer cookingforblockheads coroutil CosmeticArmorReworked CozyHome CrabbersDelight crashexploitfixer crashutilities Create CreativeCore creeperoverhaul cristellib crittersandcompanions Croptopia CroptopiaAdditions CullLessLeaves curios curiouslanterns curiouslights Curses' Naturals CustomNPCs CyclopsCore dannys_expansion decocraft Decoration Mod DecorationDelightRefurbished Decorative Blocks Disenchanting DistantHorizons doubledoors DramaticDoors drippyloadingscreen durabilitytooltip dynamic-fps dynamiclights DynamicTrees DynamicTreesBOP DynamicTreesPlus Easy Dungeons EasyAnvils EasyMagic easy_npc eatinganimation ecologics effective_fg elevatorid embeddium emotecraft enchantlimiter EnchantmentDescriptions EnderMail engineersdecor entityculling entity_model_features entity_texture_features epicfight EvilCraft exlinefurniture expandability explosiveenhancement factory-blocks fairylights fancymenu FancyVideo FarmersDelight fast-ip-ping FastSuite ferritecore finsandtails FixMySpawnR Forge Middle Ages fossil FpsReducer2 furnish GamingDeco geckolib goblintraders goldenfood goodall H.e.b habitat harvest-with-ease hexerei hole_filler huge-structure-blocks HunterIllager iammusicplayer Iceberg illuminations immersive_paintings incubation infinitybuttons inventoryhud InventoryProfilesNext invocore ItemBorders itemzoom Jade jei (Just Enough Items) JetAndEliasArmors journeymap JRFTL justzoom kiwiboi Kobolds konkrete kotlinforforge lazydfu LegendaryTooltips libIPN lightspeed lmft lodestone LongNbtKiller LuckPerms Lucky77 MagmaMonsters malum ManyIdeasCore ManyIdeasDoors marbledsarsenal marg mcw-furniture mcw-lights mcw-paths mcw-stairs mcw-trapdoors mcw-windows meetyourfight melody memoryleakfix Mimic minecraft-comes-alive MineTraps minibosses MmmMmmMmmMmm MOAdecor (ART, BATH, COOKERY, GARDEN, HOLIDAYS, LIGHTS, SCIENCE) MobCatcher modonomicon mods_optimizer morehitboxes mowziesmobs MutantMonsters mysticalworld naturalist NaturesAura neapolitan NekosEnchantedBooks neoncraft2 nerb nifty NightConfigFixes nightlights nocube's_villagers_sell_animals NoSeeNoTick notenoughanimations obscure_api oculus oresabovediamonds otyacraftengine Paraglider Patchouli physics-mod Pillagers Gun PizzaCraft placeableitems Placebo player-animation-lib pneumaticcraft-repressurized polymorph PrettyPipes Prism projectbrazier Psychadelic-Chemistry PuzzlesLib realmrpg_imps_and_demons RecipesLibrary reeves-furniture RegionsUnexplored restrictedportals revive-me Scary_Mobs_And_Bosses selene shetiphiancore ShoulderSurfing smoothboot
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.