Block Ore Drops

[2To16Hobos]

I've been trying to figure out what's been going on with my textures and I haven't had much luck. When I break the ore block to drop a specific item I created all it returns is a blank texture item (water, ice, earth, nature, and metal). The only one this doesn't occure with is my fire ore, it gives the correct item and texture. The other ores give the correct item but wrong texture. When they are added to a stack of the item added in via creative they return to normal. Can someone please help?

 

BlockOres class

https://pastebin.com/2FvfX2mt

[Cadiboo]

Metadata is being removed in 1.13, If you are planing on continuing to support your mod into 1.13 and beyond I would highly recommend not using metadata.

 

My WIFI is dying on me and keeps posting comments twice. Read the comment below

Edited May 10, 2018 by Cadiboo

[Cadiboo]

  On 5/10/2018 at 11:57 AM, diesieben07 said:

You are not setting the metadata of your drops. I highly recommend just overriding getDrops instead of using the combination of singular methods.

Expand  

This is one way to do it - and probably the way you want to do it right now, but it will no longer work in future versions because metadata is being removed in 1.13. If you are planing on continuing to support your mod into 1.13 and beyond I would highly recommend not using metadata.

 

Many people use metadata to avoid creating multiple classes, forgetting that you can instantiate the same class multiple times to create many items. Here is a good topic on this subject:

 

Edited May 10, 2018 by Cadiboo

[Cadiboo]

  On 5/10/2018 at 12:05 PM, diesieben07 said:

BS. There are migration paths from "metadata" to "not metadata". Not using it now will not buy you much.

Expand  

Its my personal opinion, get it done now - while you are still making your mod - and have less work in the future

[Cadiboo]

  On 5/10/2018 at 1:36 PM, diesieben07 said:

Except you will still have to migrate in the future...

Expand  

... migrate what? your mod? yes you will, but you will have to do less work when migrating it.