ConcurrentModificationException

[thetdw2000]

I have made a functional mod which keeps crashing due to a "ConcurrentModificationException" whenever I repeatedly use the Sonar items. The source is at GitHub here: https://github.com/thetdw2000/sonarmod

I suspect that it's caused by the SonarThread class, but I have no idea how to fix it or what's causing it.

crash-2018-05-22_21.10.40-client.txtFetching info...

Edited May 23, 2018 by thetdw2000
Added crash report

[DaemonUmbra]

Can you post your crash report please?

[thetdw2000]

  On 5/23/2018 at 7:48 AM, diesieben07 said:

The sonar mod is completely broken. They are accessing the world from a separate thread. They need to fix their mod.

Expand  

That didn't seem to be the problem before; I could access the world from the separate thread before I added in the sounds. Is there some taboo about doing this? If so, what is the preferred method?

[thetdw2000]

  On 5/23/2018 at 11:59 AM, diesieben07 said:

Minecraft's code is not thread safe.

You cannot access the world from other threads. If you need to, you need to copy the world data somewhere else in the main thread and then hand over that copy to the other thread.

Expand  

I get that, but that still doesn't explain why it's crashing when it doesn't start a thread (when the player doesn't have coal). Why is that happening?

[thetdw2000]

  On 5/23/2018 at 12:08 PM, diesieben07 said:

You are playing sounds from the SonarThread as well. If you do things from multiple threads but you are interacting with non thread-safe code, any number of things can happen. In your case playing the sound from the SonarThread causes the crash when the main thread tries to play sound as well.

Expand  

So the EntityPlayer class is also not thread safe? Because I never played sounds from the World class.