Hitboxes and size?

[Krevik]

Hi! I've got problem with mob hitboxes. Mob is really big. I set it size using setSize(48F,12F) so as you can see it's huge. Hitboxes shown ingame are ok, but there's problem with hitting it. The mob can be hit only by hitting it in the real center. Hitting borders even if they're in the hitbox range doesn't effect. Is there any way to fix it? https://imgur.com/pITIVs7

Edited June 19, 2018 by Krevik

[jabelar]

I think it should work. I've done giants and dinosaurs before. The vanilla giant zombie is 6 times regular zombie size and the main part of a vanilla dragon is 16 by 8.

 

There might be a limit though. Maybe start small and increase it a bit at a time to see if there is an actual limit. 

 

I looked through the code a bit. The key bit of code is the EntityRenderer.getMouseOver() method. This is what decides if the player is clicking on an entity. One thing I noticed is that one thing it does it it narrows down the entities to check for using the World.getEntitiesWithinAABBExcludingEntity() method. I looked at that method and it actually has a comment that there is a MAX_ENTITY_RADIUS field that:

     * Used in the getEntitiesWithinAABB functions to expand the search area for entities.
     * Modders should change this variable to a higher value if it is less then the radius
     * of one of there entities.

 

This field is a public static field so is accessible for you. So I think what you need to do is at some time during loading you need to set that field to the size of your entity. 

 

The default is 2. So it makes sense that you might need to change this in your case.

 

Anyway, try that and see if it works.

[Krevik]

  On 6/20/2018 at 4:41 AM, jabelar said:

I think it should work. I've done giants and dinosaurs before. The vanilla giant zombie is 6 times regular zombie size and the main part of a vanilla dragon is 16 by 8.

 

There might be a limit though. Maybe start small and increase it a bit at a time to see if there is an actual limit. 

 

I looked through the code a bit. The key bit of code is the EntityRenderer.getMouseOver() method. This is what decides if the player is clicking on an entity. One thing I noticed is that one thing it does it it narrows down the entities to check for using the World.getEntitiesWithinAABBExcludingEntity() method. I looked at that method and it actually has a comment that there is a MAX_ENTITY_RADIUS field that:

     * Used in the getEntitiesWithinAABB functions to expand the search area for entities.
     * Modders should change this variable to a higher value if it is less then the radius
     * of one of there entities.

 

This field is a public static field so is accessible for you. So I think what you need to do is at some time during loading you need to set that field to the size of your entity. 

 

The default is 2. So it makes sense that you might need to change this in your case.

 

Anyway, try that and see if it works.

Expand  

Thank you so much jabelar! I think it should work, anyway will try it soon

[Krevik]

  On 6/20/2018 at 4:41 AM, jabelar said:

I think it should work. I've done giants and dinosaurs before. The vanilla giant zombie is 6 times regular zombie size and the main part of a vanilla dragon is 16 by 8.

 

There might be a limit though. Maybe start small and increase it a bit at a time to see if there is an actual limit. 

 

I looked through the code a bit. The key bit of code is the EntityRenderer.getMouseOver() method. This is what decides if the player is clicking on an entity. One thing I noticed is that one thing it does it it narrows down the entities to check for using the World.getEntitiesWithinAABBExcludingEntity() method. I looked at that method and it actually has a comment that there is a MAX_ENTITY_RADIUS field that:

     * Used in the getEntitiesWithinAABB functions to expand the search area for entities.
     * Modders should change this variable to a higher value if it is less then the radius
     * of one of there entities.

 

This field is a public static field so is accessible for you. So I think what you need to do is at some time during loading you need to set that field to the size of your entity. 

 

The default is 2. So it makes sense that you might need to change this in your case.

 

Anyway, try that and see if it works.

Expand  

Tried and it didn't work. Tried puttin World.MAX_ENTITY_RADIUS in entity class, in main class pre init, post init, init methods. Tried setting it to both 12D and 120D. Also tried not using World, but DimensionManager.getWorld(). None of these worked  Nothing changed.  Also found out that the problem is only with hitting it with hand/item etc... There is no such problem with arrow. Arrow recognize hitboxes perfectly

Edited June 21, 2018 by Krevik

[Krevik]

  Reveal hidden contents

    @Mod.EventHandler
    public void preInit(FMLPreInitializationEvent event) {
    	World.MAX_ENTITY_RADIUS=12D;
    	OBJLoader.INSTANCE.addDomain(MODID);
    	KetherPacketHandler.init();
    	KCore.instance.dimRegistry();
        //logger = (Logger)event.getModLog();
        proxy.preInit(event);
    }

 

  On 6/21/2018 at 8:20 AM, diesieben07 said:

Show how you tried to change the field. Note: Do not make your own field.

Expand  

 

 

[jabelar]

  On 6/21/2018 at 7:39 AM, Krevik said:

Tried and it didn't work. Tried puttin World.MAX_ENTITY_RADIUS in entity class, in main class pre init, post init, init methods. Tried setting it to both 12D and 120D. Also tried not using World, but DimensionManager.getWorld(). None of these worked  Nothing changed.  Also found out that the problem is only with hitting it with hand/item etc... There is no such problem with arrow. Arrow recognize hitboxes perfectly

Expand  

 

The fact that arrows work but player hitting doesn't supports my idea that the problem is somewhere in the mouse over method. Once the arrows are flying they use their own collision box to check for collisions. When the player tries to hit something it checks the space around the "look vector" which involves methods like the one I've mentioned.

 

So I still feel the problem can be understood by looking at the EntityRenderer.getMouseOver() method. I'm not certain that radius field is the problem, but it sure sounded like it should be related. Maybe you should use debug mode in Eclipse and set a breakpoint for when user clicks button and step through to see what is happening.