Jump to content

Looking For Entity.getUnlocalizedName()


jredfox

Recommended Posts

Where can I get an unlocalized name of the entity I tried a little something here and works if it's one entity per class but, it breaks(grabs wrong unlocalized name) with the chicken mod found here:
https://minecraft.curseforge.com/projects/chickens

Code:

	public String getEntityUnlocalizedName(NBTTagCompound data, World w) 
	{
		ResourceLocation loc = new ResourceLocation(data.getString("id"));
		Entity e;
		String s = "entity." + EntityList.getEntityString(EntityList.createEntityFromNBT(data, w)) + ".name";
		return s;
	}


The itemstack which I send in has all the right data it needs for a water chicken yet it gives the deafult chickens:chicken unlocalized name.

So the getUnlocalized() name should be fetched on the server side so the client can translate it later. The name is stored inside of an itemstack.

Edited by jredfox
Link to comment
Share on other sites

8 hours ago, diesieben07 said:
  • Translating on the server is not possible in a reliable way.
  • Use EntityList.createEntityFromNBT to create entities from NBT. No, your stupid hacks are not needed. This is the only method you need.
  • Use Entity#getDisplayName to get the name for an entity. This is the only method you need.

Server fetches unlocalized name then client translates it later sorry I wasn't clear upon that. How do you get the entity unloclalized name if there is a way?

Yeah I know no hacks are needed would it make you happy if I used EntityList? Changed post up for you

Edited by jredfox
Link to comment
Share on other sites

5 minutes ago, diesieben07 said:

Unfortunately no real way to do so. Only proper way is to call getDisplayName on the client.

I guess I could make a system to define sub types unlocalized name based on nbt. As creating an entity on the client every tick for just a display name is not optional. Thanks anyways. I am going to have to look at nbt as paths rather then the current setup. Re-create my NBTPathAPI and maybe learn recursion

Edited by jredfox
Link to comment
Share on other sites

2 minutes ago, diesieben07 said:

Don't create it every tick then.

And no, you could not make such a system. It would be broken.

create it once then send a packet to the server saying this is it's new name? If I do that then it would update it for everybody else looking into a chest? What am I only suppose to change the itemstack's nbt on client side? I am confused on the process on what to do here

Edited by jredfox
Link to comment
Share on other sites

4 minutes ago, diesieben07 said:

Client knows the ItemStack. Keep a client-side map (weak keys and weak values) of ItemStack to Entity.

I will try it your way first but, in the future might decide the other way as I am not storing entities on the client side for translations

Link to comment
Share on other sites

1 minute ago, diesieben07 said:

Note that you don't have to permanently store them. This map is only a cache so you do not have to do the NBT -> Entity translation all the time.

yeah I don't know when I should clear the cache since they don't have to be stored in your inventory to view. Just every so often and keep it as a weak hashmap?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So I saw that mixin is shipped as a library with forge, but is it available for 1.7.10 ?  
    • So I've read the EULA, and lets be straight...     If I split my modpack(of my mods, yeah I'm nuts) into several(many) individual mods(like just one boss) with minor additions(plus not working together), then have a complete/modpack version on patreon/onlyfans having each addon work together... Would people buy my idea?
    • German A1 – C1, TestDAF, Goethe B1, B2, C1, C2, valid GOETHE certificate German A1 – C1, TestDAF, Goethe B1, B2, C1, C2, valid GOETHE certificate(+27(838-80-8170
    • Done, it still crashed. New log https://paste.ee/p/kYv6e
    • I am migrating a mod from 1.16.5 to 1.20.2 The version for 1.16.5 can be found here https://github.com/beothorn/automataCraft For the block called automata_start, it uses TileEntities and has blockstates, model/block and textures on json files. This is currently working fine on 1.16.5 https://github.com/beothorn/automataCraft/tree/master/src/main/resources/assets/automata For 1.20.2 I migrated the logic from TileEntities to BlockEntity. The mod is working fine. All blocks and Items are working with the correct textures except for the textures for each state of the automata_start block. No changes where made to the json files. This is the branch I am working on (there were some refactorings, but all is basically the same): https://github.com/beothorn/automataCraft/tree/1_20/src/main/resources/assets/automata The only difference I can think that may be related is that i had to implement createBlockStateDefinition on the BaseEntityBlock: https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/AutomataStartBlock.java#L43 This is driving me crazy. I know the jsons are being loaded as I put a breakpoint at `net.minecraft.client.resources.model.ModelBakery#loadModel` and I can see BlockModelDefinition.fromJsonElement being called with automata_start. I also printed the state from the arguments of the tick function call and they look correct (https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/Ticker.java#L32 ): blockState Block{automata:automata_start}[state=loadreplaceables] In game, all I see is the no textures. I think it is weird it is not the "missing texture" texture so I think it may be related to the material, but I had no success tweaking it (https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/AutomataStartBlock.java#L37).   public static final Property<AutomataStartState> state = EnumProperty.create("state", AutomataStartState.class); private final AtomicReference<RegistryObject<BlockEntityType<?>>> blockEntityType; private final Map<String, RegistryObject<Block>> registeredBlocks; public AutomataStartBlock( final AtomicReference<RegistryObject<BlockEntityType<?>>> blockEntityType, final Map<String, RegistryObject<Block>> registeredBlocks ) { super(BlockBehaviour.Properties.of().mapColor(MapColor.STONE).strength(1.5F, 6.0F)); this.blockEntityType = blockEntityType; this.registeredBlocks = registeredBlocks; this.registerDefaultState(this.getStateDefinition().any().setValue(state, AutomataStartState.LOAD_REPLACEABLES)); } @Override protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockState> stateBuilder) { stateBuilder.add(state); }     So my cry for help is, anyone has any ideas? Is there a way to easily debug this, for example somewhere where I can list the textures for a given state, or make sure this is loaded?   Thanks in advance for the hints
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.