java.lang.ArrayIndexOutOfBoundsException: 5, (custom ToolMaterial) [SOLVED]

[Enderlook]

I'm trying to make a tool but I don't have any idea why this is causing a bug. Could you help me?

 

PMDescription: Initializing game java.lang.ExceptionInInitializerError
	at net.enderlook.extracraft.proxy.CommonProxy.registerItems(CommonProxy.java:49)
	[...]
Caused by: java.lang.ArrayIndexOutOfBoundsException: 5
	at net.minecraft.item.ItemAxe.<init>(ItemAxe.java:19)
	at net.enderlook.extracraft.items.base.CItemToolAxe.<init>(CItemToolAxe.java:13)
	at net.enderlook.extracraft.items.items.tools.ItemFlintAxe.<init>(ItemFlintAxe.java:18)
	at net.enderlook.extracraft.items.init.CItems.<clinit>(CItems.java:67)
 	[...]

 

The CommonProxy.java:49 line is:

CItems.registerItems(event);

Which calls:

public static void registerItems(final RegistryEvent.Register<Item> event) { // CItems class
		final IForgeRegistry<Item> registry = event.getRegistry();
  		//...
		registry.registerAll(ITEMS_TOOL_AXE);
  		//...
	}

And ITEMS_TOOL_AXE is this array:

	public static final CItemToolAxe[] ITEMS_TOOL_AXE = new CItemToolAxe[] { // CItems class
		ITEM_FLINT_AXE
	};

Where ITEM_FLINT_AXE is this item:

	@ObjectHolder(ExtraCraft.MOD_ID + ":flint_axe") // CItems class
	public static final ItemFlintAxe ITEM_FLINT_AXE = new ItemFlintAxe("flint_axe");

And ItemFlintAxe's class extends from my base class:

public class CItemToolAxe extends ItemAxe implements IInitModel {
	public CItemToolAxe(String unlocalizedName, CreativeTabs tab, ToolMaterial material) {
		//...
	}
	
	@Override
	@SideOnly(Side.CLIENT)
	public void initializeModel() { // This comes from IInitModel
		ModelLoader.setCustomModelResourceLocation(this, 0, new ModelResourceLocation(getRegistryName(), "inventory"));
	}
}

Also, maybe another relevant line is:

	@SideOnly(Side.CLIENT)
	public static void initializeItemsModels() { // CItems class
		//...
		for (IInitModel item : ITEMS_TOOL_AXE) {
			item.initializeModel();
		};
		//...
	}

Which is called in the ClientProxy class registerModels method.

 

I've read that java.lang.ArrayIndexOutOfBoundsException: 5 is usually caused when you do something like this:

int[] array = new int[5];
int boom = array[5]; // Because it count for 0, so the fifth item is the 4 number

Or in a loop like:

for (int i = 0; i<=name.length; i++) {} // i should start in i = 1

But I didn't do any of both things, right?

Edited July 31, 2018 by Enderlook

[Choonster]

This particular ArrayIndexOutOfBoundsException is caused by calling the ItemAxe(ToolMaterial) constructor with a non-Vanilla ToolMaterial as it tries to look up the attack speed and damage using the ToolMaterial's ordinal as an array index. These arrays only have as many entries as their are Vanilla ToolMaterials, so any modded ToolMaterial's ordinal causes an ArrayIndexOutOfBoundsException.

 

The solution is to use the ItemAxe(ToolMaterial, float, float) constructor and specify the attack damage and speed yourself.

[Enderlook]

My constructor is: 

	public CItemToolAxe(String unlocalizedName, CreativeTabs tab, ToolMaterial material) {
		super(material);
		this.setRegistryName(unlocalizedName);
		this.setUnlocalizedName(unlocalizedName);
		this.setCreativeTab(tab);		
	}

And my material is:

public static final ToolMaterial FLINT_MATERIAL = EnumHelper.addToolMaterial("Flint", 1, 95, 3f, 0.5f, 7);

 

 

Your idea is fixing that like:

super(material, 3f, 0.5f);

Which works.

 

But could I also use this?:

super(material, material.getEfficiency(), material.getAttackDamage());

It seems to works also.

Edited July 31, 2018 by Enderlook

[Choonster]

  On 7/31/2018 at 10:35 PM, Enderlook said:

My constructor is: 

	public CItemToolAxe(String unlocalizedName, CreativeTabs tab, ToolMaterial material) {
		super(material);
		this.setRegistryName(unlocalizedName);
		this.setUnlocalizedName(unlocalizedName);
		this.setCreativeTab(tab);		
	}

And my material is:

public static final ToolMaterial FLINT_MATERIAL = EnumHelper.addToolMaterial("Flint", 1, 95, 3f, 0.5f, 7);

 

 

Your idea is fixing that like:

super(material, 3f, 0.5f);

Which works.

 

But could I also use this?:

super(material, material.getEfficiency(), material.getAttackDamage());

It seems to works also.

Expand  

 

Both of those are valid. The important thing is that you call that constructor, it doesn't matter where you get the values from. 

[Enderlook]

Ok, thank you.

This topic has accomplished its purpose... is there a way to close it or in this forum topics aren't closed?

[DaemonUmbra]

Typically you can rename the topic and add [Solved] to the beginning.

[Enderlook]

Ok, thanks.