Posted September 14, 20187 yr Recently my pull request was closed due to how the patch formatting was. I tried to follow the format very carefully, but I guess I wasn't careful enough. So I was looking for some tips that may not be in the wiki about contributing. Specifically placement and format of new methods and variables and what an ideal patch file looks like.
October 1, 20187 yr Observe other PRs carefully. Read the comments and see what gets accepted and what doesn’t and why. Write more code until you understand.
October 2, 20187 yr There’s a Forge Formatter Profile (for both Eclipse and IntelliJ) available at Forge Essentials (link below). Read the README for the Forge Essentials repository, the Forge GitHub README and the Forge docs>working on Forge page to get a good overview of how you should structure your PRs. Someone else said (paraphrasing) that there’s going to be a lot of criticism on your PRs, and it’s up to you to take it in your stride and use it constructively. https://github.com/ForgeEssentials/ForgeEssentials About Me Spoiler My Discord - Cadiboo#8887 My Website - Cadiboo.github.io My Mods - Cadiboo.github.io/projects My Tutorials - Cadiboo.github.io/tutorials Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support. When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible. Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.