Jump to content

[1.12.2] Anyone have a leaner/smarter way to reuse extend CategoryEntry?


EM3R50N

Recommended Posts

I am trying to flesh out different categories of my mod config but my code is more duplicated/non-dry than I'd prefer. I'd like to just have to define one public static class Whatever extends CategoryEntry vs having to do it for EVERY category of my mod config screens. Anyone out there know how to compress these two blocks into one, reusable, more absract/dry approach?

 

		public static class CategoryEntryToggles extends CategoryEntry{			
			public CategoryEntryToggles(GuiConfig owningScreen, GuiConfigEntries owningEntryList,IConfigElement configElement) {
				super(owningScreen, owningEntryList, configElement);
			}
			
			@Override
			protected GuiScreen buildChildScreen(){				
				Configuration config = Config.getConfig();
				ConfigElement myCat = new ConfigElement(config.getCategory(Config.CATEGORY_TOGGLES));
				List<IConfigElement> propertiesOnScreen = myCat.getChildElements();
				String windowTitle = "Mod Config: Toggles"; 
				return new GuiConfig(owningScreen, propertiesOnScreen, owningScreen.modID,this.configElement.requiresWorldRestart() || this.owningScreen.allRequireWorldRestart,this.configElement.requiresMcRestart() || this.owningScreen.allRequireMcRestart,windowTitle);								
			}			
		}
		
		// THIS IS BASICALLY COPY OF ABOVE WITH JUST DIFF myCat value =/
		public static class CategoryEntryValues extends CategoryEntry{			
			public CategoryEntryValues(GuiConfig owningScreen, GuiConfigEntries owningEntryList,IConfigElement configElement) {
				super(owningScreen, owningEntryList, configElement);
			}
			
			@Override
			protected GuiScreen buildChildScreen(){				
				Configuration config = Config.getConfig();
				ConfigElement myCat = new ConfigElement(config.getCategory(Config.CATEGORY_VALUES));
				List<IConfigElement> propertiesOnScreen = myCat.getChildElements();
				String windowTitle = "Mod Config: Values"; 
				return new GuiConfig(owningScreen, propertiesOnScreen, owningScreen.modID,this.configElement.requiresWorldRestart() || this.owningScreen.allRequireWorldRestart,this.configElement.requiresMcRestart() || this.owningScreen.allRequireMcRestart,windowTitle);								
			}			
		}		
		

 

Link to comment
Share on other sites

Make a util method in another class and pass in your arguments. Also unless your actually talking about a cat, you might want to make the name of the variable myCat less ambiguous

  • Like 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.