Intercepting Fluid Rendering?

[IdrisQe]

I'm not sure if this is even possible without a coremod, but I'm looking to intercept the rendering of fluid sides, in order to stop ones from rendering that are against blocks with specific properties.

Vanilla has a system of doing this, which it uses to stop water faces from rendering next to full blocks. I can't seem to find any forge hooks or classes related to fluid rendering, however.

Basically, I'm attempting to make fluids not render their sides when next to non-solid blocks that have bounding boxes/collision boxes (essentially if it isn't air or some air substitute)

Pretty much I want to stop the horrifically ugly air pocket rendering around non-solid block faces similar to 1.13 (though not actually putting water inside a block and all the physics changes and stuff)

 

I know doing this would break water if it was next to a fence or something... And it would ideally be better to find a way to implement it like how Vanilla did with Glass in one update... Though I imagine that wouldn't be feasible since it was probably a direct change to the water rendering logic.

 

It's probably impossible in modern versions, and the only implementation I found, AquaTweaks, is an outdated coremod stated to not be possible on current versions, which only worked with specifically implemented blocks. I just really don't want to have to wait for Forge and every mod I'm using to update to 1.13 in order to just not have horrible-looking non-full blocks underwater.

[Cadiboo]

I made a hook for this (closed it because of performance issues and some other reasons) https://github.com/MinecraftForge/MinecraftForge/pull/5166. I'm currently making a core mod to add these hooks (https://github.com/Cadiboo/NoCubes-Hooks) and I'm planning on working with grondag to make these hooks part of forge (read the comments on the PR).

 

I actually did something similar here where I render fluids inside invisible blocks and do some face culling based on the surrounding blocks.

 

Please note that what I've done in that PR and in that repository is absolutely horrendous for performance (I think, it could just be my old computer)

Edited October 16, 2018 by Cadiboo

[IdrisQe]

Oh wow, that's really cool. It's a shame it had to be closed, but hopefully the new work between you and Grondag can lead to a version of this in Forge, or at least in some form that's easily accessible by modders. I saw Grondag's mod when it was released, but I didn't really see the connection since those were custom blocks and didn't think that what was done there could be done dynamically to blocks on worldgen.

 

If BetterFoliage could make smooth leaves with that, and NoCubes got working on 1.12, both without coremods, that would be fantastic. The possibility of having Optifine-like features such as the better grass, better snow, connected glass, etc. but customizable would be a godsend to modders. I can think of so many possibilities for that.

 

Those very buggy screenshots shown in the PR makes me think that stuff like that could also be used to render directional block shadows, godrays, and stuff like that without shaders, even, if implemented. That would be brilliant.

 

I hope the performance issues can get solved and that some variant of the PR gets accepted, because clientside rendering tech is becoming a bigger and bigger part of many mods, and it seems to be an area somewhat lacking in Forge.

[Cadiboo]

Finished both the coremod and NoCubes (for the moment)

https://github.com/Cadiboo/RenderChunk-rebuildChunk-Hooks

https://github.com/Cadiboo/NoCubes