[1.12.2] Properly registering dimension biomes

[Dizzlepop12]

So I'm having trouble with registering the biomes for my dimensions. Each dimension only has one biome, but each of them generates in the overworld instead of only generating in their respective dimensions, which they correctly generate in. I used this method to register my biomes, but after some research I found it to be the incorrect way to register dimension biomes, but it's the proper way to register overworld biomes.

 

I guess the proper way is to subscribe an IForgeRegistry event that registers the individual biomes like this: 

    @SubscribeEvent
    public static void registerBiomes(IForgeRegistry<Biome> iForgeRegistry) {
        IForgeRegistry<Biome> registry = iForgeRegistry;
        registry.registerAll(BIOME_1, BIOME_2...)
    }

However, when I use this instead, the biomes don't get registered at all. Any help?

[Cadiboo]

I believe you should be creating your biomes in the event too.

[V0idWa1k3r]

11 hours ago, Dizzlepop12 said:

the biomes don't get registered at all.

Yes they do get registered. That is the whole purpose of the registry event. They just don't generate. There is a difference. A registered object doesn't necessairly need to appear in the game at all.

Also as @Cadiboo said instantinate your biomes in the event too.

 

BiomeManager.addBiome(biomeType, new BiomeEntry(biome, 10));
BiomeManager.addSpawnBiome(biome);

This is why your biomes were spawning in the first place. This adds the biome to the biome entry list that the biomes will get pulled from. The second line allows the player's spawn biome to be yours.

 

To have your biome spawn in your dimension you need to change the BiomeProvider in your WorldProvider and make that BiomeProvider have your biome as a possible biome to spawn. See WorldProviderEnd#init for an example of a single biome per dimension that only generates in that dimension or look at BiomeProvider itself to see how it keeps an array of biomes that can be generated.