Jump to content

Vanilla Advancement Recipe Broken?


nov4e

Recommended Posts

So i have removed the recipes of some items for example diamond sword. When I join in a world the log says:

[20:01:26] [Server thread/ERROR] [minecraft/AdvancementManager]: Parsing error loading built-in advancement minecraft:recipes/combat/diamond_sword
com.google.gson.JsonSyntaxException: Unknown recipe 'minecraft:diamond_sword'
	at net.minecraft.advancements.AdvancementRewards$Deserializer.deserialize(AdvancementRewards.java:204) ~[AdvancementRewards$Deserializer.class:?]
	at net.minecraft.advancements.AdvancementRewards$Deserializer.deserialize(AdvancementRewards.java:180) ~[AdvancementRewards$Deserializer.class:?]
	at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:69) ~[TreeTypeAdapter.class:?]
	at com.google.gson.Gson.fromJson(Gson.java:887) ~[Gson.class:?]
	at com.google.gson.Gson.fromJson(Gson.java:952) ~[Gson.class:?]
	at com.google.gson.internal.bind.TreeTypeAdapter$GsonContextImpl.deserialize(TreeTypeAdapter.java:162) ~[TreeTypeAdapter$GsonContextImpl.class:?]
	at net.minecraft.util.JsonUtils.deserializeClass(JsonUtils.java:359) ~[JsonUtils.class:?]
	at net.minecraft.util.JsonUtils.deserializeClass(JsonUtils.java:381) ~[JsonUtils.class:?]
	at net.minecraft.advancements.Advancement$Builder.deserialize(Advancement.java:295) ~[Advancement$Builder.class:?]
	at net.minecraft.advancements.AdvancementManager$1.deserialize(AdvancementManager.java:50) ~[AdvancementManager$1.class:?]
	at net.minecraft.advancements.AdvancementManager$1.deserialize(AdvancementManager.java:46) ~[AdvancementManager$1.class:?]
	at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:69) ~[TreeTypeAdapter.class:?]
	at net.minecraft.util.JsonUtils.gsonDeserialize(JsonUtils.java:435) ~[JsonUtils.class:?]
	at net.minecraft.util.JsonUtils.fromJson(JsonUtils.java:485) ~[JsonUtils.class:?]
	at net.minecraft.advancements.AdvancementManager.loadBuiltInAdvancements(AdvancementManager.java:185) [AdvancementManager.class:?]
	at net.minecraft.advancements.AdvancementManager.reload(AdvancementManager.java:69) [AdvancementManager.class:?]
	at net.minecraft.advancements.AdvancementManager.<init>(AdvancementManager.java:61) [AdvancementManager.class:?]
	at net.minecraft.world.WorldServer.init(WorldServer.java:162) [WorldServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.loadAllWorlds(IntegratedServer.java:123) [IntegratedServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.init(IntegratedServer.java:160) [IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:552) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_181]

Propably the advancement needs the vanilla diamond sword json recipe. I disabled the vanilla recipe replacing it with another. I tried to put the advancements in my mod resources: resources/minecraft/advancements but no results.... What i should do for fix this annoying log?

 

Thanks -Nov

 

Link to comment
Share on other sites

What do you mean by removed?

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

17 hours ago, Cadiboo said:

What do you mean by removed?

I removed the recipe via DummyRecipe

 

Util

public static void removeRecipe(Item strItem) {
		 ForgeRegistry<IRecipe> strIRecipe = (ForgeRegistry<IRecipe>)ForgeRegistries.RECIPES;
		 ArrayList<IRecipe> listIRecipe = Lists.newArrayList(strIRecipe.getValues());
		 for (IRecipe strRecipe : listIRecipe) { 
			 ItemStack strItemStack = strRecipe.getRecipeOutput();
			 strIRecipe.remove(strItem.getRegistryName());
      }
	}

 

DummyRecipe

public class DummyRecipe extends IForgeRegistryEntry.Impl<IRecipe> implements IRecipe {
	
    private final ItemStack strItemStack;

    public DummyRecipe
    (ItemStack strItemStack) 
    { 
    	this.strItemStack = strItemStack; 
    }

    public static IRecipe from
    (IRecipe strIRecipe) 
    { 
    	return new DummyRecipe(strIRecipe.getRecipeOutput()).setRegistryName(strIRecipe.getRegistryName()); 
    }

    @Override
    public boolean matches
    (InventoryCrafting strInventoryCrafting, World strWorld) 
    { 
    	return false; 
    }

    @Override
    public ItemStack getCraftingResult(InventoryCrafting strInventoryCrafting) 
    { 
    	return ItemStack.EMPTY; 
    }

    @Override
    public boolean canFit
    (int int1, int int2) 
    { 
    	return false; 
    }

    @Override
    public ItemStack getRecipeOutput() 
    { 
    	return strItemStack; 
    }

 

Usage:

RemoveRecipesUtil.removeRecipe(Items.DIAMOND_SHOVEL);

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.