Reflection problem + season update server side

LaurentOutang · December 16, 2018

Hey, I have a reflection problem only on my "true" minecraft (not on eclipse) : it seams that he can not change enableSnow value... I also have two more questions : my mod is supposed to manage seasons (summer and winter), but I want that these seasons are the same for all the players. So is my code right or should I put "@SideOnly(Side.SERVER)" before each method that update seasons ? How could I do stop the time when there is no player on the server ? Maybe I should use WorldTickEvent.setCancelled(true); but only on server side ? Should I also cancel ServerTickEvent etc. Thank you.

package com.laurentoutang.hardmod.Seasons;

import java.util.Collection;

import com.laurentoutang.hardmod.Main;
import com.laurentoutang.hardmod.Init.BiomeInit;
import com.laurentoutang.hardmod.Init.ItemInit;
import com.laurentoutang.hardmod.capabilities.IMentalTemperature;
import com.laurentoutang.hardmod.capabilities.MentalTemperatureProvider;

import net.minecraft.block.BlockBeetroot;
import net.minecraft.block.BlockCarrot;
import net.minecraft.block.BlockCocoa;
import net.minecraft.block.BlockCrops;
import net.minecraft.block.BlockMelon;
import net.minecraft.block.BlockPotato;
import net.minecraft.block.BlockPumpkin;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Biomes;
import net.minecraft.server.MinecraftServer;
import net.minecraft.world.World;
import net.minecraft.world.biome.Biome;
import net.minecraftforge.event.CommandEvent;
import net.minecraftforge.event.entity.player.PlayerWakeUpEvent;
import net.minecraftforge.event.world.BlockEvent;
import net.minecraftforge.event.world.BlockEvent.CropGrowEvent;
import net.minecraftforge.fml.client.FMLClientHandler;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.ObfuscationReflectionHelper;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.TickEvent.PlayerTickEvent;
import net.minecraftforge.fml.common.gameevent.TickEvent.WorldTickEvent;
import net.minecraftforge.fml.common.registry.ForgeRegistries;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraftforge.fml.server.FMLServerHandler;

@EventBusSubscriber
public class SeasonEventHandler {
	
	private static boolean transition = true;
	

	@SubscribeEvent
	public static void onWakeUp(PlayerWakeUpEvent event)
	{
		SeasonWorldProvider.season_manager.isDay = true;
	}
	
	@SubscribeEvent
	public static void onPlayerCommandTimeSet(CommandEvent event)
	{
		if(event.getCommand().getName() == "time" && "set".equals(event.getParameters()[0]))		
		{
			event.setCanceled(true);
		}		
	}
	
	@SubscribeEvent
	public static void onBlockDestroyed(BlockEvent.BreakEvent event)
	{ 
			if(SeasonWorldProvider.season_manager.getSeason() == SeasonManager.seasons.Winter && (
	    		   event.getState().getBlock() instanceof BlockBeetroot || 
	    		   event.getState().getBlock() instanceof BlockCarrot || 
	    		   event.getState().getBlock() instanceof BlockPotato || 
	    		   event.getState().getBlock() instanceof BlockCrops || 
	    		   event.getState().getBlock() instanceof BlockCocoa || 
	    		   event.getState().getBlock() instanceof BlockMelon || 
	    		   event.getState().getBlock() instanceof BlockPumpkin
			))
	       {
	            event.setCanceled(true);
	       }
	}
	
	@SubscribeEvent
	public static void onPlayerTick(PlayerTickEvent event)
	{
		EntityPlayer player = event.player;
		
		
		if (player.world.isRemote) 
			return;
		else
			registerArmorTemperature(player);
		
	}
	
	@SubscribeEvent()
	public static void onWorldTick(WorldTickEvent event)
	{		
		MinecraftServer server = FMLClientHandler.instance().getServer();
								
		if(server != null)
		{
			if(server.getOnlinePlayerNames().length > 0)
			{
				if(SeasonWorldProvider.season_manager.getSeason() == SeasonManager.seasons.Winter)
					loadWinterProperties(event.world);
				else
					loadSummerProperties();
				
			}
		}	
	}
	
	private static void registerArmorTemperature(EntityPlayer player)
	{
		IMentalTemperature mt = player.getCapability(MentalTemperatureProvider.MentalTemperature_CAP, null);
		
		
		if(player.inventory.armorItemInSlot(0).getItem().equals(ItemInit.WOOLEN_BOOTS))
		{
			if(mt.getBootsTemperature() == 0)
			{
				mt.setBootsTemperature(10.f);		
			}
		}
		else
		{
			mt.setBootsTemperature(0.f);
		}
		
		
		if(player.inventory.armorItemInSlot(1).getItem().equals(ItemInit.WOOLEN_LEGGINS))
		{
			if(mt.getLegginsTemperature() == 0)
			{
				mt.setLegginsTemperature(10.f);		
			}
		}
		else
		{
			mt.setLegginsTemperature(0.f);
		}
		
		
		if(player.inventory.armorItemInSlot(2).getItem().equals(ItemInit.WOOLEN_CHESTPLATE))
		{
			if(mt.getChestplateTemperature() == 0)
			{
				mt.setChestplateTemperature(10.f);		
			}
		}
		else
		{
			mt.setChestplateTemperature(0.f);
		}
		
		
		
		if(player.inventory.armorItemInSlot(3).getItem().equals(ItemInit.WOOLEN_HELMET))
		{
			if(mt.getHelmetTemperature() == 0)
			{
				mt.setHelmetTemperature(10.f);		
			}
		}
		else
		{
			mt.setHelmetTemperature(0.f);
		}
	}
	
	private static void loadWinterProperties(World world)
	{
		Collection<Biome> allBiomes  = ForgeRegistries.BIOMES.getValuesCollection();
		for(Biome b : allBiomes)
		{
			if(b != Biomes.HELL && b != Biomes.SKY && b != Biomes.VOID)
			{
				ObfuscationReflectionHelper.setPrivateValue(Biome.class, b, true, "enableSnow");
				ObfuscationReflectionHelper.setPrivateValue(Biome.class, b, 0.0F, "temperature");
			}
			
		}
		//Custom biome
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, BiomeInit.forestRemastered, true, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, BiomeInit.forestRemastered, 0.0F, "temperature");
		if(transition)
		{
			world.getWorldInfo().setRainTime(288000);
			transition = false;
		}
			
	}
	
	private static void loadSummerProperties()
	{
		if( transition == false)
			transition = true;	
		
		Collection<Biome> allBiomes  = ForgeRegistries.BIOMES.getValuesCollection();
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.OCEAN, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.OCEAN, 0.5F, "temperature");
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.BEACH, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.BEACH, 0.8F, "temperature");
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.BIRCH_FOREST, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.BIRCH_FOREST, 0.6F, "temperature");
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.BIRCH_FOREST_HILLS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.BIRCH_FOREST_HILLS, 0.6F, "temperature");
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.COLD_BEACH, 0.05F, "temperature");
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.COLD_TAIGA, -0.5F, "temperature");
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.COLD_TAIGA_HILLS, -0.5F, "temperature");
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.DEEP_OCEAN, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.DEEP_OCEAN, 0.5F, "temperature");
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.DESERT, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.DESERT, 2.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.DESERT_HILLS, false, "enableSnow");			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.DESERT_HILLS, 2.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.EXTREME_HILLS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.EXTREME_HILLS, 0.2F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.EXTREME_HILLS_EDGE, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.EXTREME_HILLS_EDGE, 0.2F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.EXTREME_HILLS_WITH_TREES, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.EXTREME_HILLS_WITH_TREES, 0.2F, "temperature");		
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.FOREST, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.FOREST, 0.7F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, BiomeInit.forestRemastered, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, BiomeInit.forestRemastered, 0.7F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.FOREST_HILLS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.FOREST_HILLS, 0.7F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.FROZEN_OCEAN, 0.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.FROZEN_RIVER, 0.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.ICE_MOUNTAINS, 0.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.ICE_PLAINS, 0.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.JUNGLE, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.JUNGLE, 0.95F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.JUNGLE_EDGE, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.JUNGLE_EDGE, 0.95F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.JUNGLE_HILLS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.JUNGLE_HILLS, 0.95F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MESA, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MESA, 2.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MESA_CLEAR_ROCK, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MESA_CLEAR_ROCK, 2.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MESA_ROCK, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MESA_ROCK, 2.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUSHROOM_ISLAND, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUSHROOM_ISLAND, 0.9F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUSHROOM_ISLAND_SHORE, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUSHROOM_ISLAND_SHORE, 0.9F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_BIRCH_FOREST, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_BIRCH_FOREST, 0.6F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_BIRCH_FOREST_HILLS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_BIRCH_FOREST_HILLS, 0.6F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_DESERT, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_DESERT, 2.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_EXTREME_HILLS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_EXTREME_HILLS, 0.2F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_EXTREME_HILLS_WITH_TREES, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_EXTREME_HILLS_WITH_TREES, 0.2F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_FOREST, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_FOREST, 0.6F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_ICE_FLATS, 0.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_JUNGLE, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_JUNGLE, 0.95F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_JUNGLE_EDGE, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_JUNGLE_EDGE, 0.95F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_MESA, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_MESA, 2.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_MESA_CLEAR_ROCK, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_MESA_CLEAR_ROCK, 2.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_MESA_ROCK, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_MESA_ROCK, 2.0F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_PLAINS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_PLAINS, 0.8F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_REDWOOD_TAIGA, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_REDWOOD_TAIGA, 0.25F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_REDWOOD_TAIGA_HILLS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_REDWOOD_TAIGA_HILLS, 0.25F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_ROOFED_FOREST, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_ROOFED_FOREST, 0.7F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_SAVANNA, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_SAVANNA, 1.2F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_SAVANNA_ROCK, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_SAVANNA_ROCK, 1.2F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_SWAMPLAND, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_SWAMPLAND, 0.8F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_TAIGA, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_TAIGA, 0.25F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.MUTATED_TAIGA_COLD, -0.5F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.PLAINS, false, "enableSnow");			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.PLAINS, 0.8F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.REDWOOD_TAIGA, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.REDWOOD_TAIGA, 0.25F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.REDWOOD_TAIGA_HILLS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.REDWOOD_TAIGA_HILLS, 0.25F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.RIVER, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.RIVER, 0.5F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.ROOFED_FOREST, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.ROOFED_FOREST, 0.7F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.SAVANNA, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.SAVANNA, 1.2F, "temperature");		
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.SAVANNA_PLATEAU, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.SAVANNA_PLATEAU, 1.2F, "temperature");
		
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.STONE_BEACH, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.STONE_BEACH, 0.2F, "temperature");			

		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.SWAMPLAND, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.SWAMPLAND, 0.8F, "temperature");

		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.TAIGA, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.TAIGA, 0.25F, "temperature");
			
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.TAIGA_HILLS, false, "enableSnow");
		ObfuscationReflectionHelper.setPrivateValue(Biome.class, Biomes.TAIGA_HILLS, 0.25F, "temperature");		
	}
}

---- Minecraft Crash Report ----
// Would you like a cupcake?

Time: 12/16/18 3:45 PM
Description: Exception in server tick loop

net.minecraftforge.fml.relauncher.ReflectionHelper$UnableToAccessFieldException: net.minecraftforge.fml.relauncher.ReflectionHelper$UnableToFindFieldException: java.lang.NoSuchFieldException: enableSnow
	at net.minecraftforge.fml.relauncher.ReflectionHelper.setPrivateValue(ReflectionHelper.java:170)
	at net.minecraftforge.fml.common.ObfuscationReflectionHelper.setPrivateValue(ObfuscationReflectionHelper.java:98)
	at com.laurentoutang.hardmod.Seasons.SeasonEventHandler.loadSummerProperties(SeasonEventHandler.java:200)
	at com.laurentoutang.hardmod.Seasons.SeasonEventHandler.onWorldTick(SeasonEventHandler.java:107)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_11_SeasonEventHandler_onWorldTick_WorldTickEvent.invoke(.dynamic)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:179)
	at net.minecraftforge.fml.common.FMLCommonHandler.onPreWorldTick(FMLCommonHandler.java:286)
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:750)
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:666)
	at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:185)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:524)
	at java.lang.Thread.run(Thread.java:745)
Caused by: net.minecraftforge.fml.relauncher.ReflectionHelper$UnableToFindFieldException: java.lang.NoSuchFieldException: enableSnow
	at net.minecraftforge.fml.relauncher.ReflectionHelper.findField(ReflectionHelper.java:117)
	at net.minecraftforge.fml.relauncher.ReflectionHelper.setPrivateValue(ReflectionHelper.java:166)
	... 12 more
Caused by: java.lang.NoSuchFieldException: enableSnow
	at java.lang.Class.getDeclaredField(Class.java:2070)
	at net.minecraftforge.fml.relauncher.ReflectionHelper.findField(ReflectionHelper.java:108)
	... 13 more


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- System Details --
Details:
	Minecraft Version: 1.12.2
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 1.8.0_51, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 229862328 bytes (219 MB) / 637534208 bytes (608 MB) up to 2147483648 bytes (2048 MB)
	JVM Flags: 8 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
	IntCache: cache: 0, tcache: 0, allocated: 12, tallocated: 94
	FML: MCP 9.42 Powered by Forge 14.23.2.2611 6 mods loaded, 6 mods active
	States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored

	| State     | ID                | Version      | Source                        | Signature                                |
	|:--------- |:----------------- |:------------ |:----------------------------- |:---------------------------------------- |
	| UCHIJAAAA | minecraft         | 1.12.2       | minecraft.jar                 | None                                     |
	| UCHIJAAAA | mcp               | 9.42         | minecraft.jar                 | None                                     |
	| UCHIJAAAA | FML               | 8.0.99.99    | forge-1.12.2-14.23.2.2611.jar | e3c3d50c7c986df74c645c0ac54639741c90a557 |
	| UCHIJAAAA | forge             | 14.23.2.2611 | forge-1.12.2-14.23.2.2611.jar | e3c3d50c7c986df74c645c0ac54639741c90a557 |
	| UCHIJAAAA | mercurius_updater | 1.0          | MercuriusUpdater-1.12.2.jar   | None                                     |
	| UCHIJAAAA | hm                | 1.1          | Hard_Mod-1.7.jar              | None                                     |

	Loaded coremods (and transformers): 
	GL info: ~~ERROR~~ RuntimeException: No OpenGL context found in the current thread.
	Profiler Position: N/A (disabled)
	Player Count: 1 / 8; [EntityPlayerMP['JeanMichouAK47'/1391, l='Test_Vache_Sound', x=-24.50, y=68.00, z=-96.50]]
	Type: Integrated Server (map_client.txt)
	Is Modded: Definitely; Client brand changed to 'fml,forge'

Edited December 16, 2018 by LaurentOutang

V0idWa1k3r · December 16, 2018

On 12/16/2018 at 3:37 PM, LaurentOutang said:

should I put "@SideOnly(Side.SERVER)" before each method that update seasons ?

Expand

Read and understand: https://mcforge.readthedocs.io/en/latest/concepts/sides/

On 12/16/2018 at 3:37 PM, LaurentOutang said:

Maybe I should use WorldTickEvent.setCancelled(true); but only on server side ? Should I also cancel ServerTickEvent etc

Expand

You can't cancel a TickEvent, they don't have a @Canellable annotation. Cancelling them would make no sense anyway,

On 12/16/2018 at 3:37 PM, LaurentOutang said:

How could I do stop the time when there is no player on the server ?

Expand

Have an internal timer that only decrements when there are players on the server.

On 12/16/2018 at 3:37 PM, LaurentOutang said:

Caused by: java.lang.NoSuchFieldException: enableSnow

Expand

On 12/16/2018 at 3:37 PM, LaurentOutang said:

ObfuscationReflectionHelper.setPrivateValue(Biome.class, BiomeInit.forestRemastered, true, "enableSnow");

Expand

You must provide both the MCP(deobfuscated) and the SRG field names.(if you are using newer forge version then SRG only will suffice). You can get the SRG name of a field from mcpbot or from your local gradle caches.

On 12/16/2018 at 3:37 PM, LaurentOutang said:

MinecraftServer server = FMLClientHandler.instance().getServer(); if(server != null) {

Expand

Don't do this, you might be reaching across logical sides. Check that you are on a server in the first place.

On 12/16/2018 at 3:37 PM, LaurentOutang said:

private static void loadWinterProperties(World world)

Expand

You are invoking this method each tick. Inside of this method you are changing a bunch of values using reflection, while not caching the fields. This is a horrendous performance loss. First of all only change the data when the "season" changes. Also cache your fields.

On 12/16/2018 at 3:37 PM, LaurentOutang said:

//Custom biome

Expand

You custom biome will already be in forge's biome registry which you are iterating anyway.

On 12/16/2018 at 3:37 PM, LaurentOutang said:

private static void loadSummerProperties()

Expand

Whatever on earth is happening here is insane. Don't do whatever it is you are doing in this method. Cache the defaults for each biome on startup, then restore them here.

LaurentOutang · December 16, 2018

Thank you for answering and sorry for my english.

On 12/16/2018 at 3:47 PM, V0idWa1k3r said:

Read and understand: https://mcforge.readthedocs.io/en/latest/concepts/sides/

Expand

If I have the same .jar for physical client and server I don't have to deal with @SideOnly, right?

FMLClientHandler.instance().getServer();
FMLServerHandler.instance().getServer();
FMLCommonHandler.instance().getServer();

What is the difference between these three things (with logical / physical explanation please) ?

In the link, it is said :

Quote

Use this check whenever you need to determine if game logic and other mechanics should be run. For example, if you want to damage the player every time they click your block, or have your machine process dirt into diamonds, you should only do so after ensuring world.isRemote is false. Applying game logic to the logical client can cause desynchronization (ghost entities, desynchronized stats, etc.) in the lightest case, and crashes in the worst case.

Expand

Then for every method that is related to season I should check if world.isRemote == false in order not to desynchronize (the cycle of seasons is game logic)?

On 12/16/2018 at 3:47 PM, V0idWa1k3r said:

You must provide both the MCP(deobfuscated) and the SRG field names.(if you are using newer forge version then SRG only will suffice). You can get the SRG name of a field from mcpbot or from your local gradle caches.

Expand

I really don't understand this, what do you mean by MCP and SRG ? what should I change in my code ?

On 12/16/2018 at 3:47 PM, V0idWa1k3r said:

On 12/16/2018 at 3:37 PM, LaurentOutang said:

MinecraftServer server = FMLClientHandler.instance().getServer(); if(server != null) {

Expand

Don't do this, you might be reaching across logical sides. Check that you are on a server in the first place.

Expand

Should I check !world.isRemote ?

What do you mean when you say "cache your fields" please I don't understand it ?

Sorry for all these questions and thank you very much.

Edited December 16, 2018 by LaurentOutang

V0idWa1k3r · December 16, 2018

On 12/16/2018 at 5:55 PM, LaurentOutang said:

If I have the same .jar for physical client and server I don't have to deal with @SideOnly, right?

Expand

Well, you do, rarely. You pretty much shouldn't be using it on your own methods though.

On 12/16/2018 at 5:55 PM, LaurentOutang said:

What is the difference between these three things (with logical / physical explanation please) ?

Expand

These are basically somewhat of a proxy(ish) for forge. Client/Server execute side-specific stuff while common executes common code. Note however that they are NOT a proxy, and you shouldn't have a common proxy. But it doesn't matter anyway since you shouldn't get the server like that. Get it from a respective WorldServer instance.

On 12/16/2018 at 5:55 PM, LaurentOutang said:

Then for every method that is related to season I should check id world.isRemote == false in order not to desynchronize (the cycle of seasons is game logic)?

Expand

Well, kinda. It's not about synchronization, it's about running logic on the server. You still need to notify the clients of the change using the packets though.

On 12/16/2018 at 5:55 PM, LaurentOutang said:

I really don't understand this, what do you mean by MCP and SRG ? what should I change in my code ?

Expand

Minecraft is an obfuscated game, meaning that things like Minecraft.getMinecraft().player.swingArm() are actually ada.b.a.d() in the compiled binary. The ada.b.a.d() nonesense is called NOTCH names and that is how the game looks when you download it from the official website. Not very good for modders, so a group of people decided to deobfuscate the game by manually "translating" this giberrish into human-readable names. It is done in two steps - first the names are translated into still non-human readable but consistent names - func_141242 for example. You don't know what this means and neither do I but this stays consistent between versions which allows for a simple database to be setup. These are called SRG names. Finally these are translated locally on your machine when deobfuscating into human-readable MCP names(like swingArm). When the game launches with forge it runs SRG names, so when mods are compiled a backwards process is applied - the MCP names the mod references turn into SRG names. Thus we come to reflection issues - since reflection searches by name there is an issue since the compiled binary has different names than the one you are running in your dev environment. So forge has helper methods that allow you to pass multiple names to reflect on or in case of the later forge you only need the SRG name. Why SRG? Because it's consistent. MCP names may change as often as each day, but the SRG stay consistent. So yeah, here you go, I guess

On 12/16/2018 at 5:55 PM, LaurentOutang said:

What do you mean when you say "cache your fields" please I don't understand it ?

Expand

https://en.wikipedia.org/wiki/Memoization

LaurentOutang · December 16, 2018

Ok i'll read this. Thank you very much. I think it will take time. I'll update this post when I finish all these things. Thank you.

Edited December 16, 2018 by LaurentOutang

Cadiboo · December 17, 2018

About the obfuscation

Notch - obfuscated name

SRG - stays the same between versions, named after Searge who invented the system

MCP - deobfscated, translated from SRG with mappings, can change between mappings.

A great site is http://mcp.thiakil.com/

Sign In

Reflection problem + season update server side

Recommended Posts

LaurentOutang

V0idWa1k3r

LaurentOutang

V0idWa1k3r

LaurentOutang

Cadiboo

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information