Jump to content

onLivingDeath event not fireing at EntityPlayer#onDeath ?


Recommended Posts

Posted

So I tried to answer a thread here and i made an example which works fine at local 

When game is "singleplayer" the onLivingDeath fires on
All entities

When game is "multiplayer" the onLivingDeath fires on
All entities but any form of players

This is weird since the documentation says it will fire on  EntityPlayers

 

@SubscribeEvent
	public void reeewdyeven(LivingDeathEvent event){
		System.out.println("WTF");
		if (true){
			System.out.println("asd");
			Minecraft mc = Minecraft.getMinecraft();
			mc.player.sendChatMessage(" died");
		}
	}


This is Running on my client and does say in server chat "died" when a mob dies

Does nothing when the owner (ME) or any player dies.
Is there any other event that catches it or how does your client even notices that somebody died then? (why is it working on local??? )

Posted
  On 1/2/2019 at 3:55 PM, diesieben07 said:

It is working "on local", since in single player client and server run in the same JVM, so your code runs on the server side. LivingDeathEvent is only reliable on the server, the server does not really tell the client about entity deaths, the client only knows "the entity no longer exists". There is no way to distinguish between "the entity despawned" and "the entity was killed by an arrow" on the client. This kind of stuff must be done on the server.

You might want to read up on how sides work: https://mcforge.readthedocs.io/en/latest/concepts/sides/.

Expand  

Okay understood I did it with serverside and  it is indeed working there. But I dont get the client part still. I was aware of the sides but can you explain this please then

If the LivingDeathEvent  is only reliable on the server how could i catch a packet that informs the client that some Entity has to disappear since the client is informed correctly and reliably every time something dies.

PS: i know its easier on the server still BUT the example was a client sided only mod. So how would you get any info when an entity dies? eg:can the proxy catch the targetted packet?

Posted
  On 1/2/2019 at 5:07 PM, diesieben07 said:

There is no way to know "how did this entity die" on the client. It must happen on the server.

Expand  

Well, you could send a custom packet from the server to tell the client what happened.  But - directed at @Eiachh - this feels a bit like an XY problem.  Why do you need this level of information on the client in the first place, and what are you trying to achieve?

Posted
  On 1/3/2019 at 1:04 PM, desht said:

Well, you could send a custom packet from the server to tell the client what happened.  But - directed at @Eiachh - this feels a bit like an XY problem.  Why do you need this level of information on the client in the first place, and what are you trying to achieve?

Expand  

Well basically I DONT there were this guy who were trying to make a CLIENT SIDE ONLY mod which would do somethign when a player dies "show particles" but this solution would involve the mod to be on the server as well.

Anyway I am not bothering with it anymore since if i would need it i would just install it on the server as well and make the server handle it. But beside this I still don't understand why is this event fireing all the time(on the client) when a mobentity dies without missing even 1 but never fires when a player dies. But fires flawlessly on the physical server side.

Posted
  On 1/3/2019 at 1:10 PM, Eiachh said:

fireing all the time(on the client)

Expand  

Which client?

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 1/5/2019 at 12:21 PM, Cadiboo said:

Which client?

Expand  

If you are joined to a physical server then this event fires on the logical client ( @sideonly(side.client),    worls.isRemote==true) if I am correct. This is what i meant. But only for mob deaths. But still I am not interested in this anymore so don't bother with it at least not for me.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Different problem now. https://paste.ee/p/iDo8lS35
    • I would like to have a BoP sapling drop from my block if it is also installed. I think I have done everything and I cannot pinpoint the problem, which is the error in the logs that appears when joining a world:   [Worker-Main-11/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:grasses:blocks/leaves_block com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'biomesoplenty:magic_sapling' My code:   LootItemConditions.CONDITIONS.register(modEventBus); public class LootItemConditions { public static final DeferredRegister<LootItemConditionType> CONDITIONS = DeferredRegister.create(Registries.LOOT_CONDITION_TYPE, Grasses.MOD_ID); public static final RegistryObject<LootItemConditionType> IS_MOD_LOADED = CONDITIONS.register("is_mod_loaded", () -> new LootItemConditionType(new IsModLoaded.ConditionSerializer())); } public class IsModLoaded implements LootItemCondition { private final boolean exists; private final String modID; public IsModLoaded(String modID) { this.exists = ModList.get().isLoaded(modID); this.modID = modID; } @Override public LootItemConditionType getType() { return LootItemConditions.IS_MOD_LOADED.get(); } @Override public boolean test(LootContext context) { return this.exists; } public static LootItemCondition.Builder builder(String modid) { return () -> new IsModLoaded(modid); } public static class ConditionSerializer implements Serializer<IsModLoaded> { @Override public void serialize(JsonObject json, IsModLoaded instance, JsonSerializationContext ctx) { json.addProperty("modid", instance.modID); } @Override public IsModLoaded deserialize(JsonObject json, JsonDeserializationContext ctx) { return new IsModLoaded(GsonHelper.getAsString(json, "modid")); } } } protected LootTable.Builder createLeavesDropsWithModIDCheck(Block selfBlock, Item sapling, Property<?>[] properties, String modIDToCheck, float... chances) { CopyBlockState.Builder blockStateCopyBuilder = CopyBlockState.copyState(selfBlock); for(Property<?> property : properties) { blockStateCopyBuilder.copy(property); } return LootTable.lootTable() .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(LootItem.lootTableItem(selfBlock) .when(HAS_SHEARS_OR_SILK_TOUCH) .apply(blockStateCopyBuilder))) .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionCondition(selfBlock, LootItem.lootTableItem(sapling)) .when(IsModLoaded.builder(modIDToCheck))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, chances)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH)) .withPool(LootPool.lootPool().name("sticks").setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionDecay(selfBlock, LootItem.lootTableItem(Items.STICK). apply(SetItemCountFunction.setCount(UniformGenerator.between(1.0F, 2.0F)))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, NORMAL_LEAVES_STICK_CHANCES)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH))); } I don't know. Am I making a mistake somewhere? Am I forgetting something? Should there be something else?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.