What is and isn't the "right way" to make mods?

[NarwhelZhu]

I'm very new to Forge modding and have only been learning it for a few days, so I've been going through dozens of tutorials to try to understand how all the setup works. Right now I'm using Loremaster's 1.12.2 tutorials, but there are a lot of things I'm confused about that he doesn't explain, and I've seen a lot of people saying that the way he does it is highly inefficient, so I'm afraid he's teaching me bad coding practices, so I'm hoping someone can clear this up a bit more for me.

 

Loremaster uses proxy classes in his tutorials, the ClientProxy and the CommonProxy, and from what I understand, the proxy classes are there to tell Forge what side to run that code in. But I've heard so many people say that using a "common proxy" is stupid because everything is common code except the actual designated client proxy and server proxy. If that's so universally true and known, why does every recent Youtube tutorial I find use the CommonProxy?? Are they all just stupid or something?

 

And second, in his tutorials, he puts the ModelLoader method in the ClientProxy class, and I can only GUESS that the reason is because the ModelLoader method can only be run on the client side (because "models" are the 3D images the player interacts with, right? Maybe? I have no idea, I can't find a straight answer as to what a "model" actually is). That seems to make sense to me, but I tried using the ModelLoader method outside the ClientProxy class, and it seemed to work just fine. Nothing crashed, no exceptions, everything worked. If it worked, then why did it even need to go in the ClientProxy to begin with?? Is that an example of "reaching across sides" as the Forge docs put it?

 

I can't seem to find a good tutorial that goes through this stuff so you actually know what things do and why so you know what you need to do and what's redundant. No tutorial I've seen ever really explains these things in depth, they just tell you to do what they do because, "well you wanted to make a mod right?? Of course I'm not actually going to go in depth on how to be efficient and only do things when you need to do them, just blindly follow what I do and you got yourself a probably badly-designed mod that will break with anything else except very basic stuff." It's kind of frustrating.

[Eiachh]

Well if you really want a tutorial then read and ignore youtbe videos. I have a feeling that all the guys who make youtube videos can only do thoose basic stuff and nothing else. They even use the exact same example.

What I did i used this tutorial: This

Then start to read the documentation. If you dont like to do it like nobody in the world just read the getting started and the Concepts exspecially this. (About the proxies)

Then i watched his videos.


Now maybe some will say this is "hand feading and exspecially don't watch guides" but to start this was kinda ok for me (but really dont watch guides on youtube). Thoose videos are really helpfull if you have the base concept.
Sadly to answer your exact question idk what "ModLoader" method do you mean exactly?

[NarwhelZhu]

Thanks for the reply, I'll look into those resources, although the videos you linked are outdated by now I think. And what I mean by the ModelLoader method is this thing: "ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName(), id));". I only have a basic grasp on what it means, but in Loremaster's videos, he put that method in another method called registerItemRenderer inside the ClientProxy class, and then called that method in a RegistryHandler class using the subscribe events. And I don't understand why he did it that way, he kind of just expects you to either intuitively know why he did it somehow, or he expects you to just not care. Either way I didn't learn much from it. If you watch his video on custom items you'll see what I mean, I don't know how to describe it well.

 

I'm not necessarily looking for a "tutorial" or a "guide," but I'm looking for ways to find information that I'll need to make mods on my own.

 

For example, if certain methods can only run on client side or run differently on server side and client side, how will I know? In tutorials they say "you use the proxy classes for methods that can only run on either side," but how will I know when that's the case for any given method? Is there some metaphorical giant flashing sign for every method somewhere saying "yo, this method can only be run in the client proxy or else it will break everything, just a heads up"?

 

Edit: Just realized ModelLoader is a class not a method, I'm an idiot sometimes lol

Edited January 9, 2019 by NarwhelZhu

[larsgerrits]

  On 1/9/2019 at 4:41 PM, NarwhelZhu said:

Loremaster uses proxy classes in his tutorials, the ClientProxy and the CommonProxy, and from what I understand, the proxy classes are there to tell Forge what side to run that code in. But I've heard so many people say that using a "common proxy" is stupid because everything is common code except the actual designated client proxy and server proxy. If that's so universally true and known, why does every recent Youtube tutorial I find use the CommonProxy?? Are they all just stupid or something?

Expand  

It's called "cargo cult programming".  Basically, because someone did it that way once, other people started copying it because that's the only way the

 

  On 1/9/2019 at 4:41 PM, NarwhelZhu said:

I tried using the ModelLoader method outside the ClientProxy class, and it seemed to work just fine. Nothing crashed, no exceptions, everything worked. If it worked, then why did it even need to go in the ClientProxy to begin with?? Is that an example of "reaching across sides" as the Forge docs put it?

Expand  

That's because in your development environment both the client and server code is available. When you install your mod on the client, you also have both client and server code available. However, when your mods get installed on the server, the client code is missing and your mod will crash the server because it cannot find those files. (Docs)

 

  On 1/9/2019 at 4:41 PM, NarwhelZhu said:

I can't seem to find a good tutorial that goes through this stuff so you actually know what things do and why so you know what you need to do and what's redundant. No tutorial I've seen ever really explains these things in depth

Expand  

There's no single tutorial that does everything correctly, because there's more than 1 way to do something correctly. However, there are some things (like CommonProxy) which are fundamentally wrong and shouldn't be used at all.

 

  On 1/9/2019 at 4:41 PM, NarwhelZhu said:

they just tell you to do what they do because, "well you wanted to make a mod right?? Of course I'm not actually going to go in depth on how to be efficient and only do things when you need to do them, just blindly follow what I do and you got yourself a probably badly-designed mod that will break with anything else except very basic stuff." It's kind of frustrating.

Expand  

That's the problem with YouTube tutorials.

[theishiopian]

You can't find a good explanation of a model, well heres one: A model is 3D geometry that a texture is wrapped around. It's not so much an "image", but a model, as in a toy model. Think of it like a christmas present, with the texture as the wrapping paper.

[FlordiaDucky]

I use the same tutorials

[Cadiboo]

To try and help avoid these problems and people making bad mods, I’ve made a Modding skeleton for people to download and get straight into modding with https://github.com/Cadiboo/Example-Mod