[Solved] Creating a custom bucket

[Glorfindel22]

I am working on adding a wooden bucket into my mod. My plan is for the wooden bucket to be able to pick up water and milk but not lava. I am nearly finished, my only problem is that the wooden bucket doesn't detect when I right click it with the cow. However, I have been playing around with the seperate item for Milk bucket which works perfectly. (I can drink & it becomes an empty wood bucket again). Below is my code.

 

Mod base file

package richard.RecipeExpansionPack;

//Removed the imports just to keep it shorter for you guys


@Mod(modid="REP", name="RecipeExpansionPack", version="1.0.0")
@NetworkMod(clientSideRequired=true, serverSideRequired=false)
public class RecipeExpansionPack {

        // The instance of your mod that Forge uses.
        @Instance("RecipeExpansionPack")
        public static RecipeExpansionPack instance;
        
        //New Items
        public static Item bucketWoodEmpty = (new ItemWoodBucket(5000, 0)).setUnlocalizedName("woodbucket").setMaxStackSize(16);
        public static Item bucketWoodWater = (new ItemWoodBucket(5001, Block.waterMoving.blockID)).setUnlocalizedName("woodbucketWater").setContainerItem(bucketWoodEmpty);
        public static Item bucketWoodMilk = (new ItemWoodBucketMilk(5002)).setUnlocalizedName("woodbucketmilk").setContainerItem(bucketWoodEmpty);
        
        // Says where the client and server 'proxy' code is loaded.
        @SidedProxy(clientSide="richard.RecipeExpansionPack.client.ClientProxy", serverSide="richard.RecipeExpansionPack.CommonProxy")
        public static CommonProxy proxy;
        
        @PreInit
        public void preInit(FMLPreInitializationEvent event) {
                // Stub Method
        }
        
        @Init
        public void load(FMLInitializationEvent event) {
                proxy.registerRenderers();
                
                //Language Registry
                LanguageRegistry.addName(bucketWoodEmpty, "Wooden Bucket");
                LanguageRegistry.addName(bucketWoodWater, "Water Bucket");
                LanguageRegistry.addName(bucketWoodMilk, "Milk Bucket");
        }
        
        @PostInit
        public void postInit(FMLPostInitializationEvent event) {
                // Stub Method
        }
}

 

ItemWoodBucket.java

package richard.RecipeExpansionPack;

//Again removed imports

public class ItemWoodBucket extends ItemBucket {
   
   private int isFull;
   
   public ItemWoodBucket(int par1, int par2) {
      super(par1, par2);
      this.isFull = par2;            // This is really important; That was what I've forgotten.

   }
   
   @Override
   public void func_94581_a(IconRegister iconRegister)
   {
   if(isFull ==  {
                iconIndex = iconRegister.func_94245_a("RecipeExpansionPack:woodbucket-w");
   }else{
	iconIndex = iconRegister.func_94245_a("RecipeExpansionPack:woodbucket-e");
   }
   }
   
   @Override
   public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
   {
       float f = 1.0F;
       double d0 = par3EntityPlayer.prevPosX + (par3EntityPlayer.posX - par3EntityPlayer.prevPosX) * (double)f;
       double d1 = par3EntityPlayer.prevPosY + (par3EntityPlayer.posY - par3EntityPlayer.prevPosY) * (double)f + 1.62D - (double)par3EntityPlayer.yOffset;
       double d2 = par3EntityPlayer.prevPosZ + (par3EntityPlayer.posZ - par3EntityPlayer.prevPosZ) * (double)f;
       boolean flag = this.isFull == 0;
       MovingObjectPosition movingobjectposition = this.getMovingObjectPositionFromPlayer(par2World, par3EntityPlayer, flag);

       if (movingobjectposition == null)
       {
           return par1ItemStack;
       }
       else
       {
           FillBucketEvent event = new FillBucketEvent(par3EntityPlayer, par1ItemStack, par2World, movingobjectposition);
           if (MinecraftForge.EVENT_BUS.post(event))
           {
               return par1ItemStack;
           }

           if (event.getResult() == Event.Result.ALLOW)
           {
               if (par3EntityPlayer.capabilities.isCreativeMode)
               {
                   return par1ItemStack;
               }

               if (--par1ItemStack.stackSize <= 0)
               {
                   return event.result;
               }

               if (!par3EntityPlayer.inventory.addItemStackToInventory(event.result))
               {
                   par3EntityPlayer.dropPlayerItem(event.result);
               }

               return par1ItemStack;
           }

           if (movingobjectposition.typeOfHit == EnumMovingObjectType.TILE)
           {
               int i = movingobjectposition.blockX;
               int j = movingobjectposition.blockY;
               int k = movingobjectposition.blockZ;

               if (!par2World.canMineBlock(par3EntityPlayer, i, j, k))
               {
                   return par1ItemStack;
               }

               if (this.isFull == 0)
               {
                   if (!par3EntityPlayer.canPlayerEdit(i, j, k, movingobjectposition.sideHit, par1ItemStack))
                   {
                       return par1ItemStack;
                   }

                   if (par2World.getBlockMaterial(i, j, k) == Material.water && par2World.getBlockMetadata(i, j, k) == 0)
                   {
                       par2World.func_94571_i(i, j, k);

                       if (par3EntityPlayer.capabilities.isCreativeMode)
                       {
                           return par1ItemStack;
                       }

                       if (--par1ItemStack.stackSize <= 0)
                       {
                           return new ItemStack(RecipeExpansionPack.bucketWoodWater);
                       }

                       if (!par3EntityPlayer.inventory.addItemStackToInventory(new ItemStack(RecipeExpansionPack.bucketWoodWater)))
                       {
                           par3EntityPlayer.dropPlayerItem(new ItemStack(RecipeExpansionPack.bucketWoodWater.itemID, 1, 0));
                       }

                       return par1ItemStack;
                   }

               }
               else
               {
                   if (this.isFull < 0)
                   {
                       return new ItemStack(RecipeExpansionPack.bucketWoodEmpty);
                   }

                   if (movingobjectposition.sideHit == 0)
                   {
                       --j;
                   }

                   if (movingobjectposition.sideHit == 1)
                   {
                       ++j;
                   }

                   if (movingobjectposition.sideHit == 2)
                   {
                       --k;
                   }

                   if (movingobjectposition.sideHit == 3)
                   {
                       ++k;
                   }

                   if (movingobjectposition.sideHit == 4)
                   {
                       --i;
                   }

                   if (movingobjectposition.sideHit == 5)
                   {
                       ++i;
                   }

                   if (!par3EntityPlayer.canPlayerEdit(i, j, k, movingobjectposition.sideHit, par1ItemStack))
                   {
                       return par1ItemStack;
                   }

                   if (this.tryPlaceContainedLiquid(par2World, d0, d1, d2, i, j, k) && !par3EntityPlayer.capabilities.isCreativeMode)
                   {
                       return new ItemStack(RecipeExpansionPack.bucketWoodEmpty);
                   }
               }
           }
           else if (this.isFull == 0 && movingobjectposition.entityHit instanceof EntityCow)
           {
               return new ItemStack(RecipeExpansionPack.bucketWoodMilk);
           }

           return par1ItemStack;
       }
   }
}

 

 

[Vogner]

My mod has an identical feature, with the same issue. I've tried everything, I'm beginning to think we're going to have to create an event handler for interacting with the bucket with the custom bucket.

[Glorfindel22]

Hmm... Nice to know I am not the only one that has this issue. I am still looking for a solution though. It's not a huge deal though since the bucket can pick up and drop water fine but I kind of did want to implement the milk.

[Chibill]

The cows have the bukket inteact code in there code so you would have to use a coremod to add your bukket to the list.

[Glorfindel22]

  Quote

Or use the EntityInteractEvent.[/Quote] Thanks that worked!

 

For future reference here is my code

@ForgeSubscribe
public void onEntityInteract(EntityInteractEvent event)
{
     ItemStack itemstack = event.entityPlayer.inventory.getCurrentItem();

    	if(event.target instanceof EntityCow)
    	{    
    		if (itemstack != null && itemstack.itemID == RecipeExpansionPack.bucketWoodEmpty.itemID)
    		{
    			if (--itemstack.stackSize <= 0)
    			{
    				event.entityPlayer.inventory.setInventorySlotContents(event.entityPlayer.inventory.currentItem, new ItemStack(RecipeExpansionPack.bucketWoodMilk));
    			}
    			else if (!event.entityPlayer.inventory.addItemStackToInventory(new ItemStack(RecipeExpansionPack.bucketWoodMilk)))
    			{
    			event.entityPlayer.dropPlayerItem(new ItemStack(Item.bucketMilk.itemID, 1, 0));
    			}

    		}
    		else
    		{
    		}
    	}
}

 

I noticed that a lot of other people have been having similar problems so I am considering writing a tutorial now on how to add custom buckets to your mod.

[Vogner]

I figured it out last night, too. I actually came here with the intention of simply giving you my CowHandler code, but it's better that you worked it out for yourself.

 

However, in my mod I made milk an ingame liquid, and I have a problem where interacting with a cow with my wooden bucket prematurely uses the bucket, placing the liquid immediately. I'll figure it out, though. Anyways, for those who care, here's my CowHandler.class:

 

//registration = commented out in Fleshwerxx.class

package fleshwerxx;

import net.minecraft.block.Block;
import net.minecraft.util.MovingObjectPosition;
import net.minecraftforge.event.Event;
import net.minecraftforge.event.entity.player.EntityInteractEvent;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Item;
import net.minecraft.world.World;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.event.Cancelable;
import net.minecraftforge.event.Event;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraft.entity.passive.EntityCow;
import net.minecraft.entity.player.InventoryPlayer;

public class CowHandler
{
@ForgeSubscribe	
public void milkCow(EntityInteractEvent event)
{
	ItemStack currentItem = event.entityPlayer.inventory.getCurrentItem();

	InventoryPlayer inv = event.entityPlayer.inventory;

	int heldItemID = currentItem.itemID;

	if(event.target instanceof EntityCow)
	{
		if(Fleshwerxx.debug)
			event.entityPlayer.addChatMessage("Debug: right clicked cow!");

		if(heldItemID == Fleshwerxx.bucketWood.itemID){
			inv.consumeInventoryItem(Fleshwerxx.bucketWood.itemID);
			inv.addItemStackToInventory(new ItemStack(Fleshwerxx.bucketWoodMilk));
		}
	}//else if (target instanceof EntitySquid)
		//Code to get ink
}
}