[1.12.2] Ticking tile entity updates slot with huge latency

[Legenes]

So I made a block with a ticking tile entity, and a tesr. The problem is when it's done with the "work", it inserts the item in the output slot with an almost 3-5 second latency. My computer isn't lagging at all.
Here's my code of the tileEntity: (please don't critise the setWork part and above, those are WIP)

Quote

package com.konrads.deserted_utilities.blocks.tileEntities.press;

import com.konrads.deserted_utilities.DesertedUtilities;
import com.konrads.deserted_utilities.blocks.tileEntities.press.messages.PacketRequestUpdatePress;
import com.konrads.deserted_utilities.blocks.tileEntities.press.messages.PacketUpdatePress;
import com.konrads.deserted_utilities.recipes.press.PressRecipe;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.ITickable;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.text.TextComponentString;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.ItemStackHandler;

import javax.annotation.Nullable;

public class TileEntityPress extends TileEntity implements ITickable {

    public ItemStackHandler inventory = new ItemStackHandler(5);
    public boolean isWorking;
    public int progress = 45;
    public int waterLevel = 0;

    public Item currentOutputItem;
    public int currentOutputCount;
    public int currentGivenWater;

    public boolean run_;

    public void setWork(PressRecipe currentOutput) {
        currentOutputItem = currentOutput.output.getItem();
        currentOutputCount = currentOutput.output.getCount();
        currentGivenWater = currentOutput.givenWater;
        isWorking = true;
        progress = 0;
        inventory.getStackInSlot(0).shrink(1);
        inventory.getStackInSlot(1).shrink(1);
        inventory.getStackInSlot(2).shrink(1);
        inventory.getStackInSlot(3).shrink(1);
    }

    @Override
    public void onLoad() {
        if (world.isRemote) {
            DesertedUtilities.network.sendToServer(new PacketRequestUpdatePress(this));
        }
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        compound.setTag("inventory", inventory.serializeNBT());
        compound.setBoolean("isWorking", isWorking);
        compound.setInteger("waterLevel", waterLevel);
        return super.writeToNBT(compound);
    }

    @Override
    public void readFromNBT(NBTTagCompound compound) {
        inventory.deserializeNBT(compound.getCompoundTag("inventory"));
        isWorking = compound.getBoolean("isWorking");
        waterLevel = compound.getInteger("waterLevel");
        super.readFromNBT(compound);
    }

    @Override
    public boolean hasCapability(Capability<?> capability, @Nullable EnumFacing facing) {
        return capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY || super.hasCapability(capability, facing);
    }

    @Nullable
    @Override
    public <T> T getCapability(Capability<T> capability, @Nullable EnumFacing facing) {
        return capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY ? (T)inventory : super.getCapability(capability, facing);
    }

    @Override
    public AxisAlignedBB getRenderBoundingBox() {
        return new AxisAlignedBB(getPos(), getPos().add(1, 2, 1));
    }

    public void endProgress() {
        waterLevel += currentGivenWater;
        if (waterLevel > 1000)
            waterLevel = 1000;
        inventory.insertItem(4, new ItemStack(currentOutputItem, currentOutputCount), false);
        isWorking = false;
        progress = 45;
    }

    @Override
    public void update() {
        if (isWorking) {
            if (progress >= 65)
                endProgress();
            else
                progress += 1;
        }
    }

}

 

What am I doing wrong? Thanks for help!

Edited January 16, 2019 by Legenes

[Legenes]

6 hours ago, diesieben07 said:

23 hours ago, Legenes said:

DesertedUtilities.network.sendToServer(new PacketRequestUpdatePress(this));

wtf is this? You do not need this in any way.

  

Interestingly, I do. My tesr uses the block's properties to render, and if I don't send this packet, my tile won't work till' I use it. (After world load it wouldn't render the things that are set in the tile, like the progress variable. Defaultly it should be 45, but without this message it's 0)

 

6 hours ago, diesieben07 said:

23 hours ago, Legenes said:

public ItemStackHandler inventory = new ItemStackHandler(5);

ItemStackHandler by default does not mark your tile entity for saving. You need to create an ItemStackHandler subclass which calls markDirty in onContentsChanged.

Thanks, I'll try that.

 

6 hours ago, diesieben07 said:

Now for your question of delay: How are you observing this delay?

First: I see it poping up with late in the gui.
Second: I used System.PrintLn at the end of the progress, and after the slot changed.

Edited January 17, 2019 by Legenes

[Legenes]

7 minutes ago, diesieben07 said:

15 minutes ago, Legenes said:

Second: I used System.PrintLn at the end of the progress, and after the slot changed.

Please clarify this.

    public void endProgress() {
	#<--- Here System.Out.PrintLn("Setting water");
        waterLevel += currentGivenWater;
        if (waterLevel > 1000)
            waterLevel = 1000;
    	#<--- Here System.Out.PrintLn("Inserting item"); (no delay)
        inventory.insertItem(4, new ItemStack(currentOutputItem, currentOutputCount), false);
        isWorking = false;
        progress = 45;
    	#<--- Here System.Out.PrintLn("Complete"); (3/5 seconds in log)
    }

 

EDIT:

7 minutes ago, diesieben07 said:

15 minutes ago, Legenes said:

Interestingly, I do. My tesr uses the block's properties to render, and if I don't send this packet, my tile won't work till' I use it. (After world load it wouldn't render the things that are set in the tile, like the progress variable. Defaultly it should be 45, but without this message it's 0)

Then the server should just send the data. There is no need for the client to request it like this.

Thanks, It's much simpler.

Edited January 17, 2019 by Legenes

[Legenes]

I made some changes, and now these things are happening at the same time. But in the gui they still show late, and if I quit the gui, then I can't rightclick the block util it finishes "updating" it.

[Legenes]

17 hours ago, diesieben07 said:

Very strange. If that is really true then only the insertItem can be the slow thing. But you say you don't have any server lag? This sounds impossible.

The way my block works is that I'm searching for an Item in my custom recipe database. As it turned out, it was crappy, and I needed to reimplement it. Now the inserting itself is not instant, but it's about a quarter second (I can't see delay in log messages), and it's okay to me.

Now I have another problem. When my tile calls onLoad(), it doesn't load any of the nbt, it only works after using the block itself.

Is there any idea what's causing it?
(P.S.: Now I save every variable into nbt.)

[Legenes]

Just now, diesieben07 said:

Please clarify this. How did you check that it "loads the nbt"? 

In the gui it only loaded the inventory, everthing else was 0.
 

 

1 minute ago, diesieben07 said:

18 minutes ago, Legenes said:

(P.S.: Now I save every variable into nbt.)

Why?

Not literally everything, but every variable that is needed to continue the progress after load. Like the furnace.

[Legenes]

OMG, Thanks! Now the insertItem part is instant, and everything works as it should. ?