Jump to content

Recommended Posts

Posted

Hey there, I'm pretty new to Java, and completely new to Minecraft modding. I've made a few little games in C# and JavaScript while puttering about, but that's not Java, and it's not modding an existing game. Anyways, I'll start with what I want to do, then move to what I presently have, and close with what I'm looking for.

 

What I want to do.

  • I'm looking to make a small client-side mod for pixelmon that checks all the TileEntities within a certain range of the player, adds them to a list, then runs through them with an iterator, comparing them to the TileEntityPokeChest class pixelmon has to whittle the list down to just PokeChests out in the world.
  • Then run through that list, using the getPos method or something similar to find the location of them in the world.
  • Afterwards using that information to create a beacon or waypoint or some other visual indicator - or just a text list - of where those are in the world.
  • Ideally, I'd love to be able to integrate it into JourneyMap instead, and use JourneyMap to create the waypoints.
  • Finally, I want to have a configurable keybind in Minecraft's Controls options to toggle it on/off

 

What I have.

  • I've got an idea of how to figure out which TileEntity is a PokeChest. I'll take a List of nearby TileEntity's, then just check if they're an instanceof TileEntityPokeChest class. From there pixelmon's TileEntityPokeChest class has a .getType method, so finding out what type of chest the TileEntity is isn't a problem.
  • Finding out where it is should also just be a case of using the getPos method in the TileEntity class from Minecraft's source code.
  • In addition to that, I also have the forge mdk properly downloaded and setup in Eclipse, as per several tutorials.
  • And finally, I've got a ModName.class in my src/main/java/modname package containing the @Mod setup and one public class with three empty Methods, preInit, init, and postInit.

 

What I'm looking for.

  • Where to go from here.
  • I'm not sure how to go about getting nearby TileEntities, I'm pretty sure I should be using the getEntitiesWithinAABB method from the World.class of Minecraft source. Something like 
    List entities = player.worldObj.getEntitiesWithinAABB(TileEntity.class, AxisAlignedBB.getBoundingBox(minX, minY, minZ, maxX, maxY, maxZ)
    But I think that'd only list Entities, not TileEntities.
  • I've looked at JourneyMap, and I see it's got a JourneyMapAPI, but I haven't had any luck finding documentation for how to use the API, nor have I had any luck understanding it myself.
  • I also don't have the slightest clue as to how I'd make a beacon or waypoint myself.
  • I'm not sure where the right place to put my code is, either. Should I be putting it below the three intialization methods I have, should I be putting it in a separate class then initializing it by calling MyClass.init() or something similar on it?
  • I'll have to check nearby TileEntities while the game's running many times, how do I make minecraft call my code repeatedly while the code's running?
  • Stuff should be called every game tick, but is there a way to change how often it's called? I wouldn't need to get a full list of all nearby TileEntities within ~200 block radius of the player every tick, so I could make it much lighter by making it check less frequently.
  • How do I go about adding a section in minecraft's Controls options for my mod? How do I make a keybind and set up a listener for it?

 

I've been thinking about this for a few days now, slowly making my way through bits and pieces, but I'm frankly a bit overwhelmed, and not really sure where to start. Some of the things I'm looking for I'm sure there's well-explained tutorials for, like adding a section to minecraft's controls options, but I'm not sure where to even put my code, so I feel like I need more of a foundation. I've been looking at several different intro tutorials but I'm still feeling utterly lost, so I thought I'd get out all my thoughts in an organized manner here and see if I could get some help sorting myself out. I'm used to making my own games and hacking something together, so I'm missing some of the basics, I'm sure, but I'd like to learn, I just need help knowing where to even start.

 

Help would be immensely appreciated!

Posted

C# is 99.5% the same as Java (syntax wise)

Forge 1.13 just came it yesterday, and it changed everything, it’s a complete rewrite of everything to do with modding. I haven’t updated my Modding skeleton to it yet, but the 1.12.2 version of it exists at https://github.com/Cadiboo/Example-Mod. I’m going to be doing some 1.13 tutorials which you’ll be able to find at https://cadiboo.github.io/tutorials/

9 minutes ago, nightstick24 said:

getEntitiesWithinAABB method from the World.class of Minecraft source. Something like 


List entities = player.worldObj.getEntitiesWithinAABB(TileEntity.class, AxisAlignedBB.getBoundingBox(minX, minY, minZ, maxX, maxY, maxZ)

But I think that'd only list Entities, not TileEntities.

 

Tile entities are completely different from entities. You can get a list of tile entires 2 ways

1) iterate over all the positions a tile entity could be at (great for small radiuss)

2) get all the tiles in a chunk

13 minutes ago, nightstick24 said:

I'll have to check nearby TileEntities while the game's running many times, how do I make minecraft call my code repeatedly while the code's running?

Subscribe to a TickEvent

13 minutes ago, nightstick24 said:

Stuff should be called every game tick, but is there a way to change how often it's called? I wouldn't need to get a full list of all nearby TileEntities within ~200 block radius of the player every tick, so I could make it much lighter by making it check less frequently.

Only run your check when world.getTotalTime() % cooldown == 0

14 minutes ago, nightstick24 said:
  • How do I go about adding a section in minecraft's Controls options for my mod? How do I make a keybind and set up a listener for it?

Create & register your keybind statically, then use the client tick event to check if yourKeyBind.isPressed()

  • Thanks 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.