[1.12.2] ItemCraftedEvent

[RoyalReject]

Here is my class:

public class Test {

	ArrayList<Item> items = new ArrayList<Item>();
	
	@SubscribeEvent
	public void onCraft(ItemCraftedEvent event) {	
		items.add(Item.getByNameOrId("minecraft:wooden_button"));
		if(!event.player.world.isRemote) {
			event.player.sendMessage(new TextComponentString("Test1"));
			if(isItemIn(event.crafting.getItem())) {
				event.player.sendMessage(new TextComponentString("Patented Item"));
				event.setCanceled(true);
			}
		}
	}
	
	public boolean isItemIn(Item item) {
		for(int i = 0; i < items.size(); i++) {
			if(items.get(i) == item) {
				return true;
			}
		}
		return false;
	}
}

I am trying to stop the crafting of an item in an arraylist, while it does cancel the event it still gives the crafting result while not using the wood leaving it in the crafting bench

[DavidM]

1. To be honest, your code is a mess.

- Use List#contains. There is no need to iterate through the list.

- You are adding the button item every crafting event, which makes no sense. If you insist to look up items based on a list, initialize the array with the desired objects.

 

2. This is not how the ItemCraftedEvent is meant to be used. Why don’t you just disable the recipe instead?

Edited February 20, 2019 by DavidM

[RoyalReject]

2 minutes ago, DavidM said:

1. To be honest, your code is a mess.

- Use List#contains. There is no need to iterate through the list.

- You are adding the button item every crafting event, which makes no sense. If you insist to look up items based on a list, initialize the array with the desired objects.

• This is for testing later will add to list in a different way.

 

2. Why don’t you just disable the recipe instead?

• because I dont wanna disable the recipe for all players just a few this is currently getting base logic down

 

Edited February 20, 2019 by RoyalReject

[DavidM]

1. Ok... That is some wild testing then.

2. AFAIK the ItemCraftedEvent happens after the event is crafted, thus canceling the event will not cancel the craft.

Edited February 20, 2019 by DavidM

[RoyalReject]

1 minute ago, DavidM said:

1. Ok... That is some wild testing then.

2. The ItemCraftedEvent happens after the event is crafted AFAIK, thus canceling the event will not cancel the craft.

one yes its weird testing but it works. and b that was my thought but it still gives me the button but does not take the wood.

[DavidM]

36 minutes ago, RoyalReject said:

it works

1. Aspects like performance, speed and coding style also counts toward the quality of the code.

I would strongly suggest you to change your code once you've done testing.

 

2. Canceling the event is not the solution you wanted. As LexManos stated here: https://github.com/MinecraftForge/MinecraftForge/issues/3780#issuecomment-286099327, the ItemCraftedEvent is designed for stuff like posting achievements. You should not try to edit the craft inside the event handler of this event.

Edited February 20, 2019 by DavidM

[RoyalReject]

2 minutes ago, DavidM said:

1. Aspects like performance, speed and coding style also counts toward the quality of the code.

I would strongly suggest you to change your code once you've done testing.

 

2. Canceling the event is not the solution you wanted.

Then how would i stop the player from crafting the items. I cannot think of anything else

[DavidM]

This?

http://www.minecraftforge.net/forum/topic/22927-player-based-crafting-recipes/

Edited February 20, 2019 by DavidM

[RoyalReject]

The issue I am is wrapping my head around how I would set it up. Basically any player will be able to "claim" a recipe. Then after that happens would disallow other players crafting whatever item they "claimed"

 

[DavidM]

Well, there are many approaches.

The easiest (probably) would be to create a

Map<Recipe, Player> // Pseudocode, adjust the types based on your code

, and set the player value to null at the beginning.

Whenever a player claims a recipe, set the value of the recipe to that player (use the player's name or something) (make the recipe claimable only if the corresponding value is null, meaning no one had claimed that recipe).

When a player tries to craft something, check if that player is the value corresponding to the recipe.

Edited February 20, 2019 by DavidM

[RoyalReject]

46 minutes ago, diesieben07 said:

ItemCraftedEvent cannot be used to cancel a recipe. In fact, there is no event which allows it.

One way is the topic linked above.

 

However there are also the new RecipeBook mechanic, which makes it so recipes are locked by default (and allows locking and unlocking recipes per player).

I just messed around with trying to lock Recipes through the book but i am still able to craft locked recipes