Jump to content

Recommended Posts

Posted

Hello, I have recently gotten into using forge for a mod I am working on and i would like to change the style of some of the game's default gui elements. These include things like the tab overlay and chat elements.

I would like to override the tab overlay specifically to display the numeric value of the player's Ping Like this example

so far i have gotten tab to display the numeric values, however  due to a reason im unsure of, the header and footer of the tab is not displayed (the areas above and below the player list - servers commonly have text displayed here)

Currently, i created a class that extended GuiPlayerTabOverlay (called GuiTabOverride), added the necessary modifications, and then called the render method inside of an event listener like so:

@SubscribeEvent
	public void overrideTab(RenderGameOverlayEvent.Pre event) {
		GuiTabOverride tab = new GuiTabOverride(mc, guiIngame);
		if(event.getType() == ElementType.PLAYER_LIST) {
			event.setCanceled(true); /** Here we disable the normal tab Element */
			Scoreboard scoreboard = this.mc.world.getScoreboard();
			 
			
			 ScaledResolution scaledresolution = new ScaledResolution(this.mc);
		        int i = scaledresolution.getScaledWidth();
		        
		            tab.renderPlayerlist(i, scoreboard, null);		            		       		
			
		}
					
		
	}

This does work, but once again, the header/footer of the tab doesn't get rendered, only the player list. Presumably it has something to do with the 3rd parameter in renderPlayerList being null since the real method is called inside GuiIngame and the 3rd parameter is the score objective. In order to fix this issue, would i have to create a class that overrides GuiIngame as well? Any help would be greatly appreciated!

Posted

so to clarify, i would have to manually set the header/footer data inside my new tab gui and use reflection to get the data from the default ones since there are only setters for the header/footer fields

 

Posted (edited)

Hey so after a few days of thinking, I am having trouble getting the value of the reflected fields.

When trying to render the tab, the game crashes and causes an IllegalArgumentException.

This is the method i used to get the value (same applies to footer) - the method is then called in renderTabOverlay in my new class

public void getHeader() {
	    	
	    	Field field;
			try {
				
				field = GuiPlayerTabOverlay.class.getDeclaredField("header");
				field.setAccessible(true);
	        this.header = (ITextComponent) field.get(this); //This is likely the problem
	        field.setAccessible(false);
			} catch (NoSuchFieldException | IllegalAccessException | SecurityException e) {
				
				e.printStackTrace();
			}
	        
	    }

Any assistance on what to fix would be appreciated - I haven't used reflection much so bear with me.

 

EDIT: I did some looking into how the header/footer text is set, which is set via packets, and the packet that handles this is called SPacketPlayerListHeaderFooter - which has getters for both of the values i need. Would it be possible to grab this packet data and use it?

Edited by -TheLittleGuy
Posted

the method ObfuscationReflectionHelper#findField wasnt present so i used ReflectionHelper#findField - maybe im using a different forge version?

Anyways i tried the following code 


static final Field head;
		static {
	    	head = ReflectionHelper.findField(GuiPlayerTabOverlay.class, "header" , "field_175256_i");
	    }
	    public void getHeader() throws IllegalArgumentException, IllegalAccessException  {
	    	tabOverlay = new GuiPlayerTabOverlay(mc, guiIngame);
	    	
	    	 this.setHeader((ITextComponent) head.get(tabOverlay));
	    	
	    }

then i called the getHeader method in the render method. No crashes, but the header still doesnt get rendered when its supposed to. Surely im missing something or calling the method in the wrong place perhaps?

Posted
1 hour ago, -TheLittleGuy said:

method ObfuscationReflectionHelper#findField wasnt present so i used ReflectionHelper#findField - maybe im using a different forge version?

Reflection helper was depreciated in Forge #2780 or something and removed completely in 1.13.2

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.