Jump to content

[1.12.2] On item right click damage entity.


Merthew

Recommended Posts

Currently I have an item, the phantom sword that gets an entity that the player is looking at. However, it should cause the entity to be damaged by an amount dependent on the sword type. This does not happen. There is no indication that the entity has been damaged and it will not kill any entity. Any help would be appreciated.

Relevant file: https://github.com/Merthew/Merthew-Mod/blob/master/src/main/java/merthew/mod/object/item/weapons/PhantomBlade.java

The seven became one and the one became two.

Link to comment
Share on other sites

1. Your switch statement for sword tier is messy. Utilize string concatenation.

2. Stop using BlockBase and ItemBase (or in your case, BlockBasic and MItem).

3. You are trying to get the player's view from the server side, which will immediately cause a crash due to the usage of Minecraft#getMinecraft. Use packets. 

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.