Posted March 3, 20196 yr I would like to be able to modify the damage source in the LivingAttackEvent. Because now i have to cancel the event and call attackEntityFrom with the new damage source. Edited July 15, 20196 yr by Meldexun
March 3, 20196 yr What’s the problem with that method? Does it not achieve the exact same thing? About Me Spoiler My Discord - Cadiboo#8887 My Website - Cadiboo.github.io My Mods - Cadiboo.github.io/projects My Tutorials - Cadiboo.github.io/tutorials Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support. When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible. Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)
March 3, 20196 yr Author I would like to make a sword with a custom damage source. It's the only way i found to achieve this. Edited March 3, 20196 yr by Meldexun
March 3, 20196 yr Is there a problem with this method though? It seems to be that you’re doing the exact same thing as changing the damage source. If you feel it’s neccesary, Forge is open source and you can make a PR to add this feature. Because of the ability to already do something very similar, I think it would be unlikely to get accepted though Edited March 3, 20196 yr by Cadiboo About Me Spoiler My Discord - Cadiboo#8887 My Website - Cadiboo.github.io My Mods - Cadiboo.github.io/projects My Tutorials - Cadiboo.github.io/tutorials Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support. When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible. Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)
March 3, 20196 yr Author Yes it's doing the same thing but the method attackEntityFrom is called twice and also the LivingAttackEvent. It's working but it's a bit redundant code. Edited March 3, 20196 yr by Meldexun
March 3, 20196 yr 1 minute ago, Meldexun said: it's a bit redundant Welcome to Minecraft ? About Me Spoiler My Discord - Cadiboo#8887 My Website - Cadiboo.github.io My Mods - Cadiboo.github.io/projects My Tutorials - Cadiboo.github.io/tutorials Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support. When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible. Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)
March 3, 20196 yr Author I don't know that much about programming and so i don't know how Minecraft is coded. But i heard that it's bad coded. I atleast try to make my mods as good as possible. Hoped Forge at least tries to do the same.
March 3, 20196 yr 11 minutes ago, Cadiboo said: If you feel it’s neccesary, Forge is open source and you can make a PR to add this feature. Your change to the event sounds useful, if you make a good use case, then there’s a good chance that it will be accepted. Parts of minecraft are badly done, but there are mods to rectify this, and large parts of the engine are being rewritten (and some parts are being open/visible sourced) in 1.13+. About Me Spoiler My Discord - Cadiboo#8887 My Website - Cadiboo.github.io My Mods - Cadiboo.github.io/projects My Tutorials - Cadiboo.github.io/tutorials Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support. When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible. Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)
March 3, 20196 yr Author 22 minutes ago, Cadiboo said: you can make a PR to add this feature Im sorry but can you explain me what a PR is?
March 3, 20196 yr A PR or Pull Request is you writing the code for a feature you want, and it potentially getting accepted into Forge. https://mcforge.readthedocs.io/en/latest/forgedev/ About Me Spoiler My Discord - Cadiboo#8887 My Website - Cadiboo.github.io My Mods - Cadiboo.github.io/projects My Tutorials - Cadiboo.github.io/tutorials Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support. When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible. Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.