[Solved] [1.12.2] Block Item Texture Missing

[dogtreat268]

I recently started to get into modding, and was adding some new stairs. The texture in world works fine, but in the player inventory it will not show up. I think the problem is the json files.

 

I've tried using minecraft's json files, json files from tutorials, and deleting and re-making them. Nothing seems to work, any help would be much appreciated. 

 

Code: https://github.com/dogtreat268/Middle_Earth.1.12.2-0.0.1.0

 

Log: 

[21:56:54] [main/INFO] [GradleStart]: username: dogtreat268
[21:56:54] [main/INFO] [GradleStart]: Extra: []
[21:56:54] [main/INFO] [GradleStart]: Running with arguments: [--userProperties, {}, --assetsDir, /Users/connorgilliom/.gradle/caches/minecraft/assets, --assetIndex, 1.12, --accessToken{REDACTED}, --version, 1.12.2, --username, dogtreat268, --tweakClass, net.minecraftforge.fml.common.launcher.FMLTweaker, --tweakClass, net.minecraftforge.gradle.tweakers.CoremodTweaker]
[21:56:54] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker
[21:56:54] [main/INFO] [LaunchWrapper]: Using primary tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker
[21:56:54] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.gradle.tweakers.CoremodTweaker
[21:56:54] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLTweaker
[21:56:54] [main/INFO] [FML]: Forge Mod Loader version 14.23.5.2768 for Minecraft 1.12.2 loading
[21:56:54] [main/INFO] [FML]: Java is Java HotSpot(TM) 64-Bit Server VM, version 1.8.0_131, running on Mac OS X:x86_64:10.12.6, installed at /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/jre
[21:56:54] [main/ERROR] [FML]: Apache Maven library folder was not in the format expected. Using default libraries directory.
[21:56:54] [main/ERROR] [FML]: Full: /Users/connorgilliom/.gradle/caches/modules-2/files-2.1/org.apache.maven/maven-artifact/3.5.3/7dc72b6d6d8a6dced3d294ed54c2cc3515ade9f4/maven-artifact-3.5.3.jar
[21:56:54] [main/ERROR] [FML]: Trimmed: /users/connorgilliom/.gradle/caches/modules-2/files-2.1/org.apache.maven/maven-artifact/3.5.3/
[21:56:54] [main/INFO] [FML]: Managed to load a deobfuscated Minecraft name- we are in a deobfuscated environment. Skipping runtime deobfuscation
[21:56:54] [main/INFO] [FML]: Detected deobfuscated environment, loading log configs for colored console logs.
[21:56:55] [main/INFO] [FML]: Ignoring missing certificate for coremod FMLCorePlugin (net.minecraftforge.fml.relauncher.FMLCorePlugin), we are in deobf and it's a forge core plugin
[21:56:55] [main/INFO] [FML]: Ignoring missing certificate for coremod FMLForgePlugin (net.minecraftforge.classloading.FMLForgePlugin), we are in deobf and it's a forge core plugin
[21:56:55] [main/INFO] [FML]: Searching /Users/connorgilliom/Developer/Middle_Earth.1.12.2-0.0.1.0/run/./mods for mods
[21:56:55] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.gradle.tweakers.CoremodTweaker
[21:56:55] [main/INFO] [GradleStart]: Injecting location in coremod net.minecraftforge.fml.relauncher.FMLCorePlugin
[21:56:55] [main/INFO] [GradleStart]: Injecting location in coremod net.minecraftforge.classloading.FMLForgePlugin
[21:56:55] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLInjectionAndSortingTweaker
[21:56:55] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLDeobfTweaker
[21:56:55] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.gradle.tweakers.AccessTransformerTweaker
[21:56:55] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLInjectionAndSortingTweaker
[21:56:55] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLInjectionAndSortingTweaker
[21:56:55] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.relauncher.CoreModManager$FMLPluginWrapper
[21:56:57] [main/ERROR] [FML]: FML appears to be missing any signature data. This is not a good thing
[21:56:57] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.relauncher.CoreModManager$FMLPluginWrapper
[21:56:57] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLDeobfTweaker
[21:56:57] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.gradle.tweakers.AccessTransformerTweaker
[21:56:57] [main/INFO] [LaunchWrapper]: Loading tweak class name net.minecraftforge.fml.common.launcher.TerminalTweaker
[21:56:57] [main/INFO] [LaunchWrapper]: Calling tweak class net.minecraftforge.fml.common.launcher.TerminalTweaker
[21:56:57] [main/INFO] [LaunchWrapper]: Launching wrapped minecraft {net.minecraft.client.main.Main}
[21:56:58] [main/INFO] [net.minecraft.client.Minecraft]: Setting user: dogtreat268
[21:57:01] [main/WARN] [net.minecraft.client.settings.GameSettings]: Skipping bad option: lastServer:
[21:57:01] [main/INFO] [net.minecraft.client.Minecraft]: LWJGL Version: 2.9.2
[21:57:01] [main/INFO] [FML]: -- System Details --
Details:
	Minecraft Version: 1.12.2
	Operating System: Mac OS X (x86_64) version 10.12.6
	Java Version: 1.8.0_131, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 242757936 bytes (231 MB) / 395837440 bytes (377 MB) up to 1908932608 bytes (1820 MB)
	JVM Flags: 0 total; 
	IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
	FML: 
	Loaded coremods (and transformers): 
	GL info: ' Vendor: 'Intel Inc.' Version: '2.1 INTEL-10.25.22' Renderer: 'Intel(R) Iris(TM) Graphics 540'
[21:57:01] [main/INFO] [FML]: MinecraftForge v14.23.5.2768 Initialized
[21:57:01] [main/INFO] [FML]: Starts to replace vanilla recipe ingredients with ore ingredients.
[21:57:01] [main/INFO] [FML]: Replaced 1036 ore ingredients
[21:57:02] [main/INFO] [FML]: Searching /Users/connorgilliom/Developer/Middle_Earth.1.12.2-0.0.1.0/run/./mods for mods
[21:57:03] [main/INFO] [FML]: Forge Mod Loader has identified 5 mods to load
[21:57:04] [Thread-3/INFO] [FML]: Using sync timing. 200 frames of Display.update took 628735525 nanos
[21:57:04] [main/INFO] [FML]: Attempting connection with missing mods [minecraft, mcp, FML, forge, middle_earth_mod] at CLIENT
[21:57:04] [main/INFO] [FML]: Attempting connection with missing mods [minecraft, mcp, FML, forge, middle_earth_mod] at SERVER
[21:57:05] [main/INFO] [net.minecraft.client.resources.SimpleReloadableResourceManager]: Reloading ResourceManager: Default, FMLFileResourcePack:Forge Mod Loader, FMLFileResourcePack:Minecraft Forge, FMLFileResourcePack:Middle Earth
[21:57:05] [main/INFO] [FML]: Processing ObjectHolder annotations
[21:57:05] [main/INFO] [FML]: Found 1168 ObjectHolder annotations
[21:57:05] [main/INFO] [FML]: Identifying ItemStackHolder annotations
[21:57:05] [main/INFO] [FML]: Found 0 ItemStackHolder annotations
[21:57:05] [main/INFO] [FML]: Configured a dormant chunk cache size of 0
[21:57:05] [Forge Version Check/INFO] [forge.VersionCheck]: [forge] Starting version check at http://files.minecraftforge.net/maven/net/minecraftforge/forge/promotions_slim.json
[21:57:05] [main/INFO] [FML]: Applying holder lookups
[21:57:05] [main/INFO] [FML]: Holder lookups applied
[21:57:05] [main/INFO] [FML]: Applying holder lookups
[21:57:05] [main/INFO] [FML]: Holder lookups applied
[21:57:05] [main/INFO] [FML]: Applying holder lookups
[21:57:05] [main/INFO] [FML]: Holder lookups applied
[21:57:05] [main/INFO] [FML]: Applying holder lookups
[21:57:05] [main/INFO] [FML]: Holder lookups applied
[21:57:05] [main/INFO] [FML]: Injecting itemstacks
[21:57:05] [main/INFO] [FML]: Itemstack injection complete
[21:57:06] [Forge Version Check/INFO] [forge.VersionCheck]: [forge] Found status: UP_TO_DATE Target: null
[21:57:07] [Sound Library Loader/INFO] [net.minecraft.client.audio.SoundManager]: Starting up SoundSystem...
[21:57:07] [Thread-4/INFO] [net.minecraft.client.audio.SoundManager]: Initializing LWJGL OpenAL
[21:57:07] [Thread-4/INFO] [net.minecraft.client.audio.SoundManager]: (The LWJGL binding of OpenAL.  For more information, see http://www.lwjgl.org)
[21:57:07] [Thread-4/INFO] [net.minecraft.client.audio.SoundManager]: OpenAL initialized.
[21:57:08] [Sound Library Loader/INFO] [net.minecraft.client.audio.SoundManager]: Sound engine started
[21:57:11] [main/INFO] [FML]: Max texture size: 16384
[21:57:11] [main/INFO] [net.minecraft.client.renderer.texture.TextureMap]: Created: 512x512 textures-atlas
[21:57:13] [main/INFO] [FML]: Applying holder lookups
[21:57:13] [main/INFO] [FML]: Holder lookups applied
[21:57:13] [main/INFO] [FML]: Injecting itemstacks
[21:57:13] [main/INFO] [FML]: Itemstack injection complete
[21:57:13] [main/INFO] [FML]: Forge Mod Loader has successfully loaded 5 mods
[21:57:13] [main/WARN] [net.minecraft.client.settings.GameSettings]: Skipping bad option: lastServer:
[21:57:15] [Realms Notification Availability checker #1/INFO] [com.mojang.realmsclient.client.RealmsClient]: Could not authorize you against Realms server: Invalid session id
[21:57:37] [Server thread/INFO] [net.minecraft.server.integrated.IntegratedServer]: Starting integrated minecraft server version 1.12.2
[21:57:37] [Server thread/INFO] [net.minecraft.server.integrated.IntegratedServer]: Generating keypair
[21:57:37] [Server thread/INFO] [FML]: Injecting existing registry data into this server instance
[21:57:38] [Server thread/INFO] [FML]: Applying holder lookups
[21:57:38] [Server thread/INFO] [FML]: Holder lookups applied
[21:57:38] [Server thread/INFO] [FML]: Loading dimension 0 (New World) (net.minecraft.server.integrated.IntegratedServer@6719947)
[21:57:38] [Server thread/INFO] [net.minecraft.advancements.AdvancementList]: Loaded 488 advancements
[21:57:39] [Server thread/INFO] [FML]: Loading dimension -1 (New World) (net.minecraft.server.integrated.IntegratedServer@6719947)
[21:57:39] [Server thread/INFO] [FML]: Loading dimension 1 (New World) (net.minecraft.server.integrated.IntegratedServer@6719947)
[21:57:39] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: Preparing start region for level 0
[21:57:39] [Server thread/INFO] [FML]: Unloading dimension -1
[21:57:39] [Server thread/INFO] [FML]: Unloading dimension 1
[21:57:39] [Server thread/INFO] [net.minecraft.server.integrated.IntegratedServer]: Changing view distance to 12, from 10
[21:57:41] [Netty Local Client IO #0/INFO] [FML]: Server protocol version 2
[21:57:41] [Netty Server IO #1/INFO] [FML]: Client protocol version 2
[21:57:41] [Netty Server IO #1/INFO] [FML]: Client attempting to join with 5 mods : [email protected],[email protected],[email protected],[email protected],[email protected]
[21:57:41] [Netty Local Client IO #0/INFO] [FML]: [Netty Local Client IO #0] Client side modded connection established
[21:57:41] [Server thread/INFO] [FML]: [Server thread] Server side modded connection established
[21:57:41] [Server thread/INFO] [net.minecraft.server.management.PlayerList]: dogtreat268[local:E:a8e42d1a] logged in with entity id 0 at (-910.5, 4.0, -650.5)
[21:57:41] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: dogtreat268 joined the game
[21:57:43] [Server thread/INFO] [net.minecraft.server.integrated.IntegratedServer]: Saving and pausing game...
[21:57:43] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: Saving chunks for level 'New World'/overworld
[21:57:43] [pool-2-thread-1/WARN] [com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService]: Couldn't look up profile properties for com.mojang.authlib.GameProfile@308ea1a0[id=6c9e4f10-8e44-3211-8af3-09b9a5aae1f7,name=dogtreat268,properties={},legacy=false]
com.mojang.authlib.exceptions.AuthenticationException: The client has sent too many requests within a certain amount of time
	at com.mojang.authlib.yggdrasil.YggdrasilAuthenticationService.makeRequest(YggdrasilAuthenticationService.java:79) ~[YggdrasilAuthenticationService.class:?]
	at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService.fillGameProfile(YggdrasilMinecraftSessionService.java:180) [YggdrasilMinecraftSessionService.class:?]
	at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService$1.load(YggdrasilMinecraftSessionService.java:60) [YggdrasilMinecraftSessionService$1.class:?]
	at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService$1.load(YggdrasilMinecraftSessionService.java:57) [YggdrasilMinecraftSessionService$1.class:?]
	at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3716) [guava-21.0.jar:?]
	at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2424) [guava-21.0.jar:?]
	at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2298) [guava-21.0.jar:?]
	at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2211) [guava-21.0.jar:?]
	at com.google.common.cache.LocalCache.get(LocalCache.java:4154) [guava-21.0.jar:?]
	at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:4158) [guava-21.0.jar:?]
	at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:5147) [guava-21.0.jar:?]
	at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:5153) [guava-21.0.jar:?]
	at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService.fillProfileProperties(YggdrasilMinecraftSessionService.java:170) [YggdrasilMinecraftSessionService.class:?]
	at net.minecraft.client.Minecraft.getProfileProperties(Minecraft.java:3181) [Minecraft.class:?]
	at net.minecraft.client.resources.SkinManager$3.run(SkinManager.java:138) [SkinManager$3.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_131]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_131]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_131]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_131]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_131]
[21:57:51] [Server thread/INFO] [net.minecraft.server.integrated.IntegratedServer]: Saving and pausing game...
[21:57:51] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: Saving chunks for level 'New World'/overworld
[22:02:51] [Server thread/INFO] [net.minecraft.server.integrated.IntegratedServer]: Saving and pausing game...
[22:02:51] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: Saving chunks for level 'New World'/overworld
[22:04:53] [main/INFO] [net.minecraft.client.Minecraft]: Stopping!
[22:04:53] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: Stopping server
[22:04:53] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: Saving players
[22:04:53] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: Saving worlds
[22:04:53] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: Saving chunks for level 'New World'/overworld
[22:04:53] [Server thread/INFO] [FML]: Unloading dimension 0
[22:04:53] [Server thread/INFO] [FML]: Applying holder lookups
[22:04:53] [Server thread/INFO] [FML]: Holder lookups applied
[22:04:53] [main/INFO] [net.minecraft.client.audio.SoundManager]: SoundSystem shutting down...
[22:04:53] [main/WARN] [net.minecraft.client.audio.SoundManager]: Author: Paul Lamb, www.paulscode.com

 

Thanks!

latest.log

Edited March 8, 2019 by dogtreat268
Solved

[DavidM]

1. Post your log.

2. Stop using ItemBase or BlockBase. These are terrible practices taught by poor tutorials.

3. Clean up your repo with .gitignore.

Edited March 8, 2019 by DavidM

[dogtreat268]

Ok, added it

[DavidM]

Alright. Your code is... a mess. I blame the poor and misleading tutorial that you are following.

There are a lot of repetition in your code, especially in your BlockBase, which might led to repeated registration.

In addition, there are a lot of unnecessary code, as well as purposeless interfaces and helper classes.

I would suggest you to rewrite your mod (only the java part, everything in your resources folder is fine) and follow a better tutorial.

 

As for your texture problem:

This is a great example of why you shouldn't be using IHasModel, BlockBase, and ItemBase.

Your stair block extended BlockStair, which is normal. However, since your model registry handler only register the models of those which implement IHasModel, the model of your stair block isn't registered at all.

 

Fixes:

The fast way (and wrong way, but it would work): make your stairs implement IHasModel.

The correct way: Ditch the (terrible) tutorial you are following, start everything from scratch, and register items, blocks, and models the proper way.

Here's a good text-based tutorial for reference: https://github.com/TheGreyGhost/MinecraftByExample/

Edited March 8, 2019 by DavidM

[dogtreat268]

Alright thanks, wasn't sure where to find a good tutorial I'll try that one. Thanks for your help

[Laike_Endaril]

And here is a minimal patch with replacement files that will load the texture.

 

These changes were applied to the "initial commit" version of your online repo (in case your current project does not match said commit).

 

Batteries and correctness sold separately!  But you may find it useful for reference.  It would probably still be a good idea to go through your entire project over again as David said.

Middle_Earth.1.12.2-0.0.1.0-patch.zip

Edited March 8, 2019 by Laike_Endaril

[dogtreat268]

Thanks for your help! I'm planning on redoing it rather than starting with a bad base. Thanks again!