Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.12.2] [Solved] Trying to understand (Fast)TESR

ProspectPyxis

By ProspectPyxis
in Modder Support

 Share

Recommended Posts

ProspectPyxis Tree Puncher

ProspectPyxis

Posted
Posted (edited)

So this is a bit of a follow up to my previous topic - I'm currently trying to use a FastTESR to render a tile entity that stores its color. I can't really find any pointers on how to use it, though - trying to follow a code example I found just...made it break horribly, as you can see in the attached image.
Here's the relevant code that I'm using, can anyone give some pointers on what I'm doing wrong?

FastTESR class:

Spoiler 

package prospectpyxis.customcapacitors.client.render;

import net.minecraft.block.state.IBlockState;
import net.minecraft.client.renderer.BufferBuilder;
import net.minecraft.client.renderer.texture.TextureAtlasSprite;
import net.minecraftforge.client.model.animation.FastTESR;
import prospectpyxis.customcapacitors.block.BlockCapacitor;
import prospectpyxis.customcapacitors.block.tile.TileEntityCapacitor;
import prospectpyxis.customcapacitors.proxy.ClientProxy;

import java.awt.*;

public class TESRCapacitor extends FastTESR<TileEntityCapacitor> {

    @Override
    public void renderTileEntityFast(TileEntityCapacitor tec, double x, double y, double z, float partialTicks, int destroyStage, float partial, BufferBuilder buffer) {
        buffer.setTranslation(x, y, z);

        IBlockState state = tec.getWorld().getBlockState(tec.getPos());

        Color cb = new Color(tec.data.getColorBase(), false);
        Color ct = new Color(tec.data.getColorTrim(), false);

        createNewLayer(tec, ClientProxy.ctexBase, cb.getRed(), cb.getBlue(), cb.getGreen(), buffer);
        createNewLayer(tec, ClientProxy.ctexTrim, ct.getRed(), ct.getBlue(), ct.getGreen(), buffer);

        switch (state.getValue(BlockCapacitor.FACING)) {
            case DOWN:
                buffer.pos(1, 0, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(0, 0, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(0, 0, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                buffer.pos(1, 0, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                break;
            case UP:
                buffer.pos(1, 0, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(0, 0, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(0, 0, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                buffer.pos(1, 0, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                break;
            case NORTH:
                buffer.pos(0, 1, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(1, 1, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(1, 0, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                buffer.pos(0, 0, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                break;
            case SOUTH:
                buffer.pos(1, 1, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(0, 1, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(0, 0, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                buffer.pos(1, 0, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                break;
            case WEST:
                buffer.pos(0, 1, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(0, 1, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(0, 0, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                buffer.pos(0, 0, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                break;
            case EAST:
                buffer.pos(1, 1, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(1, 1, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMaxV()).endVertex();
                buffer.pos(1, 0, 1).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMaxU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                buffer.pos(1, 0, 0).color(255, 255, 255, 255)
                        .tex(ClientProxy.ctexOverlayO.getMinU(), ClientProxy.ctexOverlayO.getMinV()).endVertex();
                break;
            default:
        }

    }

    public void createNewLayer(TileEntityCapacitor tec, TextureAtlasSprite tas, int r, int g, int b, BufferBuilder buffer) {
        // DOWN
        buffer.pos(1, 0, 1).color(r, g, b, 255).tex(tas.getMinU(), tas.getMaxV()).endVertex();
        buffer.pos(0, 0, 1).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMaxV()).endVertex();
        buffer.pos(0, 0, 0).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMinV()).endVertex();
        buffer.pos(1, 0, 0).color(r, g, b, 255).tex(tas.getMinU(), tas.getMinV()).endVertex();

        // UP
        buffer.pos(1, 1, 0).color(r, g, b, 255).tex(tas.getMinU(), tas.getMaxV()).endVertex();
        buffer.pos(0, 1, 0).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMaxV()).endVertex();
        buffer.pos(0, 1, 1).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMinV()).endVertex();
        buffer.pos(1, 1, 1).color(r, g, b, 255).tex(tas.getMinU(), tas.getMinV()).endVertex();

        // NORTH
        buffer.pos(0, 1, 0).color(r, g, b, 255).tex(tas.getMinU(), tas.getMaxV()).endVertex();
        buffer.pos(1, 1, 0).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMaxV()).endVertex();
        buffer.pos(1, 0, 0).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMinV()).endVertex();
        buffer.pos(0, 0, 0).color(r, g, b, 255).tex(tas.getMinU(), tas.getMinV()).endVertex();

        // SOUTH
        buffer.pos(1, 1, 1).color(r, g, b, 255).tex(tas.getMinU(), tas.getMaxV()).endVertex();
        buffer.pos(0, 1, 1).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMaxV()).endVertex();
        buffer.pos(0, 0, 1).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMinV()).endVertex();
        buffer.pos(1, 0, 1).color(r, g, b, 255).tex(tas.getMinU(), tas.getMinV()).endVertex();

        // WEST
        buffer.pos(0, 1, 1).color(r, g, b, 255).tex(tas.getMinU(), tas.getMaxV()).endVertex();
        buffer.pos(0, 1, 0).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMaxV()).endVertex();
        buffer.pos(0, 0, 0).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMinV()).endVertex();
        buffer.pos(0, 0, 1).color(r, g, b, 255).tex(tas.getMinU(), tas.getMinV()).endVertex();

        // EAST
        buffer.pos(1, 1, 0).color(r, g, b, 255).tex(tas.getMinU(), tas.getMaxV()).endVertex();
        buffer.pos(1, 1, 1).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMaxV()).endVertex();
        buffer.pos(1, 0, 1).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMinV()).endVertex();
        buffer.pos(1, 0, 0).color(r, g, b, 255).tex(tas.getMinU(), tas.getMinV()).endVertex();
    }
}

 

ClientProxy where the textures are registered:

Spoiler 

package prospectpyxis.customcapacitors.proxy;

import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.client.renderer.texture.TextureAtlasSprite;
import net.minecraft.item.Item;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.event.TextureStitchEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import prospectpyxis.customcapacitors.CustomCapacitors;

@Mod.EventBusSubscriber
public class ClientProxy extends CommonProxy {

    @Override
    public void registerItemRenderer(Item item, int meta, String id) {
        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(CustomCapacitors.modid + ":" + id, "inventory"));
    }

    public static TextureAtlasSprite ctexBase;
    public static TextureAtlasSprite ctexTrim;
    public static TextureAtlasSprite ctexOverlay;
    public static TextureAtlasSprite ctexOverlayO;

    @SubscribeEvent
    public static void registerTextureStitch(TextureStitchEvent.Pre event) {
        if (event.getMap() == Minecraft.getMinecraft().getTextureMapBlocks()) {
            ctexBase = event.getMap().registerSprite(new ResourceLocation(CustomCapacitors.modid + ":blocks/capacitor_base"));
            ctexTrim = event.getMap().registerSprite(new ResourceLocation(CustomCapacitors.modid + ":blocks/capacitor_trim"));
            ctexOverlay = event.getMap().registerSprite(new ResourceLocation(CustomCapacitors.modid + ":blocks/capacitor_overlay"));
            ctexOverlayO = event.getMap().registerSprite(new ResourceLocation(CustomCapacitors.modid + ":blocks/capacitor_overlay_output"));
        }
    }
}

 

TileEntity class:

Spoiler 

package prospectpyxis.customcapacitors.block.tile;

import com.google.common.collect.ImmutableMap;
import net.minecraft.block.state.IBlockState;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.ITickable;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.energy.CapabilityEnergy;
import prospectpyxis.customcapacitors.CustomCapacitors;
import prospectpyxis.customcapacitors.block.BlockCapacitor;
import prospectpyxis.customcapacitors.data.CapacitorData;
import prospectpyxis.customcapacitors.registry.CapacitorRegistry;
import prospectpyxis.pyxislib.energy.EnergyManager;

import javax.annotation.Nullable;

public class TileEntityCapacitor extends TileEntity implements ITickable {

    public CapacitorData data = new CapacitorData();

    public EnergyManager eContainer = new EnergyManager(0, 0);
    public EnergyManager eReceiver = new EnergyManager(0, 0);
    public EnergyManager eExtractor = new EnergyManager(0, 0);
    @Override
    public void update() {
        if (world.getTotalWorldTime() % data.storageLossData.lossDelay == 0) {
            int minThreshold = data.storageLossData.minThreshold == -1 ? 0 : data.storageLossData.minThreshold;
            int maxThreshold = data.storageLossData.maxThreshold == -1 ? eContainer.getMaxEnergyStored() + 1 : data.storageLossData.minThreshold;
            if (data.storageLossType != CapacitorData.EnumLossType.NONE && eContainer.getEnergyStored() >= minThreshold && eContainer.getEnergyStored() < maxThreshold) {
                switch (data.storageLossType) {
                    case CONSTANT:
                        eContainer.extractEnergy((int) Math.floor(data.storageLossData.lossValue), false);
                        break;
                    case PERCENTAGE:
                        eContainer.extractEnergy(Math.round(eContainer.getEnergyStored() * data.storageLossData.lossValue), false);
                        break;
                    case PERCENTAGE_INVERTED:
                        eContainer.extractEnergy(Math.round
                                ((eContainer.getMaxEnergyStored() - eContainer.getEnergyStored()) * data.storageLossData.lossValue), false);
                        break;
                    default:
                }
            }
        }

        ImmutableMap blockProperties = world.getBlockState(pos).getProperties();
        if (blockProperties.containsKey(BlockCapacitor.FACING)) {
            EnumFacing fc = (EnumFacing)blockProperties.get(BlockCapacitor.FACING);
                TileEntity te = world.getTileEntity(pos.offset(fc));
                if (te != null && te.hasCapability(CapabilityEnergy.ENERGY, fc.getOpposite())) {
                    te.getCapability(CapabilityEnergy.ENERGY, fc.getOpposite())
                            .receiveEnergy(eExtractor.extractEnergy(data.maxOutputRate, false), false);
                }
        }
    }

    @Override
    public boolean hasFastRenderer() {
        return true;
    }

    @Override
    public boolean hasCapability(Capability<?> capability, EnumFacing facing)
    {
        if (capability == CapabilityEnergy.ENERGY) {
            return true;
        }
        return super.hasCapability(capability, facing);
    }

    @Nullable
    @SuppressWarnings("unchecked")
    @Override
    public <T> T getCapability(Capability<T> capability, @Nullable EnumFacing facing) {
        if (capability == CapabilityEnergy.ENERGY) {
            if (facing == null) return (T)eContainer;
            ImmutableMap blockProperties = world.getBlockState(pos).getProperties();
            if (blockProperties.containsKey(BlockCapacitor.FACING)) {
                if (facing.equals(blockProperties.get(BlockCapacitor.FACING))) {
                    return (T)eExtractor;
                }
                else return (T)eReceiver;
            }
        }
        return super.getCapability(capability, facing);
    }

    @Override
    public boolean shouldRefresh(World world, BlockPos pos, IBlockState oldState, IBlockState newState)
    {
        return (oldState.getBlock() != newState.getBlock());
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        compound.setInteger("energy", eContainer.getEnergyStored());
        compound.setString("capid", data.id);
        return super.writeToNBT(compound);
    }

    @Override
    public void readFromNBT(NBTTagCompound compound) {
        data = CapacitorRegistry.getDataById(compound.getString("capid")) == null ? new CapacitorData() : CapacitorRegistry.getDataById(compound.getString("capid"));

        if (data != null) {
            if (data.storageLossData.lossDelay < 1) {
                data.storageLossData.lossDelay = 1;
                CustomCapacitors.logger.warn("Warning! Capacitor " + data.id + " has less than 1 loss delay!");
                CustomCapacitors.logger.warn("It will be set to 1, please change the loss delay to a positive number!");
            }

            eContainer = new EnergyManager(data.capacity, data.maxInputRate, data.maxOutputRate) {
                @Override
                public int receiveEnergy(int maxReceive, boolean simulate) {
                    switch (data.inputLossType) {
                        case CONSTANT:
                            maxReceive = maxReceive - (int) Math.floor(data.inputLossValue);
                            break;
                        case PERCENTAGE:
                            maxReceive = maxReceive - Math.round(maxReceive * data.inputLossValue);
                            break;
                        case PERCENTAGE_INVERTED:
                            maxReceive = maxReceive - (int) ((this.maxReceive - maxReceive) * data.inputLossValue);
                            break;
                        default:
                    }
                    return super.receiveEnergy(maxReceive, simulate);
                }
            };

            eReceiver = new EnergyManager(0, data.maxInputRate) {
                @Override
                public boolean canExtract() {
                    return false;
                }

                @Override
                public int receiveEnergy(int maxReceive, boolean simulate) {
                    return eContainer.receiveEnergy(maxReceive, simulate);
                }
            };

            eExtractor = new EnergyManager(0, data.maxOutputRate) {
                @Override
                public boolean canReceive() {
                    return false;
                }

                @Override
                public int extractEnergy(int maxExtract, boolean simulate) {
                    return eContainer.extractEnergy(maxExtract, simulate);
                }
            };
        }

        eContainer.setEnergy(compound.getInteger("energy"));

        super.readFromNBT(compound);
    }
}

 

 

javaw_2019-03-19_22-44-01.png

Edited by ProspectPyxis
Cadiboo Reality Controller

Cadiboo

Posted
Posted
14 hours ago, ProspectPyxis said:

buffer.pos(1, 0, 1).color(255, 255, 255, 255)

I think that you’re 1) drawing at block pos (1, 0, 1) instead of the actual pos and 2) not adding all the elements of your vertex. 

 

Example of FastTESR: https://github.com/Cadiboo/Example-Mod/blob/master/src/main/java/io/github/cadiboo/examplemod/client/render/tileentity/RenderExampleTileEntity.java

Example of using the BufferBuilder to render faces (might not be what you want to achieve, but it’s useful for seeing the parameters and uses of them).

https://github.com/Cadiboo/NoCubes/blob/cb5ece4525faba7e44a3bb4bbb80328848c11647/src/main/java/io/github/cadiboo/nocubes/client/render/MeshRenderer.java#L385 

About Me

Spoiler

My Discord - Cadiboo#8887

My Website - Cadiboo.github.io

My Mods - Cadiboo.github.io/projects

My Tutorials - Cadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

ProspectPyxis Tree Puncher

ProspectPyxis

Posted
  • Author
Posted

So from what I can understand from the code you sent, one square face of a block is equal to four vertices. I don't really know what I'm doing wrong, though, since I already translated the buffer in the first line of renderTileEntityFast - do I need to add an offset to the pos as well?
Also, is a lightmap value absolutely required? It seems to be used in all the code you've sent me but I don't fully understand what it does.

Cadiboo Reality Controller

Cadiboo

Posted
Posted (edited)
On 3/22/2019 at 8:17 PM, ProspectPyxis said:

I already translated the buffer in the first line of renderTileEntityFast

That would be your problem. All FastTESRs are given the same buffer that is already setup properly.

On 3/22/2019 at 8:17 PM, ProspectPyxis said:

do I need to add an offset to the pos as well?

You need to draw at the position, currently you’re drawing near 0, 0, 0

On 3/22/2019 at 8:17 PM, ProspectPyxis said:

Also, is a lightmap value absolutely required? It seems to be used in all the code you've sent me but I don't fully understand what it does.

Yes. The vertex format BLOCK requires a lightmap. Lightmap values are from 0-240 with 240 being max brightness. You can use IBlockState#getPackedLightmapCoords to get packed coordinates. You can then use packed >> 16 & 0xFFFF to get the skylight which is stored in the upper bytes and packed & 0xFFFF to get the block light which is stored in the lower bytes.

 

You might want to look at https://github.com/Cadiboo/Example-Mod/blob/5fe80fde8a41cd571593c02897b06b5822e9a738/src/main/java/io/github/cadiboo/examplemod/client/ClientUtil.java#L240 as it is very well commented. Also note the offset (x, y, z) that is added to the quad in the renderFast method. 

Edited by Cadiboo
  • Like 1

About Me

Spoiler

My Discord - Cadiboo#8887

My Website - Cadiboo.github.io

My Mods - Cadiboo.github.io/projects

My Tutorials - Cadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

ProspectPyxis Tree Puncher

ProspectPyxis

Posted
  • Author
Posted (edited)

Alright, so adding a lightmap value actually got rid of the weird stretching, but now I have a couple new problems, as you can see in the image here:

Spoiler

image.png.56e5a8b6e8260334a29c5ed9ad6026e7.png

(Ignore the transparency issue, the block is supposed to be a full block either way)

  1. The texture is completely dark.
  2. The texture doesn't fully fill the outline of the blockstate texture - you can see the empty gaps in the image.

How would I fix this? The new TESR code is here (I'm only testing for one face for now so I removed a massive chunk of the code):

Spoiler 

package prospectpyxis.customcapacitors.client.render;

import net.minecraft.block.state.IBlockState;
import net.minecraft.client.renderer.BufferBuilder;
import net.minecraft.client.renderer.texture.TextureAtlasSprite;
import net.minecraftforge.client.model.animation.FastTESR;
import org.lwjgl.util.vector.Vector3f;
import prospectpyxis.customcapacitors.block.BlockCapacitor;
import prospectpyxis.customcapacitors.block.tile.TileEntityCapacitor;
import prospectpyxis.customcapacitors.proxy.ClientProxy;

import java.awt.*;

public class TESRCapacitor extends FastTESR<TileEntityCapacitor> {

    @Override
    public void renderTileEntityFast(TileEntityCapacitor tec, double x, double y, double z, float partialTicks, int destroyStage, float partial, BufferBuilder buffer) {

        IBlockState state = tec.getWorld().getBlockState(tec.getPos());

        Color cb = new Color(tec.data.getColorBase(), false);
        Color ct = new Color(tec.data.getColorTrim(), false);

        createNewLayer(tec, state, new Vector3f((float)x, (float)y, (float)z), ClientProxy.ctexBase, cb.getRed(), cb.getBlue(), cb.getGreen(), buffer);
    }

    public void createNewLayer(TileEntityCapacitor tec, IBlockState state, Vector3f offset, TextureAtlasSprite tas, int r, int g, int b, BufferBuilder buffer) {

        int blocklight = (state.getPackedLightmapCoords(tec.getWorld(), tec.getPos())) & 0xFFFF;
        int skylight = (state.getPackedLightmapCoords(tec.getWorld(), tec.getPos())) >> 16 & 0xFFFF;

        buffer.pos(offset.x + 0, offset.y + 0, offset.z + 0).color(r, g, b, 255).tex(tas.getMinU(), tas.getMaxV()).lightmap(skylight, blocklight).endVertex();
        buffer.pos(offset.x + 1, offset.y + 0, offset.z + 0).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMaxV()).lightmap(skylight, blocklight).endVertex();
        buffer.pos(offset.x + 1, offset.y + 1, offset.z + 0).color(r, g, b, 255).tex(tas.getMaxU(), tas.getMinV()).lightmap(skylight, blocklight).endVertex();
        buffer.pos(offset.x + 0, offset.y + 1, offset.z + 0).color(r, g, b, 255).tex(tas.getMinU(), tas.getMinV()).lightmap(skylight, blocklight).endVertex();
    }
}

 

 

Edited by ProspectPyxis
Cadiboo Reality Controller

Cadiboo

Posted
Posted

The darkness is caused by your block being a full block. Either make your block able to have light pass through/into it OR average the light from the surrounding blocks OR get the light from the proper place for each vertex. Rendered textures have an issue with 1 pixel around their edge being transparent. You can get around this the way vanilla does for block rendering (subtracting a tiny bit from the part of the texture it renders). You can see me doing this where I fix a number of issues with Vanilla’s fluid rendering at https://github.com/Cadiboo/NoCubes/blob/2d116b923e584ecfaa05823ffbccc2e9aedf537e/src/main/java/io/github/cadiboo/nocubes/client/render/SmoothLightingBlockFluidRenderer.java#L272. I add smooth lighting and fix the transparent lines between fluids. 

  • Like 1

About Me

Spoiler

My Discord - Cadiboo#8887

My Website - Cadiboo.github.io

My Mods - Cadiboo.github.io/projects

My Tutorials - Cadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept