Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[SOLVED] Ghost Item being spawned when hitting entity


ThatBenderGuy
 Share

Recommended Posts

So I have this code on my custom sword

 

    public boolean hitEntity(ItemStack par1ItemStack, EntityLiving par2EntityLiving, EntityLiving par3EntityLiving)
    {
    	Random rand = new Random();
   	int chance = (1 + rand.nextInt(100));
   	World world = par3EntityLiving.worldObj;
   	if(chance <= {
   		par1ItemStack.damageItem(100, par3EntityLiving);
       	par2EntityLiving.addPotionEffect(new PotionEffect(Potion.wither.getId(), 100, 7));
       	par2EntityLiving.entityDropItem(new ItemStack(mod_MainClass.BlinShard, 1),  1.0f);
        	
    }else{
    	par1ItemStack.damageItem(1, par3EntityLiving);
    }
        return true;
    }

 

And sometimes it'll spawn an extra item that can't be picked up. I thought it would use world.isRemote but this specific method doesn't use world in it. So I am at a loss at what could be causing a ghost item to appear.

 

EDIT:

I just derped. I realised I did declare a world variable and changed my code to this

    public boolean hitEntity(ItemStack par1ItemStack, EntityLiving par2EntityLiving, EntityLiving par3EntityLiving)
    {
   	World world = par3EntityLiving.worldObj;
    	if (world.isRemote)
    	{
    		return true;
    	}else{
    	Random rand = new Random();
	   	int chance = (1 + rand.nextInt(100));
	   	if(chance <= {
	   		par1ItemStack.damageItem(100, par3EntityLiving);
	       	par2EntityLiving.addPotionEffect(new PotionEffect(Potion.wither.getId(), 100, 7));
	       	par2EntityLiving.entityDropItem(new ItemStack(mod_MainClass.BlinShard, 1),  1.0f);
	        	
	    }else{
	    	par1ItemStack.damageItem(1, par3EntityLiving);
	    }
        return true;
    }
    }

Bumper Cars!

Link to comment
Share on other sites

you need to use world.isRemote so you only spawn entity's on the server side :)

 

It's true that you don't get served a world Object inn the parameters, but ya know what?

You do gets Entity's which live inside the world, so you can check what world they are inn and use that world object to do the check :)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

hehe good good <3

Then you can mark this as solved by putting [solved] inn your title and lock the thread.

This makes it easier for people using the search function to find solutions to the same problem :)

thanks :)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Here is my configuration: % java -version java version "18.0.2" 2022-07-19 Java(TM) SE Runtime Environment (build 18.0.2+9-61) Java HotSpot(TM) 64-Bit Server VM (build 18.0.2+9-61, mixed mode, sharing) forge-1.19-41.1.0-mdk on macOS Monterey 12.5 I ran the command: ./gradlew genEclipseRuns and was hoping it will generate the Eclipse project files for me. The run log is at https://gist.github.com/arun-gupta/06b983a6976b4c0a0f510d0dc225ddd3 and the generated directory structure is at https://gist.github.com/arun-gupta/3f5bfc70ec5d3d903b0f97d42840abda. In previous versions (1.12-ish), it used to generate an eclipse directory but 1.19 does not seem to have it. I tried opening the top-level forge directory but Eclipse does not recognize it as a project as well. How do I open this project in Eclipse now?  
    • I didn't put in credentials, I used it only for testing installing forge. But still the problem mentioned above.
    • I am trying to use Forge 1.18.2, I have checked my firewall, redownloaded Forge, deleted the fml.toml file (which keeps reappearing) and looked at countless help pages. I am just trying to download and use forge so that I can play with my friends and it will not download. It tells me there may be an issue with the Java runtime config and that the exit code is one, and I have copied the exit code.   
    • Okay, i think i understand but im getting issues, i create another packet to sync entity to another players like this package com.naim.belloto.networking.packet; import com.naim.belloto.networking.handler.ClientSyncHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.FriendlyByteBuf; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.fml.DistExecutor; import net.minecraftforge.network.NetworkEvent; import java.util.Objects; import java.util.function.Supplier; public class ClientSyncPacket { public ClientSyncPacket() { } public ClientSyncPacket(FriendlyByteBuf buf) { } public void toBytes(FriendlyByteBuf buf) { } public boolean handle(Supplier<NetworkEvent.Context> ctx) { NetworkEvent.Context context = ctx.get(); context.enqueueWork(() -> { assert Minecraft.getInstance().player != null; int idplayer = Minecraft.getInstance().player.getId(); DistExecutor.unsafeCallWhenOn(Dist.CLIENT,() -> () -> ClientSyncHandler.handlePacket(ctx, idplayer)); }); return true; } } And in the handler: public class ClientSyncHandler { public static boolean handlePacket(Supplier<NetworkEvent.Context> ctx, int idPlayer) { Minecraft.getInstance().level.getEntity(idPlayer); return true; } } But is not working :// 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.