Hi

 

I am making a mod that adds a Bauble that enables a Keybinding to fire a rocket in use with an Elytra to avoid having Fireworks in the hot bar.

The item works as expected, but the rocket never stops propelling you forwards. My best guess going on Mojang's code is that it automatically applies a "LifeTime" to the Entity separate from the spawning code. And due to my code not adding it doesn't kill it.

 

My Code (KeyInputHandler.java):

@SubscribeEvent
    public void onKeyInput(InputEvent.KeyInputEvent event) {
        if (rocketPouch.KeybindTHRUST.isPressed()) {
            EntityPlayer player = Minecraft.getMinecraft().player;
            WorldClient world = Minecraft.getMinecraft().world;

            if (player.isElytraFlying()) {
                if (BaublesApi.isBaubleEquipped(player,THRUSTERS) != -1) {

                    ItemStack itemStack = findRockets(player);
                    if (itemStack.equals(ItemStack.EMPTY)) {
                        player.sendMessage(new TextComponentString("§4No Rockets"));
                        return;
                    }
                    if (!player.isCreative())
                        itemStack.shrink(1);

                    EntityFireworkRocket fireworkRocket = new EntityFireworkRocket(world, itemStack, player);
                    int duration = itemStack.getTagCompound().getCompoundTag("Fireworks").getByte("Flight");
                    NBTTagCompound nbt = new NBTTagCompound();

                    nbt.setInteger("LifeTime",duration);

                    fireworkRocket.readEntityFromNBT(nbt);

                    world.spawnEntity(fireworkRocket);

                    player.playSound(SoundEvents.ENTITY_FIREWORK_LAUNCH, 3.0F, 1.0F);

                    System.out.println(fireworkRocket.getTags());



                } else {
                    player.sendMessage(new TextComponentString("§4You need Thrusters to launch"));
                }
            }
        }
    }

 

Mojang (EntityFireworkRocket.java):

public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn)
    {
        if (playerIn.isElytraFlying())
        {
            ItemStack itemstack = playerIn.getHeldItem(handIn);

            if (!worldIn.isRemote)
            {
                EntityFireworkRocket entityfireworkrocket = new EntityFireworkRocket(worldIn, itemstack, playerIn);
                worldIn.spawnEntity(entityfireworkrocket);

                if (!playerIn.capabilities.isCreativeMode)
                {
                    itemstack.shrink(1);
                }
            }

            return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, playerIn.getHeldItem(handIn));
        }
        else
        {
            return new ActionResult<ItemStack>(EnumActionResult.PASS, playerIn.getHeldItem(handIn));
        }
    }

 

I tried to add NBT to the Rocket, but to no avail. I could really need some help with this.

10 hours ago, Simon_kungen said:

InputEvent.KeyInputEvent

 

10 hours ago, Simon_kungen said:

world.spawnEntity(fireworkRocket);

 

10 hours ago, Simon_kungen said:

itemStack.shrink(1);

You can't do any of this. All entities must be spawned on a server, not the client, and inventory manipulations must also be done on the server, not the client. You need to send a packet to the server and do all this on the server.

Ok, thanks

How would I go about making a packet to send an ItemStack and EntityPlayer to the server? And listen to them. I just read through the Forge Doc about networking and SimpleImpl. Or can I only send Int?

10 minutes ago, Simon_kungen said:

How would I go about making a packet to send an ItemStack and EntityPlayer to the server?

You don't need to send those to the server, it makes no sense.

You need to send just enough information so the server can validate it, find the player, find the itemstack in their inventory and do whatever it is supposed to.