[Solved] (1.13.2) Item registration event only fires in a class with the @Mod.EventBusSubscriber annotation

[treebranch]

I'm just trying to understand why this happens. My mod is very large now, and all my events fire by simply calling MinecraftForge.EVENT_BUS.register(this) in the constructor of the main mod class, which houses all of said events. Everything fires except the RegistryEvent.Register<T> event. I got stuck on this and couldn't figure out why it was the only event that wasn't firing, and it was only until I put it as a static method in its own separate class, annotated with @Mod.EventBusSubscriber, that it finally began to work. I even tried registering that class using EVENT_BUS.register and it's the same problem. It's the only event that has to be in a class annotated with @Mod.EventBusSubscriber. Am I doing something wrong or is this on Forge's side?

Edited April 21, 2019 by treebranch

[DaemonUmbra]

Have you looked at how events are registered in the example mod?

[treebranch]

1 minute ago, DaemonUmbra said:

Have you looked at how events are registered in the example mod?

Yes, using EVENT_BUS.register(this) in the main mod class. That's how I did all of my events, until I hit the register event. Simply it doesn't work, but I wish it did so I could have consistency in my code.

 

This is event in its own class alone with the EventBusSubscriber annotation (this works perfectly):

 

@Mod.EventBusSubscriber(modid = ModInfo.MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class RegisterItems {
    @SubscribeEvent
    public static void onRegisterItems(RegistryEvent.Register<Item> event) {
    	event.getRegistry().registerAll(
    		// item registration stuff here
    	);
    }
}

 

This is the same class, but rewritten without the @Mod.EventBusSubscriber annotation, and instead registered to the event bus from the main mod class (this never fires):

public class RegisterItems {
    @SubscribeEvent
    public void onRegisterItems(RegistryEvent.Register<Item> event) {
    	event.getRegistry().registerAll(
    		// item registration stuff here
    	);
    }
}

 

(And the main mod class):

@Mod(ModInfo.MODID)
public class ExampleMod {
	public ExampleMod() {
		MinecraftForge.EVENT_BUS.register(this);
		MinecraftForge.EVENT_BUS.register(new RegisterItems());
	}
  
	// more events down here
}

 

And finally, this is how I was doing it originally, where I ended up hitting the dead end with the register event (this never fires, despite every other event in my mod working this way):

@Mod(ModInfo.MODID)
public class ExampleMod {
  
	public ExampleMod() {
		MinecraftForge.EVENT_BUS.register(this);
	}
	
	@SubscribeEvent
	public void onRegisterItems(RegistryEvent.Register<Item> event) {
		event.getRegistry().registerAll(
			// item registration stuff here
		);
	}
      
	// tons of other events down here which work perfectly
}

 

[treebranch]

2 minutes ago, diesieben07 said:

Where you use @EventBusSubscriber you are specifying bus = Mod.EventBusSubscriber.Bus.MOD. But when registering manually you are using MinecraftForge.EVENT_BUS, not FMLJavaModLoadingContext.get().getModEventBus, which is the equivalent of Mod.EventBusSubscriber.Bus.MOD.

Thank you for this info. Is the event bus provided by `FMLJavaModLoadingContext.get()` the only one in which RegistryEvent.Register will fire?

[treebranch]

Just now, diesieben07 said:

Correct.

The more you know. I'll mark this as solved. Where can I find detailed documentation for this so I don't run into similar confusions later?

[treebranch]

Just now, diesieben07 said:

I don't think there is much documentation on this for 1.13.2 yet. In general most events fire out the normal event bus, except for the registry and other startup events.

Is there a list of events somewhere along with which bus they're fired by?

[treebranch]

32 minutes ago, diesieben07 said:

Use your IDE. Use the "type hierarchy" command on the Event class and it will list all events. Then you can use "find usages" to find out where the event is fired.

Thanks for your help. I've probably viewed over half the 1.13.x related threads on this forum in an attempt to learn, and not everything is helpful. I'm new to Java and Forge so sometimes the smallest details are invaluable to me.

 

While we're at it, there's a few events that never fired for me on MinecraftForge.EVENT_BUS and I had to find workarounds. Namely ChunkDataEvent.Load and PlayerEvent.NameFormat. I assumed these were Forge bugs or things that hadn't been implemented yet, but maybe it's another case of wrong bus?

 

EDIT: They're on the right bus, it's just Forge's fault I guess. Anyways thanks.

Edited April 21, 2019 by treebranch