[1.13.2] Trying to make a custom potion effect

[ketchup_god]

I'm still a beginner modder, so I've been watching some tutorials on modding and I've decided to make a custom potion effect. I've scoured the internet trying to find a working tutorial, read the docs, and looked through the forums, but I still can't find anything that will help. Most of it is all in 1.12 and I can't find anything in 1.13. Please help!

[V0idWa1k3r]

Custom potion effect creation hadn't changed for a while so 1.12 methods should still apply as long as the tutorials are not using stuff like static initializers.

[ketchup_god]

Thanks for your quick reply!

 

As a matter of fact, I have been trying to use a 1.12 tutorial. However, I always encounter errors that I can't fix.

For example, in my PotionInit class, I have 

public static final PotionEffect Restlessness = new CustomPotion()

so I created a new class called CustomPotion and wrote

public static CustomPotion(String name, boolean isBadPotion, int colour, int iconIndexX, int iconIndexY)
{
super(isBadPotion, colour);
setPotionName("effect." + name);
setIconIndex(iconIndexX, iconIndexY);
setRegistryName(new ResourceLocation(examplemod.modid + ":" + name));
}

However, eclipse gives me an error on PotionInit saying that I need to add values to the CustomPotion() constructor. When I apply the quick fix, eclipse gives me this:

public static final PotionEffect Restlessness = new CustomPotion(null, null, 0, 0, 0)

I'm wondering if this is what you were talking about in your reply about the static initializers. Is there a fix to my issue, or am I doing something wrong?

[V0idWa1k3r]

57 minutes ago, ketchup_god said:

I'm wondering if this is what you were talking about in your reply about the static initializers. Is there a fix to my issue, or am I doing something wrong?

Well, yes, it is a static initializer.

 

All I can recommend to you is to learn java. Making minecraft mods requires an understanding of the language the mods are written in, you can't really make a mod without knowledge of the programming language you are using.

I mean I could say "you have created the constructor yourself, pass in the values that make sense" but even if you fix this issue with our help you will encounter new issues at every step going forward if you don't know the basics of java.

 

[ketchup_god]

Alright, one last question concerning forge methods.

In my CustomPotion class, I have this to get the GUI icon:

Minecraft.getMinecraft().getTextureManager().bindTexture(new ResourceLocation(examplemod.modid + "textures/gui/potion_effects.png"));

Eclipse keeps on telling me that getMinecraft() isn't a method for Minecraft. I'm pretty sure this is an issue with the outdated tutorial, so is there a way to do this in the current version?

Thanks again for your help.

[V0idWa1k3r]

it got renamed to getInstance

[ketchup_god]

Thanks, it worked!

I'll make sure to start learning some Java. Thanks for all your help.

[Cadiboo]

8 hours ago, ketchup_god said:

new ResourceLocation(examplemod.modid + "textures/gui/potion_effects.png"));

You need a comma instead of a plus sign here