1.12.2 Mod Crashing on server.

[scottishcrafter]

Hi folks, I have been building a mod for a few weeks now, my first minecraft mod, and have been getting on great, but i have come across a problem I can't seem to get my head around.

 

When trying to run my mod server side I get the following Crash Report.

 

Spoiler

---- Minecraft Crash Report ----
// Don't be sad, have a hug! ❤️

Time: 25/04/19 13:57
Description: Exception in server tick loop

net.minecraftforge.fml.common.LoaderException: java.lang.NoClassDefFoundError: net/minecraft/client/renderer/tileentity/TileEntitySpecialRenderer
    at net.minecraftforge.fml.common.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:89)
    at net.minecraftforge.fml.common.FMLModContainer.constructMod(FMLModContainer.java:614)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
    at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
    at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
    at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
    at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
    at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
    at com.google.common.eventbus.EventBus.post(EventBus.java:217)
    at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219)
    at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
    at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
    at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
    at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
    at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
    at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
    at com.google.common.eventbus.EventBus.post(EventBus.java:217)
    at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136)
    at net.minecraftforge.fml.common.Loader.loadMods(Loader.java:593)
    at net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:98)
    at net.minecraftforge.fml.common.FMLCommonHandler.onServerStart(FMLCommonHandler.java:333)
    at net.minecraft.server.dedicated.DedicatedServer.init(DedicatedServer.java:128)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:552)
    at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NoClassDefFoundError: net/minecraft/client/renderer/tileentity/TileEntitySpecialRenderer
    at java.lang.Class.getDeclaredMethods0(Native Method)
    at java.lang.Class.privateGetDeclaredMethods(Unknown Source)
    at java.lang.Class.privateGetPublicMethods(Unknown Source)
    at java.lang.Class.getMethods(Unknown Source)
    at net.minecraftforge.fml.common.eventhandler.EventBus.register(EventBus.java:82)
    at net.minecraftforge.fml.common.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:82)
    ... 32 more
Caused by: java.lang.ClassNotFoundException: net.minecraft.client.renderer.tileentity.TileEntitySpecialRenderer
    at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:191)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    ... 38 more
Caused by: net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerException: Exception in class transformer net.minecraftforge.fml.common.asm.transformers.SideTransformer@1d50a7ca from coremod FMLCorePlugin
    at net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerWrapper.transform(ASMTransformerWrapper.java:260)
    at net.minecraft.launchwrapper.LaunchClassLoader.runTransformers(LaunchClassLoader.java:279)
    at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:176)
    ... 40 more
Caused by: java.lang.RuntimeException: Attempted to load class net/minecraft/client/renderer/tileentity/TileEntitySpecialRenderer for invalid side SERVER
    at net.minecraftforge.fml.common.asm.transformers.SideTransformer.transform(SideTransformer.java:62)
    at net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerWrapper.transform(ASMTransformerWrapper.java:256)
    ... 42 more

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- System Details --
Details:
    Minecraft Version: 1.12.2
    Operating System: Windows 10 (amd64) version 10.0
    Java Version: 1.8.0_201, Oracle Corporation
    Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
    Memory: 370133960 bytes (352 MB) / 455606272 bytes (434 MB) up to 934281216 bytes (891 MB)
    JVM Flags: 0 total; 
    IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
    FML: MCP 9.42 Powered by Forge 14.23.5.2832 6 mods loaded, 6 mods active
    States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored

    | State | ID          | Version      | Source                           | Signature |
    |:----- |:----------- |:------------ |:-------------------------------- |:--------- |
    | LC    | minecraft   | 1.12.2       | minecraft.jar                    | None      |
    | LC    | mcp         | 9.42         | minecraft.jar                    | None      |
    | LC    | FML         | 8.0.99.99    | forgeSrc-1.12.2-14.23.5.2832.jar | None      |
    | LC    | forge       | 14.23.5.2832 | forgeSrc-1.12.2-14.23.5.2832.jar | None      |
    | LE    | herbalcraft | 0.0.13       | bin                              | None      |
    | L     | examplemod  | 1.0          | bin                              | None      |

    Loaded coremods (and transformers): 
    Profiler Position: N/A (disabled)
    Is Modded: Definitely; Server brand changed to 'fml,forge'
    Type: Dedicated Server (map_server.txt)

I read the forge docs and identified that my mod chest block is the problem because it's trying to register a TESR on the server side. 

 

This is where i run into a problem, I'm unable to register the block on the client side no matter what i do.

 

I have used the following code from the forge docs

@SubscribeEvent
	public static void registerBlocks(RegistryEvent.Register<Block> event)
	{
		event.getRegistry().registerAll(BlockInit.BLOCKS.toArray(new Block[0]));
		TileEntityHandler.registerTileEntities();
		ClientRegistry.bindTileEntitySpecialRenderer(TileEntityCannaChest.class, new RenderCannaChest());
	}
	

however I still can't get it working. 

Could someone let me know where I've went wrong please? And if possible point me in the right direction to fix it?

 

Edit: forgot to add the github link

https://github.com/scottishcrafter/ScottysHerbalCraft

 

As i said this is my first minecraft mod, I had initially started on Mcreator, realised very quickly how bad an idea that was so completely abandoned that one and have started again from scratch.

 

Any and all help greatly appreciated, 

Edited April 25, 2019 by scottishcrafter

[DavidM]

1. Your repo is set up incorrectly; the root of your repo needs to be the root of the forge mdk.

2. Why do you have .class files in your src?

3. Stop using static initializers. Read the Common issues and recommendation for more details.

4. Stop using BlockBase/ItemBase. Read the Common issues and recommendation for more details.

5. Stop using IHasModel. Read the Common issues and recommendation for more details.

6. Your tile entities use bad practices like getters like this. Use normal getters instead.

7. Clean up your repo. There are random .gitignores splattered around everywhere.

 

8. As for your problem:

32 minutes ago, scottishcrafter said:

ClientRegistry.bindTileEntitySpecialRenderer(TileEntityCannaChest.class, new RenderCannaChest());

Move this to your client proxy.

Alternatively, you can move it to the ModelRegistryEvent (not the best idea tho), which only triggers on the client side.

[DavidM]

I am very sorry to tell you this, but the code and structure of your mod is a complete mess.

Judging by the class names, I assume that you followed HarryTalks' videos. Stop following his tutorials, as they are terrible and promote bad practices and outdated methods.

These bad practices (static initializers, etc) will eventually cause more problems. One example is the crash you are facing now.

 

Personally, I would recommend to follow a better guide/tutorial and rewrite the majority of your mod. Examples of good tutorials are: https://github.com/Cadiboo/Example-Mod/ and https://github.com/TheGreyGhost/MinecraftByExample, both of which explained some difficult concepts of modding in details. 

[scottishcrafter]

Damn, I realised the first tutorial I picked wasn't showing best practice, thought the Harry Talks ones were okay. Never mind, thanks for pointing out some better ones, I'll look into those two and get rewriting.

 

Thanks for the fix for the shoddy code I have now though, it worked and it now boots on servers.

I'll also sort the repo out and tidy it up.

 

Thanks for your help.