Jump to content

Recommended Posts

Posted (edited)

Hello guys,

 

i have a problem with my network that send Data from Server to Client.

 

This is my Event, where is sending the Packet:

	 @SubscribeEvent
	 public void onPlayerTick(PlayerTickEvent event) 
	 {
		if(event.side == Side.SERVER) 
		{
			EntityPlayer player = event.player;
			ICharacterData cd = player.getCapability(CD_CAPABILITY, null);
			
			if(cd != null)
			{
				PacketHandler.INSTANCE.sendTo(new PlayerCapabilitiesMessage(cd), (EntityPlayerMP) player);				
			}		
		}
	}

 

And this is my PlayerCapabilitiesMessage:

public class PlayerCapabilitiesMessage implements IMessage {

	@CapabilityInject(ICharacterData.class)
	public static Capability<ICharacterData> CD_CAPABILITY = null;	
	
	private static ICharacterData value;

	public PlayerCapabilitiesMessage() {}
	
	public PlayerCapabilitiesMessage(ICharacterData value) {
		this.value = value;
	}	

	@Override
	public void toBytes(ByteBuf buf) 
	{
		if(this.value != null) {
			buf.writeInt(this.value.GetReiPlayer());
			buf.writeInt(this.value.GetReiPlayerMax());
			buf.writeInt(this.value.PlayerisGhost(0));
		}
	}	
	
	@Override
	public void fromBytes(ByteBuf buf) 
	{
		if(this.value != null) {
			this.value.SetReiPlayer(buf.readInt());
			this.value.SetReiPlayerMax(buf.readInt());
			this.value.PlayerisGhost(buf.readInt());
		}
	}
	
	public ICharacterData getValue(ICharacterData value) {
		return this.value;
	}	
	
	public static class Handler implements IMessageHandler<PlayerCapabilitiesMessage, IMessage>{

		@Override
		public IMessage onMessage(PlayerCapabilitiesMessage message, MessageContext ctx) 
		{
			final ICharacterData newvalue = message.getValue(value);
			final EntityPlayerSP p = Minecraft.getMinecraft().player;
			final ICharacterData oldvalue = p.getCapability(CD_CAPABILITY, null);
			IThreadListener mainThread = Minecraft.getMinecraft();
			
			mainThread.addScheduledTask(() -> {
				
				if(oldvalue != null && newvalue != null) 
				{
					oldvalue.SetReiPlayer(newvalue.GetReiPlayer());
					oldvalue.SetReiPlayerMax((newvalue.GetReiPlayerMax()));
					oldvalue.PlayerisGhost(newvalue.PlayerisGhost(0));
				}
				
			});
			return null;
		}
		
	}
}

 

Now my problem is:

 

The Server and the Client are sync in Singleplayer, there is no problem.

 

In Mulitplayer it isnt working, because the value is null, but sometimes it works with the first Player/Client who join the Server and the second one got null.

 

Someone any idea? Thanks in advance :)

Edited by PJack
Got solved
Posted
  On 4/26/2019 at 5:06 AM, V0idWa1k3r said:

You can't do this in your packet. You must reconstruct the data in your handler, you can't store it like that.  

Expand  

You mean, it should be like this?:
 

private int GetReiPlayer

private int GetReiPlayerMax

....

 

instead

 

private static ICharacterData value;

 

Posted
  On 4/26/2019 at 9:51 AM, PJack said:

You mean, it should be like this?:
 

private int GetReiPlayer

private int GetReiPlayerMax

....

 

instead

 

private static ICharacterData value;

 

Expand  

The point is the values cannot be static, and should contain the data to be send across the sides each time.

Some tips:

  Reveal hidden contents

 

Posted (edited)

Okay, i removed the static.

private ICharacterData value;

 

Edit:

 

I found out that my this.value getting null in here, but i still dont know why.

	@Override
	public void fromBytes(ByteBuf buf) 
	{
		System.out.println("Check:" + this.value);
		if(this.value != null) {
			value.SetReiPlayer(buf.readInt());
			value.SetReiPlayerMax(buf.readInt());
			value.PlayerisGhost(buf.readInt());
		}
	}

 

Edited by PJack
Posted

I got the solution. Thanks to a post from diesieben07.

 

Instead of sending the capability, i send the raw data from it and it works now fine in Single and Multiplayer.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hey man,    i have only been modding Minecraft for a few days but maybe I can help you. First of all make sure to follow every step of Kaupenjoe's tutorial, I found it to been very helpful and complete. The game uses the raw translation key for the item (in your case "item.testmod.alexandrite") if it can't find the correct lang file. Make sure it's name is "en_us.json" and it is saved under "ressources" -> "assets" -> "testmod".
    • whenever I try to get this item to render into the game it appears with the not texture purple and black squares and calls itself by the lang translation file path instead of the name i gave it.   { "item.testmod.alexandrite": "Alexandrite" } this is the lang json file package net.Hurst.testmod.item; import net.Hurst.testmod.TestMod; import net.minecraft.world.item.Item; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID); public static final RegistryObject<Item> ALEXANDRITE = ITEMS.register("alexandrite", () -> new Item(new Item.Properties())); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } this is my ModItems.java file package net.Hurst.testmod; import com.mojang.logging.LogUtils; import net.Hurst.testmod.item.ModItems; import net.minecraft.world.item.CreativeModeTabs; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.BuildCreativeModeTabContentsEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.ModLoadingContext; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.config.ModConfig; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(TestMod.MOD_ID) public class TestMod { public static final String MOD_ID = "testmod"; private static final Logger LOGGER = LogUtils.getLogger(); public TestMod() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); modEventBus.addListener(this::commonSetup); ModItems.register(modEventBus); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC); } private void commonSetup(final FMLCommonSetupEvent event) { } // Add the example block item to the building blocks tab private void addCreative(BuildCreativeModeTabContentsEvent event) { if(event.getTabKey() == CreativeModeTabs.INGREDIENTS){ event.accept(ModItems.ALEXANDRITE); } } // You can use SubscribeEvent and let the Event Bus discover methods to call @SubscribeEvent public void onServerStarting(ServerStartingEvent event) { } // You can use EventBusSubscriber to automatically register all static methods in the class annotated with @SubscribeEvent @Mod.EventBusSubscriber(modid = MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { } } } this is my TestMod.java file { "parent": "minecraft:item/generated", "textures": { "layer0": "testmod:item/generated" } } this is my model file for the item. I am using intellij 2025.1.2 with fdk 1.21 and java 21 I would appreciate the help.
    • Also remove VS Create Armor, createbigcannons and The Factory Must Grow
    • Add the latest.log (logs-folder) with sites like https://mclo.gs/ and paste the link to it here  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.