[1.12.2] Item breaks when has durability 0 event

[nov4e]

Hello. Does exist a @SubscribeEvent  that makes the item break when has durability 0? If yes how its called? 

[V0idWa1k3r]

I don't think such an event exists.

[nov4e]

so how can I set that a item does not break? 

[loordgek]

is the item your own ??

[nov4e]

  On 5/2/2019 at 2:37 PM, loordgek said:

is the item your own ??

Expand  

yes

[desht]

  On 5/2/2019 at 4:05 PM, nov4e said:

yes

Expand  

Then override Item#setDamage(ItemStack, int) for your item. In your overridden method, just make sure that the stack's item damage never exceeds its max damage, and the item won't break.

[nov4e]

   @Override
	public void setDamage(ItemStack stack, int damage) {
		if(damage > 1) {
			stack.setItemDamage(damage);
		}
	}

 

[desht]

  On 5/3/2019 at 1:39 PM, nov4e said:

   @Override
	public void setDamage(ItemStack stack, int damage) {
		if(damage > 1) {
			stack.setItemDamage(damage);
		}
	}

 

Expand  

No, you want to check that damage <= item.getMaxDamage() before you update the item's damage.  Remember that the item damage increases as it becomes more damaged.

[nov4e]

I changed it a little bit:

@Override
	public void setDamage(ItemStack stack, int damage) {
		if(stack == new ItemStack(this)) {
			if(damage < stack.getItem().getMaxDamage()) {
				if(damage > 1) {
					super.setDamage(stack, damage);
				}
			}
		}
	}

 

[desht]

What on earth is this for? 

if(stack == new ItemStack(this))

 

And why do you keep trying to compare damage > 1 ?  What do you think that's achieving?

 

All you need to do is clamp the item's damage value between 0 (undamaged) and item.maxDamage() (fully damaged, just before breaking) inclusive.

 

By the way, you should be testing your code (and ideally running it through your IDE's debugger when it fails) rather than just inventing snippets to post here.

Edited May 3, 2019 by desht

[nov4e]

I tested everything and seems that removing

  On 5/3/2019 at 2:58 PM, desht said:

if(stack == new ItemStack(this))

Expand  

works.

 

[loordgek]

https://stackoverflow.com/questions/7520432/what-is-the-difference-between-and-equals-in-java

Edited May 3, 2019 by loordgek