How to add torch texture to the mod?

[NErOHUN]

Hi! I want to make a torch in my forge mod (1.12.2).

I've already made my "Torch Base" class, and created the torch, which is working, but doesn't have texture.

I tried to add the texture, like a simple block, but -of course- it doesn't working.

This is in the block's json file.

{
   "parent": "block/cube_all",
   "textures": {
       "all": "modminers:blocks/napalm"
   }
}

 

And this is the torch class:

public class Napalm extends BlockTorch implements IHasModel
{
	public Napalm(String name, CreativeTabs tab) 
	{
		super();
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(tab);
		setLightLevel(100.0F);
	
		
		BlockInit.BLOCKS.add(this);
		ItemInit.ITEMS.add(new ItemBlock(this).setRegistryName(name));
	}
	
	@Override
	public void registerModels() 
	{
		Main.proxy.registerModel(Item.getItemFromBlock(this), 0);
	}
}

 

I think I have to change something about the texture integration, but I don't know what.

I hope I wrote everything down understandable, and thank you in advice for your answers.

(PS.: Sorry for my bad English)

[V0idWa1k3r]

1 hour ago, NErOHUN said:

've already made my "Torch Base" class

Don't.

 

1 hour ago, NErOHUN said:

implements IHasModel

IHasModel is stupid since every item needs a model and makes you write a lot of unnecessary code. You can literally register the models for all your items in 1 line of code.

 

1 hour ago, NErOHUN said:

BlockInit.BLOCKS.add(this); ItemInit.ITEMS.add(new ItemBlock(this).setRegistryName(name));

Don't ever use static initializers. Registry entries must be instantinated in the appropriate registry event.

 

Since you are using BlockTorch as a base you must define the blockstates that the torch might have in your blockstates file. See vanilla torch blockstates file for example.

[NErOHUN]

9 hours ago, V0idWa1k3r said:

Don't.

 

IHasModel is stupid since every item needs a model and makes you write a lot of unnecessary code. You can literally register the models for all your items in 1 line of code.

 

Don't ever use static initializers. Registry entries must be instantinated in the appropriate registry event.

 

Since you are using BlockTorch as a base you must define the blockstates that the torch might have in your blockstates file. See vanilla torch blockstates file for example.

You're right. I made the blockstate and a template to the torch.
It has texture like an item (in my hand), but when I place it down, it seems like a block which has no texture.
When the game starts, it tries to load the model with facings(EAST, WEST, stc.), like a normal block which has different sides.

And of course I get error, because there aren't any facing parameter in the blockstate file.

My torch file in the models/item folder
 

{
   "parent": "modminers:block/napalm"
}

 

The blockstate file in the models/block folder

{
   "parent": "modminers:block/torchtemplate",
   "textures": {
        "torch": "modminers:blocks/napalm"
    }
}

And my torchtemplate file in the models/block folder too
 

{
   "ambientocclusion": false,
   "textures": {
       "particle": "#torch"
   },
   "elements": [
       {   "from": [ 7, 0, 7 ],
           "to": [ 9, 10, 9 ],
           "shade": false,
           "faces": {
               "down": { "uv": [ 7, 13, 9, 15 ], "texture": "#torch" },
               "up":   { "uv": [ 7,  6, 9,  8 ], "texture": "#torch" }
           }
       },
       {   "from": [ 7, 0, 0 ],
           "to": [ 9, 16, 16 ],
           "shade": false,
           "faces": {
               "west": { "uv": [ 0, 0, 16, 16 ], "texture": "#torch" },
               "east": { "uv": [ 0, 0, 16, 16 ], "texture": "#torch" }
           }
       },
       {   "from": [ 0, 0, 7 ],
           "to": [ 16, 16, 9 ],
           "shade": false,
           "faces": {
               "north": { "uv": [ 0, 0, 16, 16 ], "texture": "#torch" },
               "south": { "uv": [ 0, 0, 16, 16 ], "texture": "#torch" }
           }
       }
   ]
}

 

[DavidM]

Post the error as well as a picture of the block in game.

 

Moreover,

11 hours ago, V0idWa1k3r said:

See vanilla torch blockstates file for example.

you seemed to completely ignored this sentence.

Edited May 7, 2019 by DavidM

[NErOHUN]

3 hours ago, DavidM said:

Post the error as well as a picture of the block in game. 

 

Moreover,

you seemed to completely ignored this sentence.

I used the vanilla torch blockstate examples, from here: https://minecraft.gamepedia.com/Model.
And then it has texture in my inventory, like an item, but when I place it down, it shows like a block, which has no texture.

Here are the errors, and some pictures from the game.

[V0idWa1k3r]

11 hours ago, NErOHUN said:

And of course I get error, because there aren't any facing parameter in the blockstate file.

So, you know the issue, you know what it is cause by and know how to fix that. Or at least this statement indicates that you do. All that's left is to fix it. Add those parameters to your blockstates file.