Jump to content

Recommended Posts

Posted

Hi! I want to make a torch in my forge mod (1.12.2).

I've already made my "Torch Base" class, and created the torch, which is working, but doesn't have texture.

I tried to add the texture, like a simple block, but -of course- it doesn't working.

This is in the block's json file.

{
   "parent": "block/cube_all",
   "textures": {
       "all": "modminers:blocks/napalm"
   }
}

 

And this is the torch class:

public class Napalm extends BlockTorch implements IHasModel
{
	public Napalm(String name, CreativeTabs tab) 
	{
		super();
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(tab);
		setLightLevel(100.0F);
	
		
		BlockInit.BLOCKS.add(this);
		ItemInit.ITEMS.add(new ItemBlock(this).setRegistryName(name));
	}
	
	@Override
	public void registerModels() 
	{
		Main.proxy.registerModel(Item.getItemFromBlock(this), 0);
	}
}

 

I think I have to change something about the texture integration, but I don't know what.

I hope I wrote everything down understandable, and thank you in advice for your answers.

(PS.: Sorry for my bad English)

Posted
  On 5/6/2019 at 6:58 PM, NErOHUN said:

've already made my "Torch Base" class

Expand  

Don't.

 

  On 5/6/2019 at 6:58 PM, NErOHUN said:

implements IHasModel

Expand  

IHasModel is stupid since every item needs a model and makes you write a lot of unnecessary code. You can literally register the models for all your items in 1 line of code.

 

  On 5/6/2019 at 6:58 PM, NErOHUN said:

BlockInit.BLOCKS.add(this); ItemInit.ITEMS.add(new ItemBlock(this).setRegistryName(name));

Expand  

Don't ever use static initializers. Registry entries must be instantinated in the appropriate registry event.

 

Since you are using BlockTorch as a base you must define the blockstates that the torch might have in your blockstates file. See vanilla torch blockstates file for example.

Posted
  On 5/6/2019 at 8:47 PM, V0idWa1k3r said:

Don't.

 

IHasModel is stupid since every item needs a model and makes you write a lot of unnecessary code. You can literally register the models for all your items in 1 line of code.

 

Don't ever use static initializers. Registry entries must be instantinated in the appropriate registry event.

 

Since you are using BlockTorch as a base you must define the blockstates that the torch might have in your blockstates file. See vanilla torch blockstates file for example.

Expand  

You're right. I made the blockstate and a template to the torch.
It has texture like an item (in my hand), but when I place it down, it seems like a block which has no texture.
When the game starts, it tries to load the model with facings(EAST, WEST, stc.), like a normal block which has different sides.

And of course I get error, because there aren't any facing parameter in the blockstate file.

My torch file in the models/item folder
 

{
   "parent": "modminers:block/napalm"
}

 

The blockstate file in the models/block folder

{
   "parent": "modminers:block/torchtemplate",
   "textures": {
        "torch": "modminers:blocks/napalm"
    }
}


And my torchtemplate file in the models/block folder too
 

{
   "ambientocclusion": false,
   "textures": {
       "particle": "#torch"
   },
   "elements": [
       {   "from": [ 7, 0, 7 ],
           "to": [ 9, 10, 9 ],
           "shade": false,
           "faces": {
               "down": { "uv": [ 7, 13, 9, 15 ], "texture": "#torch" },
               "up":   { "uv": [ 7,  6, 9,  8 ], "texture": "#torch" }
           }
       },
       {   "from": [ 7, 0, 0 ],
           "to": [ 9, 16, 16 ],
           "shade": false,
           "faces": {
               "west": { "uv": [ 0, 0, 16, 16 ], "texture": "#torch" },
               "east": { "uv": [ 0, 0, 16, 16 ], "texture": "#torch" }
           }
       },
       {   "from": [ 0, 0, 7 ],
           "to": [ 16, 16, 9 ],
           "shade": false,
           "faces": {
               "north": { "uv": [ 0, 0, 16, 16 ], "texture": "#torch" },
               "south": { "uv": [ 0, 0, 16, 16 ], "texture": "#torch" }
           }
       }
   ]
}

 

Posted (edited)

Post the error as well as a picture of the block in game.

 

Moreover,

  On 5/6/2019 at 8:47 PM, V0idWa1k3r said:

See vanilla torch blockstates file for example.

Expand  

you seemed to completely ignored this sentence.

Edited by DavidM

Some tips:

  Reveal hidden contents

 

Posted
  On 5/7/2019 at 8:32 AM, DavidM said:

Post the error as well as a picture of the block in game. 

 

Moreover,

you seemed to completely ignored this sentence.

Expand  

I used the vanilla torch blockstate examples, from here: https://minecraft.gamepedia.com/Model.
And then it has texture in my inventory, like an item, but when I place it down, it shows like a block, which has no texture.

Here are the errors, and some pictures from the game.

error1.png

error2.png

2019-05-07_13.48.46.png

2019-05-07_13.48.55.png

Posted
  On 5/7/2019 at 6:36 AM, NErOHUN said:

And of course I get error, because there aren't any facing parameter in the blockstate file.

Expand  

So, you know the issue, you know what it is cause by and know how to fix that. Or at least this statement indicates that you do. All that's left is to fix it. Add those parameters to your blockstates file.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • Crashes the server when trying to start. Error code -1. Log  
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.