Jump to content

[1.12.2] How to remove potion from player delivered from block


DinoPawz

Recommended Posts

Hi,

Forge 

1.12.2-14.23.5.2768

I am trying to set and remove a potion from a block. Block does not have an update function, so I have implemented ITickable.

public class LeadBlock extends Block implements ITickable {

    private static Map<EntityPlayer, PotionEffect> potionEffects = new HashMap<>();

    LeadBlock(@Nonnull String name, @Nonnull MaterialVariant materialVariant) {
        super(Material.IRON);
        setRegistryName(Reference.MODID, name);
        setUnlocalizedName(Reference.MODID_PREFIX + name);
        setHarvestLevel("pickaxe", 2);
        setHardness(materialVariant.getHardness());
        setResistance(materialVariant.getResistance());
        setCreativeTab(Tab.METALS);
        setSoundType(SoundType.METAL);
        this.setDefaultState(this.blockState.getBaseState());
    }

    @Override
    public void onEntityCollidedWithBlock(@Nonnull World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {
        if (worldIn.isRemote) {
            if (entityIn instanceof EntityPlayer) {
                EntityPlayer player = (EntityPlayer)entityIn;
                PotionEffect potionEffect = new PotionEffect(MobEffects.POISON, 300, 10, true, true);
                player.addPotionEffect(potionEffect);
                potionEffects.put(player, potionEffect);
            }
        }
        super.onEntityCollidedWithBlock(worldIn, pos, state, entityIn);
    }

    @Override
    public void onEntityWalk(@Nonnull World worldIn, BlockPos pos, Entity entityIn) {
        if (worldIn.isRemote) {
            if (entityIn instanceof EntityPlayer) {
                EntityPlayer player = (EntityPlayer)entityIn;
                PotionEffect potionEffect = new PotionEffect(MobEffects.POISON, 600, 20, true, true);
                player.addPotionEffect(potionEffect);
                potionEffects.put(player, potionEffect);
            }
        }
        super.onEntityWalk(worldIn, pos, entityIn);
    }

    @Override
    public void update() {
        OreberriesGalore.LOGGER.warn("In LeadBlock.update");
        if (!potionEffects.isEmpty()) {
            OreberriesGalore.LOGGER.warn("In LeadBlock.update potionEffect map has an entry");
            for (Map.Entry<EntityPlayer, PotionEffect> entry : potionEffects.entrySet()) {
                EntityPlayer player = entry.getKey();
                if (player != null) {
                    OreberriesGalore.LOGGER.warn("In LeadBlock.update potionEffect found player");
                    if (!player.isPotionActive(entry.getValue().getPotion())) {
                        OreberriesGalore.LOGGER.warn("In LeadBlock.update potionEffect about to remove potion effect from player");
                        player.removePotionEffect(entry.getValue().getPotion());
                        potionEffects.remove(entry.getKey(), entry.getValue());
                    }
                }
            }
        }
    }
}

The potion effect status bar gets activated correctly, and the potion effect counts down correctly, and the player's health hearts render green correctly. However, the player suffers no physical ill effects. And when the potion effect has finished, the status bars remain active until logging out, as do the player's health hearts remain green. The update function does not run as there is no output to the log file from this class.

Edited by DinoPawz
Link to comment
Share on other sites

10 minutes ago, DinoPawz said:

if (worldIn.isRemote) {

You probably want

if (!world.isRemote)

 

The latter executes the code on the server side.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

4 hours ago, DinoPawz said:

extends Block implements ITickable

No. ITickable isn't a magical interface that will deliver updates to everything you put it on. This will NOT work with a Block since the game won't iterate through ALL the blocks to deliver them the ticks.

ITickable is for entities and tileentities.

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Another Minecraft Launcher https://multimc.org/#Download or https://atlauncher.com/downloads
    • Remove these mods and combine OptiFine HD U I6 with Forge 47.2.18 Start with Optifine - without any other mods - if this works, add the mods one by one or in groups until you find the mod, conflicting with Optifine
    • Ok yeah I think this might be where the problem starts. For starters, I think you can get rid of your RecipeType impl and make it a static constant instead. I'm not 100% sure this will fix it but it's posssible. RuneInscribingRecipe public class RuneInscribingRecipe implements Recipe<SimpleContainer> { public static final RecipeType<RuneInscribingRecipe> RECIPE_TYPE = new RecipeType<>(){}; // .... @Override public RecipeType<?> getType() { return RECIPE_TYPE; } // .... } RuneInscriberMenu private Optional<RecipeHolder<RuneInscribingRecipe>> getCurrentRecipe() { SimpleContainer inventory = new SimpleContainer(2); inventory.setItem(BASE_INPUT_SLOT, this.inventory.getStackInSlot(BASE_INPUT_SLOT)); inventory.setItem(TEMPLATE_INPUT_SLOT, this.inventory.getStackInSlot(TEMPLATE_INPUT_SLOT)); List<RecipeHolder<RuneInscribingRecipe>> list = this.blockEntity.getLevel().getRecipeManager().getRecipesFor(RuneInscribingRecipe.RECIPE_TYPE, inventory, this.blockEntity.getLevel()); if (list.isEmpty()) { return Optional.empty(); } return Optional.of(list.get(0)); }   Also, this here is a little suspicious where you're getting the `this.inventory.getStackInSlot` calls. I'd try and make sure those are what you expect they are with either a Debug line in IDE or print statement SimpleContainer inventory = new SimpleContainer(2); inventory.setItem(BASE_INPUT_SLOT, this.inventory.getStackInSlot(BASE_INPUT_SLOT)); System.out.printf("CHECKING BASE INPUT OF RECIPE: %s\n", this.inventory.getStackInSlot(BASE_INPUT_SLOT)); inventory.setItem(TEMPLATE_INPUT_SLOT, this.inventory.getStackInSlot(TEMPLATE_INPUT_SLOT)); System.out.printf("CHECKING TEMPLATE INPUT OF RECIPE: %s\n", this.inventory.getStackInSlot(TEMPLATE_INPUT_SLOT)); ^ See what the result of those print statements are, make sure they're right
    • Upon testing again after adding them, the game still doesn't crash however the resource packs are still unfortunately broken.
    • Hi! Can someone please point me to the correct FAQ or place? I'm not able do DuckDuckGo myself out of this one. As you can hopefully see, chunks are not rendered. I run a forge server, fresh install on a linux VM. Curseforge on the Win11 client with Embeddium, Oculus and Unbound shader. No mods. Forge 47.2.23 on server & client.  No errors, no crashes, no apparent CPU or RAM issues with the VM. This screenshot was captured while creative, but the same happens when flying in survival. Waiting (floating) for a few minutes sooner or (often) later, lets the missing chunks appear. Usually takes 5-10 minutes.  When on a local game, the chunks appear slowly, but they do appear without pause.   This must be something simple, obvious, but I can't find the correct "search words" to find my way out. "Chunks not loading / rendering" didn't help. Browsing several forums neither. 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.