Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

[1.13.2-25.0.214] BlockFarmland.class passes the wrong blockState to canSustainPlant

Featured Replies

Posted

Just noticed this bug when making custom Farmland extending from BlockFarmland.

 

This is what it looks like:

private boolean hasCrops(IBlockReader p_176529_0_, BlockPos worldIn) {
    IBlockState state = p_176529_0_.getBlockState(worldIn.up());
    return state.getBlock() instanceof net.minecraftforge.common.IPlantable && canSustainPlant(state, p_176529_0_, worldIn, EnumFacing.UP,
        (net.minecraftforge.common.IPlantable)state.getBlock());
}

This is what it should look like imo:

private boolean hasCrops(IBlockReader p_176529_0_, BlockPos worldIn) {
    IBlockState plantState = p_176529_0_.getBlockState(worldIn.up());
    IBlockState blockState = p_176529_0_.getBlockState(worldIn);
    return plantState.getBlock() instanceof net.minecraftforge.common.IPlantable && canSustainPlant(blockState, p_176529_0_, worldIn,
        EnumFacing.UP, (net.minecraftforge.common.IPlantable)plantState.getBlock());
}

The reason is that the first argument of canSustainPlant should be the blockState of the supporting block, here farmland. The method is being passed the state of the plant, however.

For me, this caused a crash, because in my CustomFarmland's canSustainPlant method, I checked an IProperty from the passed state, however the plant state that was passed doesn't have that IProperty. Ended up just overriding tick() so I don't have a problem here anymore.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.