Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/SimpleBatteries.java#L24

A common proxy makes no sense. Proxies exist to separate sided-only code. If your code is common then it goes anywhere else but the proxy.

 

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/content/ModBlocks.java#L15

  1. Don't ever use static initializers for registry entries. They must be instantinated in the appropriate registry event.
  2. This is not how ObjectHolders are used. ObjectHolders inject values into fields.

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/proxy/CommonProxy.java#L21

Your proxy can't be an event handler since it will load the class and crash the game.

 

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/content/blocks/BlockBase.java

Don't do XBase. There is already a BlockBase, it's called Block. Do not abuse inheritance.

 

Your issue is caused by you not setting the registry name for your blocks/items. You need to set the registry name before registering them.

You probably followed some terrible youtube tutorials...

1. Do not create Base classes (ItemBase, BlockBase, etc). Read the Common issues and recommendation for more explanation.

2. Don't do this. Use normal getters and setters instead.

3. The TileEntityFurnace already has a public static function of getting the burn time of items. No need to copy paste all that here.

4. There's really no much point in overriding methods that relate to customNames (unless you really know what you are doing).

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

  • Author
On 5/30/2019 at 9:55 PM, DavidM said:

You probably followed some terrible youtube tutorials...

1. Do not create Base classes (ItemBase, BlockBase, etc). Read the Common issues and recommendation for more explanation.

2. Don't do this. Use normal getters and setters instead.

3. The TileEntityFurnace already has a public static function of getting the burn time of items. No need to copy paste all that here.

4. There's really no much point in overriding methods that relate to customNames (unless you really know what you are doing).

Yeah. I used tutorial by Harry Talks, for the Machine stuff because I had no idea how that stuff works.

HarryTalks is one of the worst modding tutorials.

I would suggest to read vanilla’s code for blocks like furnace as well as to read the code of machines from other mods on GitHub.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.