Jump to content

Recommended Posts

Posted

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/SimpleBatteries.java#L24

A common proxy makes no sense. Proxies exist to separate sided-only code. If your code is common then it goes anywhere else but the proxy.

 

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/content/ModBlocks.java#L15

  1. Don't ever use static initializers for registry entries. They must be instantinated in the appropriate registry event.
  2. This is not how ObjectHolders are used. ObjectHolders inject values into fields.

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/proxy/CommonProxy.java#L21

Your proxy can't be an event handler since it will load the class and crash the game.

 

https://github.com/JGgithub2018/Simple-Batteries/blob/master/src/main/java/jgcodes/sb/content/blocks/BlockBase.java

Don't do XBase. There is already a BlockBase, it's called Block. Do not abuse inheritance.

 

Your issue is caused by you not setting the registry name for your blocks/items. You need to set the registry name before registering them.

Posted

You probably followed some terrible youtube tutorials...

1. Do not create Base classes (ItemBase, BlockBase, etc). Read the Common issues and recommendation for more explanation.

2. Don't do this. Use normal getters and setters instead.

3. The TileEntityFurnace already has a public static function of getting the burn time of items. No need to copy paste all that here.

4. There's really no much point in overriding methods that relate to customNames (unless you really know what you are doing).

Some tips:

  Reveal hidden contents

 

Posted
  On 5/31/2019 at 1:55 AM, DavidM said:

You probably followed some terrible youtube tutorials...

1. Do not create Base classes (ItemBase, BlockBase, etc). Read the Common issues and recommendation for more explanation.

2. Don't do this. Use normal getters and setters instead.

3. The TileEntityFurnace already has a public static function of getting the burn time of items. No need to copy paste all that here.

4. There's really no much point in overriding methods that relate to customNames (unless you really know what you are doing).

Expand  

Yeah. I used tutorial by Harry Talks, for the Machine stuff because I had no idea how that stuff works.

Posted

HarryTalks is one of the worst modding tutorials.

I would suggest to read vanilla’s code for blocks like furnace as well as to read the code of machines from other mods on GitHub.

Some tips:

  Reveal hidden contents

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.