Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

(solved)World.setWorldTime(#) not working... (MC 1.12.2)

pacguy

By pacguy
in Modder Support

 Share

Recommended Posts

pacguy Tree Puncher

pacguy

Posted
Posted (edited)

I have a custom dimension that I'm trying to create a custom day/night cycle for. My plan is to compensate for the vanilla day night cycle (I tried using the doDayNightCycle game rule, but that affected the overworld...), and then increment time about 4 times slower then normal by setting it during a WorldTickEvent.

 

This is what I have so far: 

    @SubscribeEvent
    public static void WorldTickEvent(WorldTickEvent event) {
    	if(event.world.isRemote) {
    		return; //if on client, fail
    	}
    	
    	//are we in ice dimension?
    	if(event.world.provider.getDimension() == ModDimensions.TEST_DIM_ID) {
    		//if so, take manual control of this worlds time progression.
    		
    		iceDimensionTimeProgression += 1; //increment external delay timer by 1
    		
    		//if 4 ticks have passed...
    		//if(iceDimensionTimeProgression == 4) {
    			//reset time progression variable
    			iceDimensionTimeProgression = 0;
    			//update world time by 1 (4x slower then normal)
    			event.world.setWorldTime(event.world.getWorldTime() + 5L);
    			System.out.println("world time updated in ice dimension, time is " + event.world.getWorldTime());
    			System.out.println("World is " + event.world.getClass().getName() + ", world provider is " + event.world.provider.getClass().getName());
    		//}
    	}
    }

I apologize in advance for the dirty commented out if statement and redundant iceDimensionTimeProgression variable. They work as intended, but I have them disabled to make troubleshooting easier.

 

My problem is that setWorldTime never does anything. I've tried to set it to static test numbers, but they always have no effect. If the current time starts as 1842 for example, and I try calling "event.world.setWorldTime(69)", the world time will remain at 1842. The only way I'm even able to influence it at all (other then the doDayNightCycle gamerule) is via the in game command "time set #"! As far as I can tell, the in game command and the code responsible for the vanilla day night cycle use this routine as well, on both the client and server sides, so I'm not sure why it wouldn't work...

 

Here's a typical log output from this routine, with doDayNightCycle set to false to make debugging simpler: 

[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:138]: world time updated in ice dimension, time is 1491
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:139]: World is net.minecraft.world.WorldServerMulti, world provider is pacca.firstmod.dimension.TestWorldProvider
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:138]: world time updated in ice dimension, time is 1491
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:139]: World is net.minecraft.world.WorldServerMulti, world provider is pacca.firstmod.dimension.TestWorldProvider
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:138]: world time updated in ice dimension, time is 1491
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:139]: World is net.minecraft.world.WorldServerMulti, world provider is pacca.firstmod.dimension.TestWorldProvider
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:138]: world time updated in ice dimension, time is 1491
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:139]: World is net.minecraft.world.WorldServerMulti, world provider is pacca.firstmod.dimension.TestWorldProvider
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:138]: world time updated in ice dimension, time is 1491
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:139]: World is net.minecraft.world.WorldServerMulti, world provider is pacca.firstmod.dimension.TestWorldProvider
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:138]: world time updated in ice dimension, time is 1491
[13:11:42] [Server thread/INFO] [STDOUT]: [pacca.firstmod.CommonProxy:WorldTickEvent:139]: World is net.minecraft.world.WorldServerMulti, world provider is pacca.firstmod.dimension.TestWorldProvider

note that getWorldTime() clearly functions as intended, but the world time is never set to getWorldTime()+5 as the routine is supposed to do. Am I missing something?

Edited by pacguy

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • HOTDOGKING272829
      Could somebody help with my modpack not working

      By HOTDOGKING272829 · Posted

      logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • Martingonn
      Decompile minecraft INDEV?

      By Martingonn · Posted

      You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Martingonn
      Decompile minecraft INDEV?

      By Martingonn · Posted

      Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • Orichalcum
      Getting Holder<Enchantment> from RegistryKey in GLM

      By Orichalcum · Posted

      I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
    • NezumiMaus5
      cant find out what causing these errors (crash log below) Mixin config bbb.mixins.json does not specify "minVersion" property

      By NezumiMaus5 · Posted

      https://paste.ee/p/lw0XkwYJ

  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept