Item capability help

[stepsword]

I have an item capability and I'm trying to get one of the values to display on the client, in the tooltip.

 

To do this, I overrode getNBTShareTag and readNBTShareTag to save the NBT from the capability, and this works to an extent. But when testing in LAN multiplayer, players other than the world's hosting player don't seem to have the value available to them in the tooltip, even if they create the item. Any ideas? Is NBTsharetag sufficient for this? If I put the item in a chest, it simultaneously renders properly for the host player and does not render the value for the other player.

 

I do set the values of the capability on the server side. 

[stepsword]

11 minutes ago, diesieben07 said:

Show your code.

Creating the item:

 

if (!world.isRemote) {
    ItemStack stack = getItemToGive();
    if (stack != null && caster != null && caster.getUniqueID().equals(getCasterUUID())) {
        stack.setCount(1);
        //put the item in user's inventory
        if (stack.getItem() instanceof SpellScroll) {
            ((SpellScroll) stack.getItem()).getCapability(stack).setCasterUUID(caster.getUniqueID());
            ((SpellScroll) stack.getItem()).getCapability(stack).setCasterName(caster.getName());
        }
        //EntityItem itemDrop = new EntityItem(world, pos.getX(), pos.getY(), pos.getZ(), stack);
        Block.spawnAsEntity(world, pos, stack);
        world.setBlockState(pos, Blocks.AIR.getDefaultState(), 3);
    }
}

 

NBTShareTag and tooltip:

 

@Override
public NBTTagCompound getNBTShareTag(ItemStack stack) {

    IScrollMahou scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
    NBTBase nbt = ScrollMahouProvider.MAHOU.getStorage().writeNBT(ScrollMahouProvider.MAHOU, scrollMahou, null);
    if (nbt == null) nbt = new NBTTagCompound();
    if (!stack.hasTagCompound()) stack.setTagCompound(new NBTTagCompound());
    NBTTagCompound ret = stack.getTagCompound();
    if (ret == null) ret = new NBTTagCompound();
    ret.setTag("mahouCaster", nbt);
    return ret;
}

@Override
public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
    super.addInformation(stack, worldIn, tooltip, flagIn);
    IScrollMahou scrollMahou;

    Item item = stack.getItem();
    if (item instanceof SpellScroll && stack.hasCapability(ScrollMahouProvider.MAHOU, null)) {
        scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
        if (scrollMahou != null) {
            String name = scrollMahou.getCasterName();
            if (name != null && !name.isEmpty()) {
                tooltip.add("Bound to " + name);
            } else {
                tooltip.add("Bound to: ???");
            }
        }
    }
}

public void readNBTShareTag(ItemStack stack) {
    if (stack.hasTagCompound()) {
        NBTTagCompound nbt = stack.getTagCompound();
        if (nbt == null) nbt = new NBTTagCompound();
        IScrollMahou scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
        IScrollMahou serverScrollMahou = new ScrollMahou();
        if (nbt.hasKey("mahouCaster")) {
            ScrollMahouProvider.MAHOU.getStorage().readNBT(ScrollMahouProvider.MAHOU, serverScrollMahou, null, nbt.getTag("mahouCaster"));
            if (scrollMahou != null) {
                scrollMahou.setCasterUUID(serverScrollMahou.getCasterUUID());
                scrollMahou.setCasterName(serverScrollMahou.getCasterName());
            }
        }
    }
}

[stepsword]

Nevermind I'm stupid and forgot to @Override to make sure the parameters are right
 

Edit: updated code - in my defense I wrote this class when I was just starting to mod so I didn't really understand what these functions did at all. Surprised it even worked in the first place

 

@Override
public NBTTagCompound getNBTShareTag(ItemStack stack) {

    IScrollMahou scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
    NBTBase nbt = ScrollMahouProvider.MAHOU.getStorage().writeNBT(ScrollMahouProvider.MAHOU, scrollMahou, null);
    NBTTagCompound ret = stack.getTagCompound();
    if (ret == null) ret = new NBTTagCompound();
    if (nbt != null)
        ret.setTag("mahouCaster", nbt);
    return ret;
}

@Override
public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
    super.addInformation(stack, worldIn, tooltip, flagIn);
    IScrollMahou scrollMahou;

    Item item = stack.getItem();
    if (item instanceof SpellScroll && stack.hasCapability(ScrollMahouProvider.MAHOU, null)) {
        scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
        if (scrollMahou != null) {
            String name = scrollMahou.getCasterName();
            if (name != null && !name.isEmpty()) {
                tooltip.add("Bound to " + name);
            } else {
                tooltip.add("Bound to: ???");
            }
        }
    }
}

@Override
public void readNBTShareTag(ItemStack stack, NBTTagCompound nbtt) {
    IScrollMahou scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
    IScrollMahou serverScrollMahou = new ScrollMahou();
    if (nbtt != null && nbtt.hasKey("mahouCaster")) {
        ScrollMahouProvider.MAHOU.getStorage().readNBT(ScrollMahouProvider.MAHOU, serverScrollMahou, null, nbtt.getTag("mahouCaster"));
        if (scrollMahou != null) {
            scrollMahou.setCasterUUID(serverScrollMahou.getCasterUUID());
            scrollMahou.setCasterName(serverScrollMahou.getCasterName());
        }
    }
}

Edited September 7, 2019 by stepsword