Jump to content

Recommended Posts

Posted

I have an item capability and I'm trying to get one of the values to display on the client, in the tooltip.

 

To do this, I overrode getNBTShareTag and readNBTShareTag to save the NBT from the capability, and this works to an extent. But when testing in LAN multiplayer, players other than the world's hosting player don't seem to have the value available to them in the tooltip, even if they create the item. Any ideas? Is NBTsharetag sufficient for this? If I put the item in a chest, it simultaneously renders properly for the host player and does not render the value for the other player.

 

I do set the values of the capability on the server side. 

Posted
11 minutes ago, diesieben07 said:

Show your code.

Creating the item:

 

if (!world.isRemote) {
    ItemStack stack = getItemToGive();
    if (stack != null && caster != null && caster.getUniqueID().equals(getCasterUUID())) {
        stack.setCount(1);
        //put the item in user's inventory
        if (stack.getItem() instanceof SpellScroll) {
            ((SpellScroll) stack.getItem()).getCapability(stack).setCasterUUID(caster.getUniqueID());
            ((SpellScroll) stack.getItem()).getCapability(stack).setCasterName(caster.getName());
        }
        //EntityItem itemDrop = new EntityItem(world, pos.getX(), pos.getY(), pos.getZ(), stack);
        Block.spawnAsEntity(world, pos, stack);
        world.setBlockState(pos, Blocks.AIR.getDefaultState(), 3);
    }
}

 

NBTShareTag and tooltip:

 

@Override
public NBTTagCompound getNBTShareTag(ItemStack stack) {

    IScrollMahou scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
    NBTBase nbt = ScrollMahouProvider.MAHOU.getStorage().writeNBT(ScrollMahouProvider.MAHOU, scrollMahou, null);
    if (nbt == null) nbt = new NBTTagCompound();
    if (!stack.hasTagCompound()) stack.setTagCompound(new NBTTagCompound());
    NBTTagCompound ret = stack.getTagCompound();
    if (ret == null) ret = new NBTTagCompound();
    ret.setTag("mahouCaster", nbt);
    return ret;
}

@Override
public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
    super.addInformation(stack, worldIn, tooltip, flagIn);
    IScrollMahou scrollMahou;

    Item item = stack.getItem();
    if (item instanceof SpellScroll && stack.hasCapability(ScrollMahouProvider.MAHOU, null)) {
        scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
        if (scrollMahou != null) {
            String name = scrollMahou.getCasterName();
            if (name != null && !name.isEmpty()) {
                tooltip.add("Bound to " + name);
            } else {
                tooltip.add("Bound to: ???");
            }
        }
    }
}

public void readNBTShareTag(ItemStack stack) {
    if (stack.hasTagCompound()) {
        NBTTagCompound nbt = stack.getTagCompound();
        if (nbt == null) nbt = new NBTTagCompound();
        IScrollMahou scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
        IScrollMahou serverScrollMahou = new ScrollMahou();
        if (nbt.hasKey("mahouCaster")) {
            ScrollMahouProvider.MAHOU.getStorage().readNBT(ScrollMahouProvider.MAHOU, serverScrollMahou, null, nbt.getTag("mahouCaster"));
            if (scrollMahou != null) {
                scrollMahou.setCasterUUID(serverScrollMahou.getCasterUUID());
                scrollMahou.setCasterName(serverScrollMahou.getCasterName());
            }
        }
    }
}

Posted (edited)

Nevermind I'm stupid and forgot to @Override to make sure the parameters are right
 

Edit: updated code - in my defense I wrote this class when I was just starting to mod so I didn't really understand what these functions did at all. Surprised it even worked in the first place

 

@Override
public NBTTagCompound getNBTShareTag(ItemStack stack) {

    IScrollMahou scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
    NBTBase nbt = ScrollMahouProvider.MAHOU.getStorage().writeNBT(ScrollMahouProvider.MAHOU, scrollMahou, null);
    NBTTagCompound ret = stack.getTagCompound();
    if (ret == null) ret = new NBTTagCompound();
    if (nbt != null)
        ret.setTag("mahouCaster", nbt);
    return ret;
}

@Override
public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
    super.addInformation(stack, worldIn, tooltip, flagIn);
    IScrollMahou scrollMahou;

    Item item = stack.getItem();
    if (item instanceof SpellScroll && stack.hasCapability(ScrollMahouProvider.MAHOU, null)) {
        scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
        if (scrollMahou != null) {
            String name = scrollMahou.getCasterName();
            if (name != null && !name.isEmpty()) {
                tooltip.add("Bound to " + name);
            } else {
                tooltip.add("Bound to: ???");
            }
        }
    }
}

@Override
public void readNBTShareTag(ItemStack stack, NBTTagCompound nbtt) {
    IScrollMahou scrollMahou = stack.getCapability(ScrollMahouProvider.MAHOU, null);
    IScrollMahou serverScrollMahou = new ScrollMahou();
    if (nbtt != null && nbtt.hasKey("mahouCaster")) {
        ScrollMahouProvider.MAHOU.getStorage().readNBT(ScrollMahouProvider.MAHOU, serverScrollMahou, null, nbtt.getTag("mahouCaster"));
        if (scrollMahou != null) {
            scrollMahou.setCasterUUID(serverScrollMahou.getCasterUUID());
            scrollMahou.setCasterName(serverScrollMahou.getCasterName());
        }
    }
}
Edited by stepsword

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • When i try to join my friends server with mods it just says failed to log in: the authentication servers are currently not reachable. I've been having this issue for a while now and no method I've tried to fix it works. I've seen a lot of people fixing it by modifying the host.txt file and removing anything related to Mojang but when I open mine there's nothing related to Mojang there. I also tried flushing DNS cache, and changing my IPV6 to 8888, but nothing works.  It only happens when the mods are on too. When I join my friends server on vanilla it works, but not with mods. I can join multiplayer servers like hypixel. I can also play singleplayer with the mods and it works perfectly. The mods are up to date with the versions and the servers, but it just never gets past "Logging in" when i try to join their server. I use Curseforge to launch my mods, so that could maybe have something to do with it because it's technically a third party server, but it hasn't given me any trouble besides this one issue. I do not have MCLeaks and don't know what that is, but how can i search for it anyway to make sure? I have uninstalled minecraft launcher, updated my microsoft and my videocard drivers, reset my wifi and checked my parental settings (I am the owner on my computer), flushed my dns, modifying my host file to delete mojang but there's nothing with mojang on there, disabled my firewall, changed my IPV6 domain to 8888, restarted my router, and none of that works. I have researched this issue thoroughly and tried every solution I have came across and nothing is fixing the problem so i have come here as a last ditch effort. All i want to do is play mods with my friend. My friend has no issues with the server or mods and he has it through curseforge too. I would like further assistance in any way you think could help or even refer me to another forum that could help with this. Genuinely I cannot figure out why it doesn't work I would love any sort of further help.  
    • been getting this error and followed the old tick loop post however i cant figure out what file to delete Description: Exception in server tick loop java.lang.NullPointerException: Cannot invoke "net.minecraft.world.level.LevelAccessor.m_7654_()" because the return value of "net.minecraftforge.event.level.LevelEvent$Unload.getLevel()" is null     at com.lion.graveyard.platform.forge.HordeSpawner.onWorldUnload(HordeSpawner.java:41) ~[The_Graveyard_3.1_(FORGE)_for_1.20.1.jar%23196!/:?] {re:classloading}     at com.lion.graveyard.platform.forge.__HordeSpawner_onWorldUnload_Unload.invoke(.dynamic) ~[The_Graveyard_3.1_(FORGE)_for_1.20.1.jar%23196!/:?] {re:classloading,pl:eventbus:B}     at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.5.jar%2352!/:?] {}     at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%2352!/:?] {}     at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%2352!/:?] {}     at net.mehvahdjukaar.moonlight.api.platform.forge.PlatHelperImpl.invokeLevelUnload(PlatHelperImpl.java:279) ~[moonlight-1.20-2.13.66-forge.jar%23185!/:?] {re:classloading}     at net.mehvahdjukaar.moonlight.api.platform.PlatHelper.invokeLevelUnload(PlatHelper.java) ~[moonlight-1.20-2.13.66-forge.jar%23185!/:?] {re:mixin,re:classloading}     at net.mehvahdjukaar.moonlight.core.misc.FakeLevelManager.invalidate(FakeLevelManager.java:29) ~[moonlight-1.20-2.13.66-forge.jar%23185!/:?] {re:classloading}     at net.mehvahdjukaar.supplementaries.common.utils.fake_level.BlockTestLevel.invalidate(BlockTestLevel.java:34) ~[supplementaries-1.20-3.1.13.jar%23192!/:?] {re:classloading}     at net.mehvahdjukaar.supplementaries.common.block.faucet.FaucetBehaviorsManager.onReloadWithLevel(FaucetBehaviorsManager.java:129) ~[supplementaries-1.20-3.1.13.jar%23192!/:?] {re:classloading}     at net.mehvahdjukaar.supplementaries.common.events.ServerEvents.onServerStart(ServerEvents.java:160) ~[supplementaries-1.20-3.1.13.jar%23192!/:?] {re:mixin,re:classloading}     at net.mehvahdjukaar.supplementaries.common.events.forge.ServerEventsForge.onServerStart(ServerEventsForge.java:119) ~[supplementaries-1.20-3.1.13.jar%23192!/:?] {re:classloading}     at net.mehvahdjukaar.supplementaries.common.events.forge.__ServerEventsForge_onServerStart_ServerStartedEvent.invoke(.dynamic) ~[supplementaries-1.20-3.1.13.jar%23192!/:?] {re:classloading,pl:eventbus:B}     at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.5.jar%2352!/:?] {}     at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%2352!/:?] {}     at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%2352!/:?] {}     at net.minecraftforge.server.ServerLifecycleHooks.handleServerStarted(ServerLifecycleHooks.java:115) ~[forge-1.20.1-47.3.29-universal.jar%23212!/:?] {re:classloading}     at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:638) ~[server-1.20.1-20230612.114412-srg.jar%23207!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraftserver,xf:fml:xaerominimap:xaero_minecraftserver,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraftserver,xf:fml:xaerominimap:xaero_minecraftserver,pl:mixin:APP:unionlib.mixins.json:MinecraftServerMixin,pl:mixin:APP:citadel.mixins.json:MinecraftServerMixin,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:A}     at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:251) ~[server-1.20.1-20230612.114412-srg.jar%23207!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraftserver,xf:fml:xaerominimap:xaero_minecraftserver,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraftserver,xf:fml:xaerominimap:xaero_minecraftserver,pl:mixin:APP:unionlib.mixins.json:MinecraftServerMixin,pl:mixin:APP:citadel.mixins.json:MinecraftServerMixin,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:A}     at java.lang.Thread.run(Thread.java:833) ~[?:?] {}  
    • Online forums in general seem to be declining in popularity imo. There’s still value here for certain types of content, such as written tutorials and blog posts which would otherwise get lost in the chat history fairly quickly on Discord. Also for those that prefer the forums format ofc. But for faster support related topics, I agree that the Discord is probably your best bet at the moment. The speed of responses is also down to the ratio of volunteers - the player support forum still seems pretty active, but the coding ones much less so. Once you’re feeling more confident in your modding skills, be the change you want to see
    • try the same link, i swapped logs after sitting in the world for a few minutes then leaving. Lmk if it keeps happening then ill just send a video of the live log on modrinth
    • It is an issue with chimes
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.