Jump to content

Recommended Posts

Posted

I want to make a custom Structure for my minecraft mod. I have been able to register other world features (flowers in my case) without any problems, but registering this structure isn't working. In the locate command, my structure is displayed as "minecraft:labyrinth" instead of with my modid. I put a breakpoint where the structure-start of my labyrinth is initialized (init method), but it doesn't seem to be called.

 

This is my code for registering:

@Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)
public class WorldGenRegistry {

    public static Feature<NoFeatureConfig> ENERGY_FLOWER;
    public static Structure<LabyrinthConfig> LABYRINTH;

    @SubscribeEvent
    public static void registerFeatures(RegistryEvent.Register<Feature<?>> event) {
        IForgeRegistry<Feature<?>> registry = event.getRegistry();

        ENERGY_FLOWER = registerFeature(new EnergyFlowersFeature(NoFeatureConfig::deserialize), "energy_flowers");
        LABYRINTH = registerStructure(new LabyrinthStructure(LabyrinthConfig::deserialize), "labyrinth");

        registry.registerAll(
                ENERGY_FLOWER,
                LABYRINTH
        );
    }

    private static <T extends IFeatureConfig> Feature<T> registerFeature(Feature<T> feature, String registryName) {
        feature.setRegistryName(registryName);
        return feature;
    }

    private static <T extends IFeatureConfig> Structure<T> registerStructure(Structure<T> structure, String registryName) {
        structure.setRegistryName(registryName);
        return structure;
    }

}

And my labyrinth structure:

public class LabyrinthStructure extends Structure<LabyrinthConfig> {

    public LabyrinthStructure(Function<Dynamic<?>, ? extends LabyrinthConfig> deserializer) {
        super(deserializer);
    }

    @Override
    public boolean hasStartAt(ChunkGenerator<?> generator, Random random, int chunkX, int chunkZ) {
        ChunkPos pos = this.getStartPositionForPosition(generator, random, chunkX, chunkZ, 0, 0);
        if (chunkX == pos.x && chunkZ == pos.z) {
            Biome biome = generator.getBiomeProvider().getBiome(new BlockPos((chunkX << 4) + 9, 0, (chunkZ << 4) + 9));
            return generator.hasStructure(biome, WorldGenRegistry.LABYRINTH);
        } else {
            return false;
        }
    }

    @Override
    public IStartFactory getStartFactory() {
        return Start::new;
    }

    @Override
    public String getStructureName() {
        return "Labyrinth";
    }

    @Override
    public int getSize() {
        return 8; //TODO what is this?
    }

    public static class Start extends MarginedStructureStart {

        public Start(Structure<?> structure, int chunkPosX, int chunkPosZ, Biome biome, MutableBoundingBox bounds, int reference, long seed) {
            super(structure, chunkPosX, chunkPosZ, biome, bounds, reference, seed);
        }

        @Override
        public void init(ChunkGenerator<?> generator, TemplateManager templateManagerIn, int chunkX, int chunkZ, Biome biomeIn) {
            LabyrinthConfig config = generator.getStructureConfig(biomeIn, WorldGenRegistry.LABYRINTH);
            BlockPos pos = new BlockPos(chunkX * 16, 0, chunkZ * 16);

            System.out.println("GENERATE LABYRINTh"); //breakpoint here

            //TODO: VillagePieces.func_214838_a(generator, templateManagerIn, pos, this.components, this.rand, config);
            this.recalculateStructureSize();
        }

    }

}

 

I doubt anything is wrong with the LabyrinthConfig, so I'm not posting it unless requested.

Any help is greatly appreciated!

Posted (edited)

Cause it's string by default not ResourceLocation
 

    private static <T extends IFeatureConfig> Structure<T> registerStructure(Structure<T> structure, String registryName) {
        structure.setRegistryName(registryName);
        return structure;
    }

You need to add your modid to (registryName). 
Also it seems that Structure registry is somehow... changed. Look at "Structures" file and Structures field in "Feature" file. 

Edited by Krevik

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • When I first heard about Bitcoin back in 2018, I was skeptical. The idea of a decentralized, digital currency seemed too good to be true. But I was intrigued as I learned more about the technology behind it and its potential. I started small, investing just a few hundred dollars, dipping my toes into the cryptocurrency waters. At first, it was exhilarating to watch the value of my investment grow exponentially. I felt like I was part of the future, an early adopter of this revolutionary new asset. But that euphoria was short-lived. One day, I logged into my digital wallet only to find it empty - my Bitcoin had vanished without a trace. It turned out that the online exchange I had trusted had been hacked, and my funds were stolen. I was devastated, both financially and emotionally. All the potential I had seen in Bitcoin was tainted by the harsh reality that with decentralization came a lack of regulation and oversight. My hard-earned money was gone, lost to the ether of the digital world. This experience taught me a painful lesson about the price of trust in the uncharted territory of cryptocurrency. While the technology holds incredible promise, the risks can be catastrophic if you don't approach it with extreme caution. My Bitcoin investment gamble had failed, and I was left to pick up the pieces, wiser but poorer for having placed my faith in the wrong hands. My sincere appreciation goes to MUYERN TRUST HACKER. You are my hero in recovering my lost funds. Send a direct m a i l ( muyerntrusted ( @ ) mail-me ( . )c o m ) or message on whats app : + 1 ( 4-4-0 ) ( 3 -3 -5 ) ( 0-2-0-5 )
    • You could try posting a log (if there is no log at all, it may be the launcher you are using, the FAQ may have info on how to enable the log) as described in the FAQ, however this will probably need to be reported to/remedied by the mod author.
    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.