Jump to content

Potion attribute modifiers not being removed after potion ends


Recommended Posts

Posted

My code:

    /**
     * defines what the plague effect does and clears the modifiers after the effect has ended
     * @param event : world events
     */
    @SubscribeEvent
    public static void plaguePotionActive(PlayerTickEvent event)
    {
        boolean isActive = false;
        if (event.player.isPotionActive(MystPotions.PLAGUE_EFFECT))
        {
            isActive = true;
        }
        
        if (isActive == true)
        {
            if(MystPotions.alreadyActive == false)
            {
                String UUID = MathHelper.getRandomUUID().toString();
                
                MystPotions.PLAGUE_EFFECT.registerPotionAttributeModifier(SharedMonsterAttributes.MOVEMENT_SPEED, UUID, -0.15000000596046448D * 0.5, 2);
                MystPotions.PLAGUE_EFFECT.registerPotionAttributeModifier(SharedMonsterAttributes.ATTACK_SPEED, UUID,  -0.10000000149011612D * 0.5, 2);
                MystPotions.alreadyActive = true;
            }
            
            if  (event.player.getHealth() > event.player.getMaxHealth() * 0.5 && event.player.world.getDifficulty() != EnumDifficulty.EASY)
            {
                event.player.attackEntityFrom(DamageSource.MAGIC, 1.0F);
            }
        }
        else
        {    
            //Map<IAttribute, AttributeModifier> tmp = MystPotions.PLAGUE_EFFECT.getAttributeModifierMap();
            //Multimap<String, AttributeModifier> modifiers =  (Multimap) tmp;
            //event.player.getAttributeMap().removeAttributeModifiers(modifiers);
            //MystPotions.PLAGUE_EFFECT.removeAttributesModifiersFromEntity(event.player, (AbstractAttributeMap) tmp, 2);
            MystPotions.alreadyActive = false;
        }
    }

 

Using the code that is in comments above causes the game to crash as i can't cast a Map to an AbstractAttributeMap.

What methods can i use to only remove the modifiers of this potion?

Posted
16 hours ago, diesieben07 said:

The Potion class already has mechanisms that do already this, you do not need an event handler. Why have those not worked for you?

I'm going of off tutorials on youtube to find my way around the minecraft classes and this is one of the ways shown in the vid.

I just changed it and put it directly into the potion init class and everything works fine now. However i still need access to the player's hp for this code:

16 hours ago, nil said:

           if  (event.player.getHealth() > event.player.getMaxHealth() * 0.5 && event.player.world.getDifficulty() != EnumDifficulty.EASY)
            {
                event.player.attackEntityFrom(DamageSource.MAGIC, 1.0F);
            }

How do i get the player/entity affected by this effect?

Posted

I tried using this in my CustomPotions class however this doesn't work:

    @Override
    public void performEffect(EntityLivingBase entityLivingBaseIn, int amplifier)
    {
        if (entityLivingBaseIn.isPotionActive(MystPotions.PLAGUE_EFFECT))
        {
            if(!entityLivingBaseIn.isEntityUndead())
            {
                if (entityLivingBaseIn.getHealth() > entityLivingBaseIn.getMaxHealth() * 0.5 && entityLivingBaseIn.world.getDifficulty() != EnumDifficulty.EASY)
                {
                    entityLivingBaseIn.attackEntityFrom(DamageSource.MAGIC, 1.0F);
                }
            }
            else
            {
                if (entityLivingBaseIn.getHealth() < entityLivingBaseIn.getMaxHealth())
                {
                    entityLivingBaseIn.heal(1.0F);
                }
            }
        }
    }

NOTE: i am not using a different class per potion so isPotionActive or sth similar has to be checked

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Maybe there are other mods, not compatible with 47.4.4 - the 2nd 4 indicates mayor changes - so some mods may not compatible with it
    • Nope still the same issue exit code 1
    • I have no idea what the flip is going on, I can load the modpack just fine at forge 42.2.0 but any forge version above it insta-crashes with exit code 1. Can somebody tell me what's going on, this is minecraft 1.20.1 Latest.log: https://pastebin.com/pBUL1ZFa
    • does anyone know how to incorporate custom noise settings into a custom dimension through the use of datagen, I have created a custon json file for the noise settings that I want but I just don't know how to get it to register with the generated json file of the custom dimension.   here is the code for the dimension class package net.hurst.lustria.worldgen.dimension; import com.mojang.datafixers.util.Pair; import net.hurst.lustria.Lustria; import net.hurst.lustria.worldgen.biome.ModBiomes; import net.hurst.lustria.worldgen.registries.LustriaNoiseSettings; import net.minecraft.core.HolderGetter; import net.minecraft.core.registries.Registries; import net.minecraft.data.worldgen.BootstapContext; import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; import net.minecraft.tags.BlockTags; import net.minecraft.util.valueproviders.ConstantInt; import net.minecraft.world.level.Level; import net.minecraft.world.level.biome.*; import net.minecraft.world.level.dimension.BuiltinDimensionTypes; import net.minecraft.world.level.dimension.DimensionType; import net.minecraft.world.level.dimension.LevelStem; import net.minecraft.world.level.levelgen.NoiseBasedChunkGenerator; import net.minecraft.world.level.levelgen.NoiseGeneratorSettings; import java.util.List; import java.util.OptionalLong; public class ModDimensions { public static final ResourceKey<LevelStem> LUSTRIA_KEY = ResourceKey.create(Registries.LEVEL_STEM, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<Level> LUSTRIA_LEVEL_KEY = ResourceKey.create(Registries.DIMENSION, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<DimensionType> LUSTRIA_DIM_TYPE = ResourceKey.create(Registries.DIMENSION_TYPE, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim_type")); public static void bootstrapType(BootstapContext<DimensionType> context) { context.register(LUSTRIA_DIM_TYPE, new DimensionType( OptionalLong.of(12000), // fixedTime false, // hasSkylight true, // hasCeiling false, // ultraWarm false, // natural 1.0, // coordinateScale true, // bedWorks false, // respawnAnchorWorks -64, // minY 256, // height 256, // logicalHeight BlockTags.INFINIBURN_OVERWORLD, // infiniburn BuiltinDimensionTypes.OVERWORLD_EFFECTS, // effectsLocation 0.0f, // ambientLight new DimensionType.MonsterSettings(false, false, ConstantInt.of(0), 0))); } public static void bootstrapStem(BootstapContext<LevelStem> context) { HolderGetter<Biome> biomeRegistry = context.lookup(Registries.BIOME); HolderGetter<DimensionType> dimTypes = context.lookup(Registries.DIMENSION_TYPE); HolderGetter<NoiseGeneratorSettings> noiseGenSettings = context.lookup(Registries.NOISE_SETTINGS); NoiseBasedChunkGenerator wrappedChunkGenerator = new NoiseBasedChunkGenerator( new FixedBiomeSource(biomeRegistry.getOrThrow(Biomes.BEACH)), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); NoiseBasedChunkGenerator noiseBasedChunkGenerator = new NoiseBasedChunkGenerator( MultiNoiseBiomeSource.createFromList( new Climate.ParameterList<>(List.of(Pair.of( Climate.parameters(0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BEACH)), Pair.of( Climate.parameters(0.1F, 0.2F, 0.0F, 0.2F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BIRCH_FOREST)), Pair.of( Climate.parameters(0.3F, 0.6F, 0.1F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.OCEAN)), Pair.of( Climate.parameters(0.4F, 0.3F, 0.2F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.DARK_FOREST)) ))), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); LevelStem stem = new LevelStem(dimTypes.getOrThrow(ModDimensions.LUSTRIA_DIM_TYPE), noiseBasedChunkGenerator); context.register(LUSTRIA_KEY, stem); } } minecraft version is 1.20.1
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.